From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2439AC433EF for ; Fri, 3 Dec 2021 18:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JLLcb57v5urGDnehqRvXESkrF2tl6MaZw4EjOF3XzPk=; b=tGYKVPUNA6fZQh 0LhXmvgJ4R4Ctuoty4LP3SIRn1MK1H63aKUbnCOkhH4BjNWyb5L9RwA6dmGfUvwP0yu43KbtpBPgy +hckqIcIvlFz9pgWldYPRa4x8SzS4b3P1cH1SwM+4m5ZGetrZqtK8DsoAtB4SXCmxyHdq51JJpTOs nE63WECjPlxLUQQBMdudglfb9OXhxh0femcmUSXtR8qpS/fZRCRecFeYYNtHZ5XhJ4jl/jXMhN3vF ehA/H8MoeiQbC5xwdkkGyIFE8k+mQjXaqEfCktzEXVuMIINULXWK/OU6INNb1Qy1ZLnPIEwrEgRXM cpHsa0ixXeKUsWXcdGmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtCtR-00Gj5Y-Cj; Fri, 03 Dec 2021 18:02:45 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtCtN-00Gj56-5a for linux-arm-kernel@lists.infradead.org; Fri, 03 Dec 2021 18:02:42 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10187"; a="224276915" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="224276915" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 10:02:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="598058027" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by FMSMGA003.fm.intel.com with ESMTP; 03 Dec 2021 10:02:18 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mtCsz-000HtT-BT; Fri, 03 Dec 2021 18:02:17 +0000 Date: Sat, 4 Dec 2021 02:01:57 +0800 From: kernel test robot To: Qin Jian , robh+dt@kernel.org Cc: kbuild-all@lists.01.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, maz@kernel.org, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver Message-ID: <202112040151.mCwZofQd-lkp@intel.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211203_100241_324041_51D9D01E X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Qin, I love your patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [cannot apply to pza/reset/next robh/for-next tip/irq/core linus/master v5.16-rc3 next-20211203] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20211203-154345 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211204/202112040151.mCwZofQd-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/14961fb5913762db86b6816b325ef2e87cf4a319 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20211203-154345 git checkout 14961fb5913762db86b6816b325ef2e87cf4a319 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/irqchip/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/irqchip/irq-sp7021-intc.c:223:6: warning: no previous prototype for 'sp_intc_set_ext' [-Wmissing-prototypes] 223 | void sp_intc_set_ext(u32 hwirq, int ext_num) | ^~~~~~~~~~~~~~~ >> drivers/irqchip/irq-sp7021-intc.c:229:12: warning: no previous prototype for 'sp_intc_init_dt' [-Wmissing-prototypes] 229 | int __init sp_intc_init_dt(struct device_node *node, struct device_node *parent) | ^~~~~~~~~~~~~~~ vim +/sp_intc_set_ext +223 drivers/irqchip/irq-sp7021-intc.c 222 > 223 void sp_intc_set_ext(u32 hwirq, int ext_num) 224 { 225 sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num); 226 } 227 EXPORT_SYMBOL_GPL(sp_intc_set_ext); 228 > 229 int __init sp_intc_init_dt(struct device_node *node, struct device_node *parent) 230 { 231 int i, ret; 232 233 sp_intc.g0 = of_iomap(node, 0); 234 if (!sp_intc.g0) 235 return -ENXIO; 236 237 sp_intc.g1 = of_iomap(node, 1); 238 if (!sp_intc.g1) { 239 ret = -ENXIO; 240 goto out_unmap0; 241 } 242 243 ret = sp_intc_irq_map(node, 0); // EXT_INT0 244 if (ret) 245 goto out_unmap1; 246 247 ret = sp_intc_irq_map(node, 1); // EXT_INT1 248 if (ret) 249 goto out_unmap1; 250 251 /* initial regs */ 252 for (i = 0; i < SP_INTC_NR_GROUPS; i++) { 253 /* all mask */ 254 writel_relaxed(0, REG_INTR_MASK + i * 4); 255 /* all edge */ 256 writel_relaxed(~0, REG_INTR_TYPE + i * 4); 257 /* all high-active */ 258 writel_relaxed(0, REG_INTR_POLARITY + i * 4); 259 /* all EXT_INT0 */ 260 writel_relaxed(~0, REG_INTR_PRIORITY + i * 4); 261 /* all clear */ 262 writel_relaxed(~0, REG_INTR_CLEAR + i * 4); 263 } 264 265 sp_intc.domain = irq_domain_add_linear(node, SP_INTC_NR_IRQS, 266 &sp_intc_dm_ops, &sp_intc); 267 if (!sp_intc.domain) { 268 ret = -ENOMEM; 269 goto out_unmap1; 270 } 271 272 raw_spin_lock_init(&sp_intc.lock); 273 274 return 0; 275 276 out_unmap1: 277 iounmap(sp_intc.g1); 278 out_unmap0: 279 iounmap(sp_intc.g0); 280 281 return ret; 282 } 283 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6787260084454034148==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver Date: Sat, 04 Dec 2021 02:01:57 +0800 Message-ID: <202112040151.mCwZofQd-lkp@intel.com> In-Reply-To: List-Id: --===============6787260084454034148== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Qin, I love your patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [cannot apply to pza/reset/next robh/for-next tip/irq/core linus/master v5.= 16-rc3 next-20211203] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Qin-Jian/Add-Sunplus-SP702= 1-SoC-Support/20211203-154345 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-n= ext config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211204/= 202112040151.mCwZofQd-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/14961fb5913762db86b6816b3= 25ef2e87cf4a319 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qin-Jian/Add-Sunplus-SP7021-SoC-Su= pport/20211203-154345 git checkout 14961fb5913762db86b6816b325ef2e87cf4a319 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash drivers/irqchip/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/irqchip/irq-sp7021-intc.c:223:6: warning: no previous prototype = for 'sp_intc_set_ext' [-Wmissing-prototypes] 223 | void sp_intc_set_ext(u32 hwirq, int ext_num) | ^~~~~~~~~~~~~~~ >> drivers/irqchip/irq-sp7021-intc.c:229:12: warning: no previous prototype= for 'sp_intc_init_dt' [-Wmissing-prototypes] 229 | int __init sp_intc_init_dt(struct device_node *node, struct devi= ce_node *parent) | ^~~~~~~~~~~~~~~ vim +/sp_intc_set_ext +223 drivers/irqchip/irq-sp7021-intc.c 222 = > 223 void sp_intc_set_ext(u32 hwirq, int ext_num) 224 { 225 sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num); 226 } 227 EXPORT_SYMBOL_GPL(sp_intc_set_ext); 228 = > 229 int __init sp_intc_init_dt(struct device_node *node, struct device_n= ode *parent) 230 { 231 int i, ret; 232 = 233 sp_intc.g0 =3D of_iomap(node, 0); 234 if (!sp_intc.g0) 235 return -ENXIO; 236 = 237 sp_intc.g1 =3D of_iomap(node, 1); 238 if (!sp_intc.g1) { 239 ret =3D -ENXIO; 240 goto out_unmap0; 241 } 242 = 243 ret =3D sp_intc_irq_map(node, 0); // EXT_INT0 244 if (ret) 245 goto out_unmap1; 246 = 247 ret =3D sp_intc_irq_map(node, 1); // EXT_INT1 248 if (ret) 249 goto out_unmap1; 250 = 251 /* initial regs */ 252 for (i =3D 0; i < SP_INTC_NR_GROUPS; i++) { 253 /* all mask */ 254 writel_relaxed(0, REG_INTR_MASK + i * 4); 255 /* all edge */ 256 writel_relaxed(~0, REG_INTR_TYPE + i * 4); 257 /* all high-active */ 258 writel_relaxed(0, REG_INTR_POLARITY + i * 4); 259 /* all EXT_INT0 */ 260 writel_relaxed(~0, REG_INTR_PRIORITY + i * 4); 261 /* all clear */ 262 writel_relaxed(~0, REG_INTR_CLEAR + i * 4); 263 } 264 = 265 sp_intc.domain =3D irq_domain_add_linear(node, SP_INTC_NR_IRQS, 266 &sp_intc_dm_ops, &sp_intc); 267 if (!sp_intc.domain) { 268 ret =3D -ENOMEM; 269 goto out_unmap1; 270 } 271 = 272 raw_spin_lock_init(&sp_intc.lock); 273 = 274 return 0; 275 = 276 out_unmap1: 277 iounmap(sp_intc.g1); 278 out_unmap0: 279 iounmap(sp_intc.g0); 280 = 281 return ret; 282 } 283 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org --===============6787260084454034148==--