[intel-lts:5.4/yocto 17294/18531] drivers/platform/x86/intel_isi_hstd.c:572:5: warning: no previous prototype for 'hstd_init'

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4081 bytes --]

Hi Karthik,

FYI, the error/warning still remains.

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   93b630f89c8d94187fd181ae4cbca13b4b47201c
commit: 6e9c23a32b60ca1e35e154e8d857c73b3c313734 [17294/18531] driver: platform: x86: ISI: [Hstd] Host STL Linux Driver for EHL FuSa
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20211205/202112050835.tsRoChSR-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel/linux-intel-lts/commit/6e9c23a32b60ca1e35e154e8d857c73b3c313734
        git remote add intel-lts https://github.com/intel/linux-intel-lts.git
        git fetch --no-tags intel-lts 5.4/yocto
        git checkout 6e9c23a32b60ca1e35e154e8d857c73b3c313734
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/x86/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/bitops.h:5,
                    from include/linux/kernel.h:12,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from drivers/platform/x86/intel_isi_hstd.c:8:
   drivers/platform/x86/intel_isi_hstd.c: In function 'global_ctrl_check':
   include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
       8 | #define BIT(nr)   (UL(1) << (nr))
         |                          ^~
   drivers/platform/x86/intel_isi_hstd.c:138:26: note: in expansion of macro 'BIT'
     138 |  uint64_t m = ~(BIT(0) | BIT(33));
         |                          ^~~
   drivers/platform/x86/intel_isi_hstd.c: In function 'global_ovfctrl_check':
   include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
       8 | #define BIT(nr)   (UL(1) << (nr))
         |                          ^~
   drivers/platform/x86/intel_isi_hstd.c:155:26: note: in expansion of macro 'BIT'
     155 |  uint64_t m = ~(BIT(0) | BIT(33));
         |                          ^~~
   include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
       8 | #define BIT(nr)   (UL(1) << (nr))
         |                          ^~
   drivers/platform/x86/intel_isi_hstd.c:162:29: note: in expansion of macro 'BIT'
     162 |  if (!(v & BIT(0)) || !(v & BIT(33)))
         |                             ^~~
   drivers/platform/x86/intel_isi_hstd.c: At top level:
>> drivers/platform/x86/intel_isi_hstd.c:572:5: warning: no previous prototype for 'hstd_init' [-Wmissing-prototypes]
     572 | int hstd_init(void)
         |     ^~~~~~~~~


vim +/hstd_init +572 drivers/platform/x86/intel_isi_hstd.c

   571	
 > 572	int hstd_init(void)
   573	{
   574		int err = 0;
   575	
   576		hstd_major_num = register_chrdev(0, DEVICE_NAME, &fops);
   577		if (hstd_major_num < 0)
   578			return hstd_major_num;
   579	
   580		hstd_class = class_create(THIS_MODULE, CLASS_NAME);
   581		if (IS_ERR(hstd_class)) {
   582			err = PTR_ERR(hstd_class);
   583			goto out_chrdev;
   584		}
   585	
   586		hstd_dev = device_create(hstd_class, NULL,
   587				MKDEV(hstd_major_num, 0), NULL, DEVICE_NAME);
   588		if (IS_ERR(hstd_dev)) {
   589			err = PTR_ERR(hstd_dev);
   590			goto out_class;
   591		}
   592		err = do_init();
   593		if (err)
   594			goto out_init;
   595	
   596		pr_info(PFX "Module version %s successfuly initilized\n", DRV_VERSION);
   597		return 0;
   598	
   599	out_init:
   600		device_destroy(hstd_class, MKDEV(hstd_major_num, 0));
   601	out_class:
   602		class_destroy(hstd_class);
   603	out_chrdev:
   604		unregister_chrdev(hstd_major_num, DEVICE_NAME);
   605		return err;
   606	}
   607	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org