From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1590C433EF for ; Mon, 6 Dec 2021 15:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346736AbhLFPNV (ORCPT ); Mon, 6 Dec 2021 10:13:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345981AbhLFPLR (ORCPT ); Mon, 6 Dec 2021 10:11:17 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D1E6C08EADB; Mon, 6 Dec 2021 07:05:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B73D61326; Mon, 6 Dec 2021 15:05:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E175CC341C2; Mon, 6 Dec 2021 15:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638803115; bh=AeM6+YCbkUVyd0AQ80afxnTgQ2BgDyv8QLYvIuh0OAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X1STwKGqFOqpFnP3Aie4NLbNhSn8vo1YPNNPoOYFpEddTN6LgMe+2bQBC3vPMMxZE KXI8ygkv9i4hpUw+ypIgI9ENgGK3xyUwbR6+3a+wJBMKT+xH8Omfx+Oj2cRUAjeKTr OVPWrMWJad3mBa2Di/UJLDm1hHC1zafR2xZnNryo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH 4.14 033/106] PCI: aardvark: Fix a leaked reference by adding missing of_node_put() Date: Mon, 6 Dec 2021 15:55:41 +0100 Message-Id: <20211206145556.506529711@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211206145555.386095297@linuxfoundation.org> References: <20211206145555.386095297@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Wen Yang commit 3842f5166bf1ef286fe7a39f262b5c9581308366 upstream. The call to of_get_next_child() returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear() also calls of_node_get() to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the following warnings: ./drivers/pci/controller/pci-aardvark.c:826:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 798, but without a corresponding object release within this function. Signed-off-by: Wen Yang Signed-off-by: Lorenzo Pieralisi Cc: Thomas Petazzoni Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Marek Behún Signed-off-by: Greg Kroah-Hartman --- drivers/pci/host/pci-aardvark.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) --- a/drivers/pci/host/pci-aardvark.c +++ b/drivers/pci/host/pci-aardvark.c @@ -789,6 +789,7 @@ static int advk_pcie_init_irq_domain(str struct device_node *node = dev->of_node; struct device_node *pcie_intc_node; struct irq_chip *irq_chip; + int ret = 0; raw_spin_lock_init(&pcie->irq_lock); @@ -803,8 +804,8 @@ static int advk_pcie_init_irq_domain(str irq_chip->name = devm_kasprintf(dev, GFP_KERNEL, "%s-irq", dev_name(dev)); if (!irq_chip->name) { - of_node_put(pcie_intc_node); - return -ENOMEM; + ret = -ENOMEM; + goto out_put_node; } irq_chip->irq_mask = advk_pcie_irq_mask; @@ -816,11 +817,13 @@ static int advk_pcie_init_irq_domain(str &advk_pcie_irq_domain_ops, pcie); if (!pcie->irq_domain) { dev_err(dev, "Failed to get a INTx IRQ domain\n"); - of_node_put(pcie_intc_node); - return -ENOMEM; + ret = -ENOMEM; + goto out_put_node; } - return 0; +out_put_node: + of_node_put(pcie_intc_node); + return ret; } static void advk_pcie_remove_irq_domain(struct advk_pcie *pcie) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3737C433EF for ; Mon, 6 Dec 2021 15:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lSKFM0PS8oMj3osBtCWPSBavj/p7tkC2KEXBkRZCUKQ=; b=FLB0ZIhED5vXYD xKdOaNwTOYCQaknODpIFgYKY4ONW0qzMmdgZxbv5VqTfXv34pQamx7R/f6hXjLNJCVi5rthuExg0i 5qTfjFuUrVM2DRIjUYjj1vlSPXEgERGrmx6idziEIjtjZPhlBtz+T8XloaGXKAlgCeWToZrMxVdqo 6Cd5qsDW7z2SgWN3eAcrPliIHLGLrifTWFFF5Ydlq4zK2oUKOw7yTOC4dQPt0us88uC3s0q/yGghZ IO+IHu9cVgtfm0JAMyQHkqFqFnWLf2/KKx9gDGozF+jRH8pj2hIB36qMoz9pQq7w8/4zBSRsA2JJc MzSccPcRnmn47wnH+b4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muFYd-004Mty-4y; Mon, 06 Dec 2021 15:05:35 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muFYN-004Mmb-7Y for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 15:05:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E784CB810F1; Mon, 6 Dec 2021 15:05:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E175CC341C2; Mon, 6 Dec 2021 15:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638803115; bh=AeM6+YCbkUVyd0AQ80afxnTgQ2BgDyv8QLYvIuh0OAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X1STwKGqFOqpFnP3Aie4NLbNhSn8vo1YPNNPoOYFpEddTN6LgMe+2bQBC3vPMMxZE KXI8ygkv9i4hpUw+ypIgI9ENgGK3xyUwbR6+3a+wJBMKT+xH8Omfx+Oj2cRUAjeKTr OVPWrMWJad3mBa2Di/UJLDm1hHC1zafR2xZnNryo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH 4.14 033/106] PCI: aardvark: Fix a leaked reference by adding missing of_node_put() Date: Mon, 6 Dec 2021 15:55:41 +0100 Message-Id: <20211206145556.506529711@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211206145555.386095297@linuxfoundation.org> References: <20211206145555.386095297@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_070519_471467_D0071163 X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogV2VuIFlhbmcgPHdlbi55YW5nOTlAenRlLmNvbS5jbj4KCmNvbW1pdCAzODQyZjUxNjZi ZjFlZjI4NmZlN2EzOWYyNjJiNWM5NTgxMzA4MzY2IHVwc3RyZWFtLgoKVGhlIGNhbGwgdG8gb2Zf Z2V0X25leHRfY2hpbGQoKSByZXR1cm5zIGEgbm9kZSBwb2ludGVyIHdpdGggcmVmY291bnQKaW5j cmVtZW50ZWQgdGh1cyBpdCBtdXN0IGJlIGV4cGxpY2l0bHkgZGVjcmVtZW50ZWQgYWZ0ZXIgdGhl IGxhc3QKdXNhZ2UuCgppcnFfZG9tYWluX2FkZF9saW5lYXIoKSBhbHNvIGNhbGxzIG9mX25vZGVf Z2V0KCkgdG8gaW5jcmVhc2UgcmVmY291bnQsCnNvIGlycV9kb21haW4gd2lsbCBub3QgYmUgYWZm ZWN0ZWQgd2hlbiBpdCBpcyByZWxlYXNlZC4KCkRldGVjdGVkIGJ5IGNvY2NpbmVsbGUgd2l0aCB0 aGUgZm9sbG93aW5nIHdhcm5pbmdzOgogIC4vZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFy ZHZhcmsuYzo4MjY6MS03OiBFUlJPUjogbWlzc2luZyBvZl9ub2RlX3B1dDsgYWNxdWlyZWQgYSBu b2RlIHBvaW50ZXIgd2l0aCByZWZjb3VudCBpbmNyZW1lbnRlZCBvbiBsaW5lIDc5OCwgYnV0IHdp dGhvdXQgYSBjb3JyZXNwb25kaW5nIG9iamVjdCByZWxlYXNlIHdpdGhpbiB0aGlzIGZ1bmN0aW9u LgoKU2lnbmVkLW9mZi1ieTogV2VuIFlhbmcgPHdlbi55YW5nOTlAenRlLmNvbS5jbj4KU2lnbmVk LW9mZi1ieTogTG9yZW56byBQaWVyYWxpc2kgPGxvcmVuem8ucGllcmFsaXNpQGFybS5jb20+CkNj OiBUaG9tYXMgUGV0YXp6b25pIDx0aG9tYXMucGV0YXp6b25pQGJvb3RsaW4uY29tPgpDYzogTG9y ZW56byBQaWVyYWxpc2kgPGxvcmVuem8ucGllcmFsaXNpQGFybS5jb20+CkNjOiBCam9ybiBIZWxn YWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgpDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9yZwpD YzogbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCkNjOiBsaW51eC1rZXJuZWxA dmdlci5rZXJuZWwub3JnClNpZ25lZC1vZmYtYnk6IE1hcmVrIEJlaMO6biA8a2FiZWxAa2VybmVs Lm9yZz4KU2lnbmVkLW9mZi1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3Vu ZGF0aW9uLm9yZz4KLS0tCiBkcml2ZXJzL3BjaS9ob3N0L3BjaS1hYXJkdmFyay5jIHwgICAxMyAr KysrKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9u cygtKQoKLS0tIGEvZHJpdmVycy9wY2kvaG9zdC9wY2ktYWFyZHZhcmsuYworKysgYi9kcml2ZXJz L3BjaS9ob3N0L3BjaS1hYXJkdmFyay5jCkBAIC03ODksNiArNzg5LDcgQEAgc3RhdGljIGludCBh ZHZrX3BjaWVfaW5pdF9pcnFfZG9tYWluKHN0cgogCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSA9 IGRldi0+b2Zfbm9kZTsKIAlzdHJ1Y3QgZGV2aWNlX25vZGUgKnBjaWVfaW50Y19ub2RlOwogCXN0 cnVjdCBpcnFfY2hpcCAqaXJxX2NoaXA7CisJaW50IHJldCA9IDA7CiAKIAlyYXdfc3Bpbl9sb2Nr X2luaXQoJnBjaWUtPmlycV9sb2NrKTsKIApAQCAtODAzLDggKzgwNCw4IEBAIHN0YXRpYyBpbnQg YWR2a19wY2llX2luaXRfaXJxX2RvbWFpbihzdHIKIAlpcnFfY2hpcC0+bmFtZSA9IGRldm1fa2Fz cHJpbnRmKGRldiwgR0ZQX0tFUk5FTCwgIiVzLWlycSIsCiAJCQkJCWRldl9uYW1lKGRldikpOwog CWlmICghaXJxX2NoaXAtPm5hbWUpIHsKLQkJb2Zfbm9kZV9wdXQocGNpZV9pbnRjX25vZGUpOwot CQlyZXR1cm4gLUVOT01FTTsKKwkJcmV0ID0gLUVOT01FTTsKKwkJZ290byBvdXRfcHV0X25vZGU7 CiAJfQogCiAJaXJxX2NoaXAtPmlycV9tYXNrID0gYWR2a19wY2llX2lycV9tYXNrOwpAQCAtODE2 LDExICs4MTcsMTMgQEAgc3RhdGljIGludCBhZHZrX3BjaWVfaW5pdF9pcnFfZG9tYWluKHN0cgog CQkJCSAgICAgICZhZHZrX3BjaWVfaXJxX2RvbWFpbl9vcHMsIHBjaWUpOwogCWlmICghcGNpZS0+ aXJxX2RvbWFpbikgewogCQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBnZXQgYSBJTlR4IElSUSBk b21haW5cbiIpOwotCQlvZl9ub2RlX3B1dChwY2llX2ludGNfbm9kZSk7Ci0JCXJldHVybiAtRU5P TUVNOworCQlyZXQgPSAtRU5PTUVNOworCQlnb3RvIG91dF9wdXRfbm9kZTsKIAl9CiAKLQlyZXR1 cm4gMDsKK291dF9wdXRfbm9kZToKKwlvZl9ub2RlX3B1dChwY2llX2ludGNfbm9kZSk7CisJcmV0 dXJuIHJldDsKIH0KIAogc3RhdGljIHZvaWQgYWR2a19wY2llX3JlbW92ZV9pcnFfZG9tYWluKHN0 cnVjdCBhZHZrX3BjaWUgKnBjaWUpCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK