From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D02EC433EF for ; Tue, 7 Dec 2021 10:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NP6jSZqKrIcP/J8n9FZXX73cX5+OzrBivvykh6/iFNQ=; b=K7fhRlP7s0CeiF dZgI3v7SNIJ3qRHCgKr83vWz0hGmEHbPtczPSEb3C6jbGuyN42P4VyfNPnzPyEKsQRGqfcTX/Bt03 Ge5UIESBINe0Gz1BMyCQuK4wm5HBFtH6S1umYQSrSkB2bDa6tmJea2vW7hX7hJQ8ckw2kSAgvLjt/ 0n9xsGzA0Of53/+Ny65P7YlLj0iyRFjJGgcQNqUrHEHsbaBEbdk/gsqIMuOFkxwdg7vbCvC0XH/AF tJy0RTZCm+YwWMPArvM9iY1M4qyx5KzC42DMQ0o+XeG6/4X3uvg5MnRBtmQDcoJuw+17bnqtOPZji g89IlZyREstU5/zKGl9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muY6R-008BO4-94; Tue, 07 Dec 2021 10:53:43 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muY6M-008BJJ-3S for linux-mtd@lists.infradead.org; Tue, 07 Dec 2021 10:53:39 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id F1644FF807; Tue, 7 Dec 2021 10:53:32 +0000 (UTC) Date: Tue, 7 Dec 2021 11:53:32 +0100 From: Miquel Raynal To: Boris Brezillon Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Mark Brown , , Rob Herring , , Thomas Petazzoni , Xiangsheng Hou , Julien Su , Jaime Liao Subject: Re: [PATCH v3 17/22] mtd: spinand: Create direct mapping descriptors for ECC operations Message-ID: <20211207115332.09cab65f@xps13> In-Reply-To: <20211207104627.7bbad94d@collabora.com> References: <20211207093422.166934-1-miquel.raynal@bootlin.com> <20211207093422.166934-18-miquel.raynal@bootlin.com> <20211207104627.7bbad94d@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_025338_322006_E33232C5 X-CRM114-Status: GOOD ( 20.50 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQm9yaXMsCgpib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbSB3cm90ZSBvbiBUdWUsIDcg RGVjIDIwMjEgMTA6NDY6MjcgKzAxMDA6Cgo+IE9uIFR1ZSwgIDcgRGVjIDIwMjEgMTA6MzQ6MTcg KzAxMDAKPiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZToK PiAKPiA+ICAvKioKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3NwaS9zcGktbWVtLmgg Yi9pbmNsdWRlL2xpbnV4L3NwaS9zcGktbWVtLmgKPiA+IGluZGV4IDg1ZTJmZjdiODQwZC4uM2Jl NTk0YmUyNGMwIDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9zcGkvc3BpLW1lbS5oCj4g PiArKysgYi9pbmNsdWRlL2xpbnV4L3NwaS9zcGktbWVtLmgKPiA+IEBAIC05NCw2ICs5NCw3IEBA IGVudW0gc3BpX21lbV9kYXRhX2RpciB7Cj4gPiAgICoJCSBvcGVyYXRpb24gZG9lcyBub3QgaW52 b2x2ZSB0cmFuc2ZlcnJpbmcgZGF0YQo+ID4gICAqIEBkYXRhLmJ1Zi5pbjogaW5wdXQgYnVmZmVy IChtdXN0IGJlIERNQS1hYmxlKQo+ID4gICAqIEBkYXRhLmJ1Zi5vdXQ6IG91dHB1dCBidWZmZXIg KG11c3QgYmUgRE1BLWFibGUpCj4gPiArICogQGVjY19lbjogZXJyb3IgY29ycmVjdGlvbiBpcyBy ZXF1aXJlZAo+ID4gICAqLwo+ID4gIHN0cnVjdCBzcGlfbWVtX29wIHsKPiA+ICAJc3RydWN0IHsK PiA+IEBAIC0xMjYsNiArMTI3LDggQEAgc3RydWN0IHNwaV9tZW1fb3Agewo+ID4gIAkJCWNvbnN0 IHZvaWQgKm91dDsKPiA+ICAJCX0gYnVmOwo+ID4gIAl9IGRhdGE7Cj4gPiArCj4gPiArCWJvb2wg ZWNjX2VuOwo+ID4gIH07ICAKPiAKPiBJIHJlYWxseSB0aGluayB0aGlzIHNob3VsZCBiZSBpbiBp dCdzIG93biBjb21taXQuCgpPaCBjcmFwLCBJIGZvcmdvdCBhYm91dCB0aGF0LgoKPiBBbmQgeW91 IG5lZWQgdG8gbWFrZQo+IHN1cmUgYWxsIGV4aXN0aW5nIGRyaXZlcnMgcmVqZWN0IG9wZXJhdGlv biB0aGF0IGhhdmUgZWNjX2VuIHNldCB0bwo+IHRydWUgKHRoYXQgc2hvdWxkbid0IGJlIHRvbyBj b21wbGljYXRlZCBzaW5jZSBtb3N0IG9mIHRoZW0gdXNlIGdlbmVyaWMKPiBoZWxwZXJzIHRvIGRv IHRoZSBjaGVjaykuCgpZZXMsIEkgY2FuIGFkZCB0aGlzIGNoZWNrIGFzIHdlbGwuCgpJIHdpbGwg cHJvcG9zZSBhIGZpcnN0IHBhdGNoIGNyZWF0aW5nIGEgc3BpLW1lbSBoZWxwZXIgdG8gZG8gZ2Vu ZXJpYwpjaGVja3MsIGdpdmVuIGEgbnVtYmVyIG9mIGFkZGl0aW9uYWwgcGFyYW1ldGVycyAoZHRy LCBlY2MpLiBUaGUgY3VycmVudApoZWxwZXJzIHdpbGwgY2FsbCB0aGlzIGdlbmVyaWMgZnVuY3Rp b24gZGVwZW5kaW5nIG9uIHdoYXQgdGhleSBjaGVjawooc3VwcG9ydCBmb3IgZHRyIG9yIG5vdCku IFRoZW4gSSB3aWxsIGV4cG9ydCB0aGlzIGdlbmVyaWMgaGVscGVyIGFuZApsZXQgdGhlIGRyaXZl cnMgdXNlIGl0IGRpcmVjdGx5IGlmIG5lZWRlZCwgaW4gb3JkZXIgdG8gYXZvaWQgdGhlCmV4cGxv c2lvbiBvZiBoZWxwZXJzIGluIHRoZSBjb3JlIHRvIGNoZWNrIGFsbCB0aGUgcG9zc2libGUgY29t YmluYXRpb25zLgoKSSdsbCBjZXJ0YWlubHkgcHJvcG9zZSBhIHY0IGp1c3Qgd2l0aCB0aGVzZSBw YXRjaGVzIGFuZCB0aGVuIGFwcGx5IHRoZW0Kd2l0aGluIHRoZSB2MyBpZiBldmVyeW9uZSBhZ3Jl ZXMgd2l0aCB0aGUgcmVzdC4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1h aWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24CAC433F5 for ; Tue, 7 Dec 2021 10:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbhLGK5H convert rfc822-to-8bit (ORCPT ); Tue, 7 Dec 2021 05:57:07 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:54257 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbhLGK5G (ORCPT ); Tue, 7 Dec 2021 05:57:06 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id F1644FF807; Tue, 7 Dec 2021 10:53:32 +0000 (UTC) Date: Tue, 7 Dec 2021 11:53:32 +0100 From: Miquel Raynal To: Boris Brezillon Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Mark Brown , , Rob Herring , , Thomas Petazzoni , Xiangsheng Hou , Julien Su , Jaime Liao Subject: Re: [PATCH v3 17/22] mtd: spinand: Create direct mapping descriptors for ECC operations Message-ID: <20211207115332.09cab65f@xps13> In-Reply-To: <20211207104627.7bbad94d@collabora.com> References: <20211207093422.166934-1-miquel.raynal@bootlin.com> <20211207093422.166934-18-miquel.raynal@bootlin.com> <20211207104627.7bbad94d@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Boris, boris.brezillon@collabora.com wrote on Tue, 7 Dec 2021 10:46:27 +0100: > On Tue, 7 Dec 2021 10:34:17 +0100 > Miquel Raynal wrote: > > > /** > > diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h > > index 85e2ff7b840d..3be594be24c0 100644 > > --- a/include/linux/spi/spi-mem.h > > +++ b/include/linux/spi/spi-mem.h > > @@ -94,6 +94,7 @@ enum spi_mem_data_dir { > > * operation does not involve transferring data > > * @data.buf.in: input buffer (must be DMA-able) > > * @data.buf.out: output buffer (must be DMA-able) > > + * @ecc_en: error correction is required > > */ > > struct spi_mem_op { > > struct { > > @@ -126,6 +127,8 @@ struct spi_mem_op { > > const void *out; > > } buf; > > } data; > > + > > + bool ecc_en; > > }; > > I really think this should be in it's own commit. Oh crap, I forgot about that. > And you need to make > sure all existing drivers reject operation that have ecc_en set to > true (that shouldn't be too complicated since most of them use generic > helpers to do the check). Yes, I can add this check as well. I will propose a first patch creating a spi-mem helper to do generic checks, given a number of additional parameters (dtr, ecc). The current helpers will call this generic function depending on what they check (support for dtr or not). Then I will export this generic helper and let the drivers use it directly if needed, in order to avoid the explosion of helpers in the core to check all the possible combinations. I'll certainly propose a v4 just with these patches and then apply them within the v3 if everyone agrees with the rest. Thanks, Miquèl