From: Christoph Hellwig <hch@lst.de>
To: Hou Tao <houtao1@huawei.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>,
jiangtao62@huawei.com
Subject: Re: [PATCH] nvme-multipath: zeroing ana_log_size as well after free ana_log_buf
Date: Tue, 7 Dec 2021 18:18:29 +0100 [thread overview]
Message-ID: <20211207171829.GA2923@lst.de> (raw)
In-Reply-To: <16960197-643f-1e3b-65d4-913cee871cf2@huawei.com>
On Mon, Dec 06, 2021 at 05:43:10PM +0800, Hou Tao wrote:
> Hi,
>
> On 12/6/2021 3:53 PM, Christoph Hellwig wrote:
> >> if (ana_log_size > ctrl->ana_log_size) {
> >> nvme_mpath_stop(ctrl);
> >> - kfree(ctrl->ana_log_buf);
> >> + nvme_mpath_uninit(ctrl);
> > This hunk looks unrelated.
> It will be related if the value of ana_log_size is reduced again, so you mean
> the reduction is impossible ?
Ok, I see the intent now and will apply it with an updated changelog
to make that more clear.
prev parent reply other threads:[~2021-12-07 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 11:47 [PATCH] nvme-multipath: zeroing ana_log_size as well after free ana_log_buf Hou Tao
2021-12-03 15:01 ` Keith Busch
2021-12-06 7:53 ` Christoph Hellwig
2021-12-06 9:43 ` Hou Tao
2021-12-07 17:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207171829.GA2923@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=houtao1@huawei.com \
--cc=jiangtao62@huawei.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.