From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56BD4C433F5 for ; Tue, 7 Dec 2021 20:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236442AbhLGUHX (ORCPT ); Tue, 7 Dec 2021 15:07:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236087AbhLGUHX (ORCPT ); Tue, 7 Dec 2021 15:07:23 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0270CC061574; Tue, 7 Dec 2021 12:03:53 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id u80so376786pfc.9; Tue, 07 Dec 2021 12:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6EkS8Nvrc0mLwPSTwo7vPbxig6A1y6814RHQt01NTVI=; b=AsljNNwj8qOWOVE9bmXhbXKiE4Esi4ccz46SPr/aK5d7tMGE6rDcC4aKxX/q7MdIAR 6eqc5s0Usx+36Nl9Cr0WGDSMqUIP5YS0o99r5FWTOCZYtjiJ2BTQh06CUWxc3zUgjDv4 4/MyXIJm3jrZI8JBT7iPhzxh+TmfeS39lhLcyCCVIqB24rGA/XV1hwMCT1zp1FLkQL8w nMLripi8OnnUNFuRqWYwX1U7uYNYW5PNCEuWjUe7zToBLcU73oHJSrQ0/W7Qo6EcASf1 y/doPuhW7FDx3CKSmm7AzlyJ2BuZOS1kGyvumFIr/5psmfHxya/4oyYw5qnz1mIRnD9s wadw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6EkS8Nvrc0mLwPSTwo7vPbxig6A1y6814RHQt01NTVI=; b=F0k7mzYQK1F++GQ1pnjOrUDepD4b448KkOOCHjR9d0w7RrgYchgNXiLMiIzTCYfj6r m8gEFrrrQdpKTJNPkOdkKaLcyLDYVFkU+UdVwirMBAg8r7QCDcFEz2VsRh9k1nP2kF75 EPCn5N3KAbQQuRZkuhaZ+TJjlFqHKEIDfDQwOlk8s9QSGCSjVepUA/lbIDglZK2KKrc+ KYfEzEXFC0NnmhBcBuqDDhHX0w/oqcJw0orOKsHtbwq4SvgXSEoUa8r2IQthj2mO78fx y12LUr8P/42bSqDmFd1IW2MaIDj/1Sui2/4we6WtSMo2mSS1g2BxOIw0aCU0N8vpUIOv VXAA== X-Gm-Message-State: AOAM531DSptMr8EtY0q+7pxiVlK/8KlaofOmv9sGBmy6XEPLZoBxX3ew KFH+6xe3o7TWDoJRqOERoQy2JCsysmo= X-Google-Smtp-Source: ABdhPJyDZzLVyupTsP3jSm1uQ1TVGy9Yo7iWxipVefr/je0F5T82/yBDGk6mtlZOAUTLteBzHa6PTw== X-Received: by 2002:a62:1909:0:b0:4a7:e88c:286b with SMTP id 9-20020a621909000000b004a7e88c286bmr1270023pfz.26.1638907431667; Tue, 07 Dec 2021 12:03:51 -0800 (PST) Received: from localhost (c-73-25-156-94.hsd1.or.comcast.net. [73.25.156.94]) by smtp.gmail.com with ESMTPSA id d20sm563648pfl.88.2021.12.07.12.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 12:03:50 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, Maxime Ripard , Douglas Anderson , Stephen Boyd , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Sam Ravnborg , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host Date: Tue, 7 Dec 2021 12:09:06 -0800 Message-Id: <20211207200906.609673-1-robdclark@gmail.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Rob Clark Otherwise we don't get another shot at it if the bridge probes before the dsi host is registered. It seems like this is what *most* (but not all) of the other bridges do. It looks like this was missed in the conversion to attach dsi host at probe time. Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI device at probe") Signed-off-by: Rob Clark --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 02b490671f8f..3684e12fbac3 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -716,7 +716,7 @@ static int ti_sn_attach_host(struct ti_sn65dsi86 *pdata) host = of_find_mipi_dsi_host_by_node(pdata->host_node); if (!host) { DRM_ERROR("failed to find dsi host\n"); - return -ENODEV; + return -EPROBE_DEFER; } dsi = devm_mipi_dsi_device_register_full(dev, host, &info); -- 2.33.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD007C433EF for ; Tue, 7 Dec 2021 20:03:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2F2D6EEA8; Tue, 7 Dec 2021 20:03:54 +0000 (UTC) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA6F76EEA8 for ; Tue, 7 Dec 2021 20:03:53 +0000 (UTC) Received: by mail-pg1-x532.google.com with SMTP id k4so51680pgb.8 for ; Tue, 07 Dec 2021 12:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6EkS8Nvrc0mLwPSTwo7vPbxig6A1y6814RHQt01NTVI=; b=AsljNNwj8qOWOVE9bmXhbXKiE4Esi4ccz46SPr/aK5d7tMGE6rDcC4aKxX/q7MdIAR 6eqc5s0Usx+36Nl9Cr0WGDSMqUIP5YS0o99r5FWTOCZYtjiJ2BTQh06CUWxc3zUgjDv4 4/MyXIJm3jrZI8JBT7iPhzxh+TmfeS39lhLcyCCVIqB24rGA/XV1hwMCT1zp1FLkQL8w nMLripi8OnnUNFuRqWYwX1U7uYNYW5PNCEuWjUe7zToBLcU73oHJSrQ0/W7Qo6EcASf1 y/doPuhW7FDx3CKSmm7AzlyJ2BuZOS1kGyvumFIr/5psmfHxya/4oyYw5qnz1mIRnD9s wadw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6EkS8Nvrc0mLwPSTwo7vPbxig6A1y6814RHQt01NTVI=; b=YafCUSJ/srkpGBPsxFww4uBPgUWb07Q3byI/iltwb9ZJvC+j5MeIFs0IW2PX5NVruk yW8BkxXD7BZcoNDfRIY6u4wa7Vst5ei+benSFKyF+pA1IN7fRQ9/GZIC2zZQA1Y6tMTg lEoUL8sAFqX73Hzy2CNb3rTtbkRVSihawInAxOBdky8D5VKSIBmUyZbv8HR7oDXNvvAt amLOsOrk71G/4XfE1lBk/fEydFz8BdwYkoUzJCUDCY3LdRIgh2eQySHSzc4FJEHVq4w1 Nwy61JLGwt5KUfby2HTHt7SAHxm2TqGZftIXcXr/3L2YVfuCu2YGyLXzwVTSbRxC+eew ZUnA== X-Gm-Message-State: AOAM530BHDRcIHEFThidCpCFuptH2GpFrEDImeZoad6gbGdoB5TyWGX0 0+SEVC1HNXgAtO8KU7OuL/qDB1q9TMY= X-Google-Smtp-Source: ABdhPJyDZzLVyupTsP3jSm1uQ1TVGy9Yo7iWxipVefr/je0F5T82/yBDGk6mtlZOAUTLteBzHa6PTw== X-Received: by 2002:a62:1909:0:b0:4a7:e88c:286b with SMTP id 9-20020a621909000000b004a7e88c286bmr1270023pfz.26.1638907431667; Tue, 07 Dec 2021 12:03:51 -0800 (PST) Received: from localhost (c-73-25-156-94.hsd1.or.comcast.net. [73.25.156.94]) by smtp.gmail.com with ESMTPSA id d20sm563648pfl.88.2021.12.07.12.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 12:03:50 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host Date: Tue, 7 Dec 2021 12:09:06 -0800 Message-Id: <20211207200906.609673-1-robdclark@gmail.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Jernej Skrabec , Neil Armstrong , David Airlie , linux-arm-msm@vger.kernel.org, Jonas Karlman , Douglas Anderson , Robert Foss , Stephen Boyd , Andrzej Hajda , Maxime Ripard , Sam Ravnborg , open list , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Rob Clark Otherwise we don't get another shot at it if the bridge probes before the dsi host is registered. It seems like this is what *most* (but not all) of the other bridges do. It looks like this was missed in the conversion to attach dsi host at probe time. Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI device at probe") Signed-off-by: Rob Clark --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 02b490671f8f..3684e12fbac3 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -716,7 +716,7 @@ static int ti_sn_attach_host(struct ti_sn65dsi86 *pdata) host = of_find_mipi_dsi_host_by_node(pdata->host_node); if (!host) { DRM_ERROR("failed to find dsi host\n"); - return -ENODEV; + return -EPROBE_DEFER; } dsi = devm_mipi_dsi_device_register_full(dev, host, &info); -- 2.33.1