From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] intel_th: remove redundant re-assignment of pointer hubdrv
Date: Wed, 8 Dec 2021 13:02:29 +0300 [thread overview]
Message-ID: <20211208100229.GI1956@kadam> (raw)
In-Reply-To: <20211207230709.121444-1-colin.i.king@gmail.com>
On Tue, Dec 07, 2021 at 11:07:09PM +0000, Colin Ian King wrote:
> The pointer hubdrv is being re-assigned the same value as it was
> initialized with only a few lines earlier. The re-assignment is
> redundant and can be removed.
>
> As Dan Carpenter pointed out, the pointer hubdrv is hub - some_offset
> and in this case some_offset is zero. Since hub has already been
> dereferenced hubdrv can't be NULL so the NULL check is redundant
> and can also be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> ---
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2021-12-08 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 23:07 [PATCH][V2] intel_th: remove redundant re-assignment of pointer hubdrv Colin Ian King
2021-12-08 10:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208100229.GI1956@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.