All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
	netfilter-devel@vger.kernel.org, Eric Garver <eric@garver.life>,
	Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH nf] netfilter: nat: force port remap to prevent shadowing well-known ports
Date: Wed, 8 Dec 2021 11:47:27 +0100	[thread overview]
Message-ID: <20211208104727.GD30918@breakpoint.cc> (raw)
In-Reply-To: <Ya/8HfhxpspXzE01@salvia>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > We could avoid the rewrite for connections that are not being forwarded,
> > but get_unique_tuple() and the callers don't propagate the required hook
> > information for this.
> 
> Probably you can scratch a bit to store in the struct nf_conn object
> if this is locally generated flows?

Yes, that's doable.

      reply	other threads:[~2021-12-08 10:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 14:42 [PATCH nf] netfilter: nat: force port remap to prevent shadowing well-known ports Florian Westphal
2021-11-29 20:22 ` Eric Garver
2021-11-29 22:02   ` Florian Westphal
2021-11-30 14:34     ` Eric Garver
2021-12-08  0:28 ` Pablo Neira Ayuso
2021-12-08 10:47   ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211208104727.GD30918@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=eric@garver.life \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.