From: Florian Westphal <fw@strlen.de>
To: David Ahern <dsahern@gmail.com>
Cc: Andrea Mayer <andrea.mayer@uniroma2.it>,
Andrea Righi <andrea.righi@canonical.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ahmed Abdelsalam <ahabdels@gmail.com>,
Paolo Lungaroni <paolo.lungaroni@uniroma2.it>,
Stefano Salsano <stefano.salsano@uniroma2.it>
Subject: Re: [PATCH] ipv6: fix NULL pointer dereference in ip6_output()
Date: Wed, 8 Dec 2021 11:51:13 +0100 [thread overview]
Message-ID: <20211208105113.GE30918@breakpoint.cc> (raw)
In-Reply-To: <a20d6c2f-f64f-b432-f214-c1f2b64fdf81@gmail.com>
David Ahern <dsahern@gmail.com> wrote:
> On 12/7/21 5:21 PM, Andrea Mayer wrote:
> > + IP6CB(skb)->iif = skb->skb_iif;
> > [...]
> >
> > What do you think?
> >
>
> I like that approach over the need for a fall back in core ipv6 code.
What if the device is removed after ->iif assignment and before dev lookup?
next prev parent reply other threads:[~2021-12-08 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 16:34 [PATCH] ipv6: fix NULL pointer dereference in ip6_output() Andrea Righi
2021-12-07 15:51 ` David Ahern
2021-12-08 0:21 ` Andrea Mayer
2021-12-08 0:50 ` David Ahern
2021-12-08 10:51 ` Florian Westphal [this message]
2021-12-08 15:46 ` David Ahern
2021-12-08 16:34 ` Stephen Suryaputra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208105113.GE30918@breakpoint.cc \
--to=fw@strlen.de \
--cc=ahabdels@gmail.com \
--cc=andrea.mayer@uniroma2.it \
--cc=andrea.righi@canonical.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.lungaroni@uniroma2.it \
--cc=stefano.salsano@uniroma2.it \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.