From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0708231397548921801==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 11/18] tcp: ipv4: Add AO signing for skb-less replies Date: Thu, 09 Dec 2021 07:37:45 +0800 Message-ID: <202112090745.LdVOpiG4-lkp@intel.com> In-Reply-To: List-Id: --===============0708231397548921801== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Leonard, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 1fe5b01262844be03de98afdd56d1d393df04d7e] url: https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initia= l-support-for-RFC5925-auth-option/20211208-194125 base: 1fe5b01262844be03de98afdd56d1d393df04d7e config: openrisc-randconfig-r014-20211208 (https://download.01.org/0day-ci/= archive/20211209/202112090745.LdVOpiG4-lkp(a)intel.com/config) compiler: or1k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/8d4bf3a9b770cb44bf4e37e79= 4e63f7db7a08cb6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leonard-Crestez/tcp-Initial-suppor= t-for-RFC5925-auth-option/20211208-194125 git checkout 8d4bf3a9b770cb44bf4e37e794e63f7db7a08cb6 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dopenrisc SHELL=3D/bin/bash net/ipv4/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): net/ipv4/tcp_ipv4.c: In function 'tcp_v4_send_ack': >> net/ipv4/tcp_ipv4.c:909:52: warning: parameter 'key' set but not used [-= Wunused-but-set-parameter] 909 | struct tcp_md5sig_key *key, | ~~~~~~~~~~~~~~~~~~~~~~~^~~ vim +/key +909 net/ipv4/tcp_ipv4.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 901 = ^1da177e4c3f41 Linus Torvalds 2005-04-16 902 /* The code follow= ing below sending ACKs in SYN-RECV and TIME-WAIT states ^1da177e4c3f41 Linus Torvalds 2005-04-16 903 outside socket = context is ugly, certainly. What can I do? ^1da177e4c3f41 Linus Torvalds 2005-04-16 904 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 905 = e2d118a1cb5e60 Lorenzo Colitti 2016-11-04 906 static void tcp_v4= _send_ack(const struct sock *sk, e62a123b8ef7c5 Eric Dumazet 2016-01-21 907 struct sk_b= uff *skb, u32 seq, u32 ack, ee684b6f283004 Andrey Vagin 2013-02-11 908 u32 win, u3= 2 tsval, u32 tsecr, int oif, 88ef4a5a78e634 KOVACS Krisztian 2008-10-01 @909 struct tcp_= md5sig_key *key, 66b13d99d96a1a Eric Dumazet 2011-10-24 910 int reply_f= lags, u8 tos) ^1da177e4c3f41 Linus Torvalds 2005-04-16 911 { cf533ea53ebfae Eric Dumazet 2011-10-21 912 const struct tcph= dr *th =3D tcp_hdr(skb); ^1da177e4c3f41 Linus Torvalds 2005-04-16 913 struct { ^1da177e4c3f41 Linus Torvalds 2005-04-16 914 struct tcphdr th; 714e85be355722 Al Viro 2006-11-14 915 __be32 opt[(TCPO= LEN_TSTAMP_ALIGNED >> 2) cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 916 #ifdef CONFIG_TCP_= MD5SIG cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 917 + (TCPOLEN_M= D5SIG_ALIGNED >> 2) 8d4bf3a9b770cb Leonard Crestez 2021-12-08 918 #elif defined(CONF= IG_TCP_AUTHOPT) 8d4bf3a9b770cb Leonard Crestez 2021-12-08 919 + (TCPOLEN_A= UTHOPT_OUTPUT >> 2) cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 920 #endif cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 921 ]; ^1da177e4c3f41 Linus Torvalds 2005-04-16 922 } rep; e2d118a1cb5e60 Lorenzo Colitti 2016-11-04 923 struct net *net = =3D sock_net(sk); ^1da177e4c3f41 Linus Torvalds 2005-04-16 924 struct ip_reply_a= rg arg; 00483690552c5f Jon Maxwell 2018-05-10 925 struct sock *ctl_= sk; d6fb396cfaa71a Eric Dumazet 2019-06-13 926 u64 transmit_time; ^1da177e4c3f41 Linus Torvalds 2005-04-16 927 = ^1da177e4c3f41 Linus Torvalds 2005-04-16 928 memset(&rep.th, 0= , sizeof(struct tcphdr)); 7174259e6ced15 Arnaldo Carvalho de Melo 2006-11-17 929 memset(&arg, 0, s= izeof(arg)); ^1da177e4c3f41 Linus Torvalds 2005-04-16 930 = ^1da177e4c3f41 Linus Torvalds 2005-04-16 931 arg.iov[0].iov_ba= se =3D (unsigned char *)&rep; ^1da177e4c3f41 Linus Torvalds 2005-04-16 932 arg.iov[0].iov_le= n =3D sizeof(rep.th); ee684b6f283004 Andrey Vagin 2013-02-11 933 if (tsecr) { cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 934 rep.opt[0] =3D h= tonl((TCPOPT_NOP << 24) | (TCPOPT_NOP << 16) | ^1da177e4c3f41 Linus Torvalds 2005-04-16 935 (TCPOPT_TIM= ESTAMP << 8) | ^1da177e4c3f41 Linus Torvalds 2005-04-16 936 TCPOLEN_TIM= ESTAMP); ee684b6f283004 Andrey Vagin 2013-02-11 937 rep.opt[1] =3D h= tonl(tsval); ee684b6f283004 Andrey Vagin 2013-02-11 938 rep.opt[2] =3D h= tonl(tsecr); cb48cfe8079ddd Craig Schlenter 2007-01-09 939 arg.iov[0].iov_l= en +=3D TCPOLEN_TSTAMP_ALIGNED; ^1da177e4c3f41 Linus Torvalds 2005-04-16 940 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 941 = ^1da177e4c3f41 Linus Torvalds 2005-04-16 942 /* Swap the send = and the receive. */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 943 rep.th.dest = =3D th->source; ^1da177e4c3f41 Linus Torvalds 2005-04-16 944 rep.th.source = =3D th->dest; ^1da177e4c3f41 Linus Torvalds 2005-04-16 945 rep.th.doff = =3D arg.iov[0].iov_len / 4; ^1da177e4c3f41 Linus Torvalds 2005-04-16 946 rep.th.seq = =3D htonl(seq); ^1da177e4c3f41 Linus Torvalds 2005-04-16 947 rep.th.ack_seq = =3D htonl(ack); ^1da177e4c3f41 Linus Torvalds 2005-04-16 948 rep.th.ack = =3D 1; ^1da177e4c3f41 Linus Torvalds 2005-04-16 949 rep.th.window = =3D htons(win); ^1da177e4c3f41 Linus Torvalds 2005-04-16 950 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============0708231397548921801==--