From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B19FC433EF for ; Thu, 9 Dec 2021 17:50:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 37CF2421F0; Thu, 9 Dec 2021 17:50:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KZxa7d5FduOf; Thu, 9 Dec 2021 17:50:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5F3C54011C; Thu, 9 Dec 2021 17:50:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 399E6C001E; Thu, 9 Dec 2021 17:50:31 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 26A68C0012 for ; Thu, 9 Dec 2021 17:50:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 14DE561B10 for ; Thu, 9 Dec 2021 17:50:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RHrzgBoFnkLe for ; Thu, 9 Dec 2021 17:50:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 21D4B60A76 for ; Thu, 9 Dec 2021 17:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639072228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cReUUZLQNrboD+IZcjBNbt6Kq531IoiXK2tkShuHR78=; b=D/blPJdY9HpuoKmm3h+4cnbmf9200EL8WviSC/eF9JDt9qCFbFLKf7XOkE4UEUnl4ujeh2 sG1uwfeGC2qCEtWddCO9hmMIotI9i2vyQuaur1JgHF9VdvnZcRUXEESMrtGEln8iQWN1BW JcFEVycKvhDrYEhGCwYgbkcHYJYZT34= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-255-nWziQelfOUO_MaU1stUsfA-1; Thu, 09 Dec 2021 12:50:26 -0500 X-MC-Unique: nWziQelfOUO_MaU1stUsfA-1 Received: by mail-wm1-f72.google.com with SMTP id m14-20020a05600c3b0e00b0033308dcc933so2760924wms.7 for ; Thu, 09 Dec 2021 09:50:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cReUUZLQNrboD+IZcjBNbt6Kq531IoiXK2tkShuHR78=; b=yQftktY2e2jIzuY4V3a2uqyCh462XU9q1BpvQ0ngKTUyIfM0EIZc3enr4SYmJ/f309 C1MkEvPmRiMJUt2RYwcAJpY34Om8FGDPhRD0KqMondLay6Xw7FVLHXDUFhcXVdRdwR8z wqFEQ2uau6h9LQkbM+GQz7ucwHZ1F6cTeXme0mDoZTtcXLmjocFzm/+0X+VWCXpBYqaW N/tjvan5hHQfeQwhFiawFrA4PX8LbDDUGK/UmkXw+cA4EP5Z4NsCn0hCZuCRjrcau6Xm x/2tb/iz2m1W/8DetTXI2UhjnJFMAgK7Nb3linL6GedFBulh90SvP5HNi1Gv6+59nEPW 4CiA== X-Gm-Message-State: AOAM531UU8DSuh4MkVEhBBXOO7zBaj3DUziOmxvZQxVzMN2dliHUATkp uUIrfLsQyDVD2DfvZmNoZSlcAZ5oiQd+DDB6Ydv2Xy1NzhAclQue2vkX6wKZnr3z10gg8IZcsky Diyv9UJou95Juv0FlXPf9MpqrPltnq2qXGcvjzmgiZQ== X-Received: by 2002:a05:600c:282:: with SMTP id 2mr9287658wmk.91.1639072225687; Thu, 09 Dec 2021 09:50:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1Q1ta3quvHK6VV8iOM3qPpFpOU9+4sLknPpYdPHvNEssS7b1tD5wHRrpRQoopsdw+QzPdhA== X-Received: by 2002:a05:600c:282:: with SMTP id 2mr9287632wmk.91.1639072225451; Thu, 09 Dec 2021 09:50:25 -0800 (PST) Received: from redhat.com ([2.55.18.120]) by smtp.gmail.com with ESMTPSA id b6sm9934160wmq.45.2021.12.09.09.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 09:50:24 -0800 (PST) Date: Thu, 9 Dec 2021 12:50:20 -0500 From: "Michael S. Tsirkin" To: =?utf-8?B?546L6LSH?= Subject: Re: [RFC PATCH] virtio: make sure legacy pci device gain 32bit-pfn vq Message-ID: <20211209124542-mutt-send-email-mst@kernel.org> References: <20211207031217-mutt-send-email-mst@kernel.org> <8bbfd029-d969-4632-cb8e-482481d65a2f@linux.alibaba.com> <20211208021947-mutt-send-email-mst@kernel.org> <20211208060115-mutt-send-email-mst@kernel.org> <20211209013833-mutt-send-email-mst@kernel.org> <22c1f3f1-beab-83cb-c7ce-d61a970d0f0e@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <22c1f3f1-beab-83cb-c7ce-d61a970d0f0e@linux.alibaba.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: open list , "open list:VIRTIO CORE AND NET DRIVERS" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVGh1LCBEZWMgMDksIDIwMjEgYXQgMDQ6MjY6NDdQTSArMDgwMCwg546L6LSHIHdyb3RlOgo+ IAo+IAo+IOWcqCAyMDIxLzEyLzkg5LiL5Y2IMjo0MCwgTWljaGFlbCBTLiBUc2lya2luIOWGmemB kzoKPiBbc25pcF0KPiA+ID4gPiA+IEJlc2lkZXMsIEkndmUgY2hlY2tlZCB0aGF0IHBhdGNoIGJ1 dCBpdCBjYW4ndCBhZGRyZXNzIG91ciBpc3N1ZSwgd2UgYWN0dWFsbHkKPiA+ID4gPiA+IGhhdmUg dGhpcyBsZWdhY3kgcGNpIGRldmljZSBvbiBhcm0gcGxhdGZvcm0sIGFuZCB0aGUgbWVtb3J5IGxh eW91dCBpcwo+ID4gPiA+ID4gdW5mcmllbmRseSBzaW5jZSBhbGxvY2F0aW9uIHJhcmVseSBwcm92 aWRpbmcgcGFnZS1hZGRyZXNzIGJlbG93IDQ0Yml0LCB3ZQo+ID4gPiA+ID4gdW5kZXJzdGFuZCB0 aGUgdmlydGlvLWlvbW11IGNhc2Ugc2hvdWxkIG5vdCBkbyBmb3JjZSBkbWEsIHdoaWxlIHdlIGRv bid0Cj4gPiA+ID4gPiBoYXZlIHRoYXQgc28gaXQncyBqdXN0IHdvcmtpbmcgZmluZS4KPiA+ID4g PiA+IAo+ID4gPiA+ID4gUmVnYXJkcywKPiA+ID4gPiA+IE1pY2hhZWwgV2FuZwo+ID4gPiA+IAo+ ID4gPiA+IEhtbSB3YWl0IGEgc2VjIGlzIGl0IGEgcGh5c2ljYWwgZGV2aWNlIG9yIGEgaHlwZXJ2 aXNvcj8KPiA+ID4gPiBJZiBhIHBoeXNpY2FsIG9uZSB0aGVuIGRvZXNuJ3QgaXQgbmVlZCBWSVJU SU9fRl9PUkRFUl9QTEFURk9STQo+ID4gPiA+IG9uIEFSTT8KPiA+ID4gCj4gPiA+IFRoZSBQQ0kg ZGV2aWNlIGlzIHZpcnR1YWwsIEkgY2FuJ3Qgc2VlIGhvdyBWSVJUSU9fRl9PUkRFUl9QTEFURk9S TSBoZWxwCj4gPiA+IGFkZHJlc3MgdGhpcyBpc3N1ZSwgbGVnYWN5IHBjaSBjb25maWcgaXMgMzJi aXQgYnV0IGl0J3MgMzYsIHNlZW1zIGxpa2Ugd2lsbAo+ID4gPiBuZXZlciBiZSBpbmNsdWRlZD8K PiA+ID4gCj4gPiA+IFJlZ2FyZHMsCj4gPiA+IE1pY2hhZWwgV2FuZwo+ID4gCj4gPiBPaCwgaWYg dGhlIGRldmljZSBpcyB2aXJ0dWFsIHRoZW4gSSB0aGluayB5b3Ugc2hvdWxkIGp1c3QgdXBkYXRl IGl0IHBsZWFzZS4KPiA+IHZpcnRpbyAwLlggaXMgYXJjaGl0ZWN0dXJhbGx5IGxpbWl0ZWQgdG8g c21hbGwgVk1zLAo+ID4gaWYgeW91ciBoeXBlcnZpc29yIHN1cHBvcnRzIG1vcmUgaXQgc2hvdWxk IGVtdWxhdGUgdmlydGlvIDEuMC4KPiAKPiBJIHNlZSwgbmljZSB0byBjb25maXJtIHRoZSBwcm9w ZXIgYXBwcm9hY2gsIGFsdGhvdWdoIHdlIGRvbid0IGhhdmUgdGhhdAo+IG9wdGlvbiBvbiB0aGUg ZGVzayA6LVAKCkRvbid0IHNlZSB3aHksIGEgc3Ryb25nZXIganVzdGlmaWNhdGlvbiB3aWxsIGJl IG5lZWRlZCBiZWZvcmUgZXZlcnlvbmUKdGFrZXMgb24gdGhlIG1haW50YWluYW5jZSBidXJkZW4g b2YgbWFpbnRhaW5pbmcgaGFja3MgbGlrZSB0aGlzLiAgSWYgd2UKbWFrZSBhbiBleGNlcHRpb24g aGVyZSB0aGlzIG9wZW5zIGZsb29kZ2F0ZXMgZm9yIGV2ZXJ5b25lIHRvbyBsYXp5IHRvCmFkZCB2 aXJ0aW8gMSBzdXBwb3J0IHRvIGluc3RlYWQgcHVzaCBoYWNrcyBhdCB0aGUgbGludXggbGV2ZWwu CgoKPiBTbyBhcyBsb25nIGFzIHdlIGRvbid0IGhhdmUgYW55IGlvbW11IGVuYWJsZWQsIHRoZSBm b3JjZSBkbWEgYXBwcm9hY2ggY291bGQKPiBiZSBzYWZlLCBpcyB0aGlzIGNvcnJlY3Q/Cj4gCj4g UmVnYXJkcywKPiBNaWNoYWVsIFdhbmcKCk5vdCB1bmxlc3MgdGhlcmUncyBhbiBBUEkgYXQgdGhl IERNQSBBUEkgbGV2ZWwgdGhhdCBndWFyYW50ZWVzIERNQQphZGRyZXNzZXMgYXJlIHBoeXNpY2Fs IGFkZHJlc3Nlcy4KCj4gPiAKPiA+IAo+ID4gCj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gCj4g PiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4g PiAtLS0KPiA+ID4gPiA+ID4gPiA+ID4gICAgICBkcml2ZXJzL3ZpcnRpby92aXJ0aW9fcGNpX2xl Z2FjeS5jIHwgMTAgKysrKysrKysrKwo+ID4gPiA+ID4gPiA+ID4gPiAgICAgIGRyaXZlcnMvdmly dGlvL3ZpcnRpb19yaW5nLmMgICAgICAgfCAgMyArKysKPiA+ID4gPiA+ID4gPiA+ID4gICAgICBp bmNsdWRlL2xpbnV4L3ZpcnRpby5oICAgICAgICAgICAgIHwgIDEgKwo+ID4gPiA+ID4gPiA+ID4g PiAgICAgIDMgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKQo+ID4gPiA+ID4gPiA+ID4g PiAKPiA+ID4gPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19w Y2lfbGVnYWN5LmMKPiA+ID4gPiA+ID4gPiA+ID4gYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fcGNp X2xlZ2FjeS5jCj4gPiA+ID4gPiA+ID4gPiA+IGluZGV4IGQ2MmU5ODMuLjExZjJlYmYgMTAwNjQ0 Cj4gPiA+ID4gPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19wY2lfbGVnYWN5 LmMKPiA+ID4gPiA+ID4gPiA+ID4gKysrIGIvZHJpdmVycy92aXJ0aW8vdmlydGlvX3BjaV9sZWdh Y3kuYwo+ID4gPiA+ID4gPiA+ID4gPiBAQCAtMjYzLDYgKzI2MywxNiBAQCBpbnQgdmlydGlvX3Bj aV9sZWdhY3lfcHJvYmUoc3RydWN0IHZpcnRpb19wY2lfZGV2aWNlCj4gPiA+ID4gPiA+ID4gPiA+ ICp2cF9kZXYpCj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgCXZwX2Rldi0+c2V0dXBfdnEgPSBzZXR1 cF92cTsKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAJdnBfZGV2LT5kZWxfdnEgPSBkZWxfdnE7Cj4g PiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gPiArCS8qCj4gPiA+ID4gPiA+ID4gPiA+ ICsJICogVGhlIGxlZ2FjeSBwY2kgZGV2aWNlIHJlcXVyZSAzMmJpdC1wZm4gdnEsCj4gPiA+ID4g PiA+ID4gPiA+ICsJICogb3Igc2V0dXBfdnEoKSB3aWxsIGZhaWxlZC4KPiA+ID4gPiA+ID4gPiA+ ID4gKwkgKgo+ID4gPiA+ID4gPiA+ID4gPiArCSAqIFRodXMgd2UgbWFrZSBzdXJlIHZyaW5nX3Vz ZV9kbWFfYXBpKCkgd2lsbAo+ID4gPiA+ID4gPiA+ID4gPiArCSAqIHJldHVybiB0cnVlIGR1cmlu ZyB0aGUgYWxsb2NhdGlvbiBieSBtYXJraW5nCj4gPiA+ID4gPiA+ID4gPiA+ICsJICogZm9yY2Vf ZG1hIGhlcmUuCj4gPiA+ID4gPiA+ID4gPiA+ICsJICovCj4gPiA+ID4gPiA+ID4gPiA+ICsJdnBf ZGV2LT52ZGV2LmZvcmNlX2RtYSA9IHRydWU7Cj4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ ID4gPiA+ID4gICAgICAJcmV0dXJuIDA7Cj4gPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ ID4gPiAgICAgIGVycl9pb21hcDoKPiA+ID4gPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdmlydGlvL3ZpcnRpb19yaW5nLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5jCj4g PiA+ID4gPiA+ID4gPiA+IGluZGV4IDMwMzViYjYuLjY1NjJlMDEgMTAwNjQ0Cj4gPiA+ID4gPiA+ ID4gPiA+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+ID4gPiA+ID4gPiA+ ID4gKysrIGIvZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+ID4gPiA+ID4gPiA+ID4gPiBA QCAtMjQ1LDYgKzI0NSw5IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCB2aXJ0cXVldWVfdXNlX2luZGly ZWN0KHN0cnVjdAo+ID4gPiA+ID4gPiA+ID4gPiB2aXJ0cXVldWUgKl92cSwKPiA+ID4gPiA+ID4g PiA+ID4gCj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgc3RhdGljIGJvb2wgdnJpbmdfdXNlX2RtYV9h cGkoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYpCj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgewo+ ID4gPiA+ID4gPiA+ID4gPiArCWlmICh2ZGV2LT5mb3JjZV9kbWEpCj4gPiA+ID4gPiA+ID4gPiA+ ICsJCXJldHVybiB0cnVlOwo+ID4gPiA+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ID4gPiA+ICAg ICAgCWlmICghdmlydGlvX2hhc19kbWFfcXVpcmsodmRldikpCj4gPiA+ID4gPiA+ID4gPiA+ICAg ICAgCQlyZXR1cm4gdHJ1ZTsKPiA+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiA+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3ZpcnRpby5oIGIvaW5jbHVkZS9saW51eC92aXJ0aW8u aAo+ID4gPiA+ID4gPiA+ID4gPiBpbmRleCA0MWVkYmMwLi5hNGViMjlkIDEwMDY0NAo+ID4gPiA+ ID4gPiA+ID4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3ZpcnRpby5oCj4gPiA+ID4gPiA+ID4gPiA+ ICsrKyBiL2luY2x1ZGUvbGludXgvdmlydGlvLmgKPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTEwOSw2 ICsxMDksNyBAQCBzdHJ1Y3QgdmlydGlvX2RldmljZSB7Cj4gPiA+ID4gPiA+ID4gPiA+ICAgICAg CWJvb2wgZmFpbGVkOwo+ID4gPiA+ID4gPiA+ID4gPiAgICAgIAlib29sIGNvbmZpZ19lbmFibGVk Owo+ID4gPiA+ID4gPiA+ID4gPiAgICAgIAlib29sIGNvbmZpZ19jaGFuZ2VfcGVuZGluZzsKPiA+ ID4gPiA+ID4gPiA+ID4gKwlib29sIGZvcmNlX2RtYTsKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAJ c3BpbmxvY2tfdCBjb25maWdfbG9jazsKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAJc3BpbmxvY2tf dCB2cXNfbGlzdF9sb2NrOyAvKiBQcm90ZWN0cyBWUXMgbGlzdCBhY2Nlc3MgKi8KPiA+ID4gPiA+ ID4gPiA+ID4gICAgICAJc3RydWN0IGRldmljZSBkZXY7Cj4gPiA+ID4gPiA+ID4gPiA+IC0tIAo+ ID4gPiA+ID4gPiA+ID4gPiAxLjguMy4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRp b25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRp b24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540D7C433F5 for ; Thu, 9 Dec 2021 17:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241735AbhLIRyD (ORCPT ); Thu, 9 Dec 2021 12:54:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44233 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234197AbhLIRyC (ORCPT ); Thu, 9 Dec 2021 12:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639072228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cReUUZLQNrboD+IZcjBNbt6Kq531IoiXK2tkShuHR78=; b=D/blPJdY9HpuoKmm3h+4cnbmf9200EL8WviSC/eF9JDt9qCFbFLKf7XOkE4UEUnl4ujeh2 sG1uwfeGC2qCEtWddCO9hmMIotI9i2vyQuaur1JgHF9VdvnZcRUXEESMrtGEln8iQWN1BW JcFEVycKvhDrYEhGCwYgbkcHYJYZT34= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-120-zvMeGRnUP2yQIj5Umf_u6g-1; Thu, 09 Dec 2021 12:50:26 -0500 X-MC-Unique: zvMeGRnUP2yQIj5Umf_u6g-1 Received: by mail-wm1-f71.google.com with SMTP id ay17-20020a05600c1e1100b0033f27b76819so3493127wmb.4 for ; Thu, 09 Dec 2021 09:50:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cReUUZLQNrboD+IZcjBNbt6Kq531IoiXK2tkShuHR78=; b=Na2BfEch+4BM8ew2WzUvtvohEFpSVcRgXhMe2zgJzUmLWSTl6Ejg7mj8q4bL4RvkD0 KkBUjXRYptVwRYJ/vN5wtSAzcgXBpKY7+Kojb8KDlVnygulxrntehnBeEHE6ZSJoZhi7 Av2AXSlBJL4IA8MV+ThcipmDaLSM//yLgWUZVCfLdrFFx9mJ2pl+hBXvjRFrtPjW82Xn hxSnd9TZ5Bdre39JlZ4s+FZPxxlahc3IpRQHUoSUcK9FI0GhA8PD/wCrgkp/yc7yFbT8 mSejJGWzac5v8n/SfFMccivw2X0p5Ytu7iankVp9G2SJHhAK9h5Wq4bAmLbnwMyDZsVM OA6Q== X-Gm-Message-State: AOAM532rO0g1cIjCtQtiY1/hNHhXEsfblbZtCRzt+KILnYIqvmerYAUY qOfkQ8IJpi9np0K5lVfxMZDKZEzJSebCCz7EuX5dUy/xmEaQH4XJoSoYiQb08h/xvIkFAai8ayW z9lcDCqfBWb/HPKKlnnMzE8nW X-Received: by 2002:a05:600c:282:: with SMTP id 2mr9287659wmk.91.1639072225686; Thu, 09 Dec 2021 09:50:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1Q1ta3quvHK6VV8iOM3qPpFpOU9+4sLknPpYdPHvNEssS7b1tD5wHRrpRQoopsdw+QzPdhA== X-Received: by 2002:a05:600c:282:: with SMTP id 2mr9287632wmk.91.1639072225451; Thu, 09 Dec 2021 09:50:25 -0800 (PST) Received: from redhat.com ([2.55.18.120]) by smtp.gmail.com with ESMTPSA id b6sm9934160wmq.45.2021.12.09.09.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 09:50:24 -0800 (PST) Date: Thu, 9 Dec 2021 12:50:20 -0500 From: "Michael S. Tsirkin" To: =?utf-8?B?546L6LSH?= Cc: Jason Wang , "open list:VIRTIO CORE AND NET DRIVERS" , open list Subject: Re: [RFC PATCH] virtio: make sure legacy pci device gain 32bit-pfn vq Message-ID: <20211209124542-mutt-send-email-mst@kernel.org> References: <20211207031217-mutt-send-email-mst@kernel.org> <8bbfd029-d969-4632-cb8e-482481d65a2f@linux.alibaba.com> <20211208021947-mutt-send-email-mst@kernel.org> <20211208060115-mutt-send-email-mst@kernel.org> <20211209013833-mutt-send-email-mst@kernel.org> <22c1f3f1-beab-83cb-c7ce-d61a970d0f0e@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <22c1f3f1-beab-83cb-c7ce-d61a970d0f0e@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 09, 2021 at 04:26:47PM +0800, 王贇 wrote: > > > 在 2021/12/9 下午2:40, Michael S. Tsirkin 写道: > [snip] > > > > > Besides, I've checked that patch but it can't address our issue, we actually > > > > > have this legacy pci device on arm platform, and the memory layout is > > > > > unfriendly since allocation rarely providing page-address below 44bit, we > > > > > understand the virtio-iommu case should not do force dma, while we don't > > > > > have that so it's just working fine. > > > > > > > > > > Regards, > > > > > Michael Wang > > > > > > > > Hmm wait a sec is it a physical device or a hypervisor? > > > > If a physical one then doesn't it need VIRTIO_F_ORDER_PLATFORM > > > > on ARM? > > > > > > The PCI device is virtual, I can't see how VIRTIO_F_ORDER_PLATFORM help > > > address this issue, legacy pci config is 32bit but it's 36, seems like will > > > never be included? > > > > > > Regards, > > > Michael Wang > > > > Oh, if the device is virtual then I think you should just update it please. > > virtio 0.X is architecturally limited to small VMs, > > if your hypervisor supports more it should emulate virtio 1.0. > > I see, nice to confirm the proper approach, although we don't have that > option on the desk :-P Don't see why, a stronger justification will be needed before everyone takes on the maintainance burden of maintaining hacks like this. If we make an exception here this opens floodgates for everyone too lazy to add virtio 1 support to instead push hacks at the linux level. > So as long as we don't have any iommu enabled, the force dma approach could > be safe, is this correct? > > Regards, > Michael Wang Not unless there's an API at the DMA API level that guarantees DMA addresses are physical addresses. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > drivers/virtio/virtio_pci_legacy.c | 10 ++++++++++ > > > > > > > > > drivers/virtio/virtio_ring.c | 3 +++ > > > > > > > > > include/linux/virtio.h | 1 + > > > > > > > > > 3 files changed, 14 insertions(+) > > > > > > > > > > > > > > > > > > diff --git a/drivers/virtio/virtio_pci_legacy.c > > > > > > > > > b/drivers/virtio/virtio_pci_legacy.c > > > > > > > > > index d62e983..11f2ebf 100644 > > > > > > > > > --- a/drivers/virtio/virtio_pci_legacy.c > > > > > > > > > +++ b/drivers/virtio/virtio_pci_legacy.c > > > > > > > > > @@ -263,6 +263,16 @@ int virtio_pci_legacy_probe(struct virtio_pci_device > > > > > > > > > *vp_dev) > > > > > > > > > vp_dev->setup_vq = setup_vq; > > > > > > > > > vp_dev->del_vq = del_vq; > > > > > > > > > > > > > > > > > > + /* > > > > > > > > > + * The legacy pci device requre 32bit-pfn vq, > > > > > > > > > + * or setup_vq() will failed. > > > > > > > > > + * > > > > > > > > > + * Thus we make sure vring_use_dma_api() will > > > > > > > > > + * return true during the allocation by marking > > > > > > > > > + * force_dma here. > > > > > > > > > + */ > > > > > > > > > + vp_dev->vdev.force_dma = true; > > > > > > > > > + > > > > > > > > > return 0; > > > > > > > > > > > > > > > > > > err_iomap: > > > > > > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > > > > > > > > index 3035bb6..6562e01 100644 > > > > > > > > > --- a/drivers/virtio/virtio_ring.c > > > > > > > > > +++ b/drivers/virtio/virtio_ring.c > > > > > > > > > @@ -245,6 +245,9 @@ static inline bool virtqueue_use_indirect(struct > > > > > > > > > virtqueue *_vq, > > > > > > > > > > > > > > > > > > static bool vring_use_dma_api(struct virtio_device *vdev) > > > > > > > > > { > > > > > > > > > + if (vdev->force_dma) > > > > > > > > > + return true; > > > > > > > > > + > > > > > > > > > if (!virtio_has_dma_quirk(vdev)) > > > > > > > > > return true; > > > > > > > > > > > > > > > > > > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > > > > > > > > > index 41edbc0..a4eb29d 100644 > > > > > > > > > --- a/include/linux/virtio.h > > > > > > > > > +++ b/include/linux/virtio.h > > > > > > > > > @@ -109,6 +109,7 @@ struct virtio_device { > > > > > > > > > bool failed; > > > > > > > > > bool config_enabled; > > > > > > > > > bool config_change_pending; > > > > > > > > > + bool force_dma; > > > > > > > > > spinlock_t config_lock; > > > > > > > > > spinlock_t vqs_list_lock; /* Protects VQs list access */ > > > > > > > > > struct device dev; > > > > > > > > > -- > > > > > > > > > 1.8.3.1