From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62955C433F5 for ; Thu, 9 Dec 2021 23:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233008AbhLIXlT (ORCPT ); Thu, 9 Dec 2021 18:41:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232964AbhLIXlT (ORCPT ); Thu, 9 Dec 2021 18:41:19 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77D88C061746 for ; Thu, 9 Dec 2021 15:37:45 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id b11so5057518pld.12 for ; Thu, 09 Dec 2021 15:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2djF0P4/pIiIN2tn2/N0Kxd449t54dXIhZh8UA9W5m0=; b=AsoDzv/qewrgwQFk+1LG/Q5IZ5JNhPI2jMNNToGHWKcru+V88AmBdb6PebMs2sZ2bh Bm6xB2omaLLkax8Ap731YYd05k4Jf4H8LLLKrMjscvyelECxoaSNmAtCPN/aQITNQd2W o5Iz6GlxcqnCxinVCrDZ3xgmqQvIx08sjij5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2djF0P4/pIiIN2tn2/N0Kxd449t54dXIhZh8UA9W5m0=; b=7t+fvbSSw8rmLjhPa2QsEJ/Q/+yLA14t3KkJJAXQO/JKkZcW2ttGzR8pWgHr/oaF80 0UnFTueF8nNQ3my4wOkVu9rbY5AS+sDxNMesxkgbu3wuzi/0q5gWum1Jirx8V9S1TPRW sx+NtLAtOJs3wxvKyv/AlV5zu1gYOMVn9gI/wdtFPru57xXpttRHx29jbTOgvy4cM+E4 MUVZYBKMBiOf1RMvNtlPZLcLG+7cnLu2NFRlcfbntnb9OvXGJk9ElNP38RCLvrRzxaU4 EXQvYE+KMWVoXWwGyKxKvYA1LYW48cPeMdfIezKf+wPcfQNtpuuT4tkmmYg0x10W/nnA zy8Q== X-Gm-Message-State: AOAM530sTB5d6ZnP+FEf7qtQ50Nm03J08aG9DupNY6njLqaor+c/uySL Q2AEDoSV3WKfN5WsmdRhKIAbUw== X-Google-Smtp-Source: ABdhPJzm9FnroTff4RdxY1rNi5NMwYvwjDB+MJJSwjZNCUJhLA7OKf5Bg/Xd1vkVwPTjlOP0idl9MA== X-Received: by 2002:a17:90a:880a:: with SMTP id s10mr19407803pjn.214.1639093064920; Thu, 09 Dec 2021 15:37:44 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f7sm192558pfj.41.2021.12.09.15.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 15:37:44 -0800 (PST) Date: Thu, 9 Dec 2021 15:37:43 -0800 From: Kees Cook To: Thomas Gleixner Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, x86@kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] x86/boot/string: Add missing function declarations Message-ID: <202112091536.2DDF0DF@keescook> References: <20211119175325.3668419-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211119175325.3668419-1-keescook@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Fri, Nov 19, 2021 at 09:53:25AM -0800, Kees Cook wrote: > Silence "missing function declaration" warnings from string.h when > building under W=1. > > Signed-off-by: Kees Cook > --- Hi, just a quick ping on this little fix. Thanks! -Kees > arch/x86/boot/string.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h > index a232da487cd2..e5d2c6b8c2f1 100644 > --- a/arch/x86/boot/string.h > +++ b/arch/x86/boot/string.h > @@ -8,8 +8,10 @@ > #undef memcmp > > void *memcpy(void *dst, const void *src, size_t len); > +void *memmove(void *dst, const void *src, size_t len); > void *memset(void *dst, int c, size_t len); > int memcmp(const void *s1, const void *s2, size_t len); > +int bcmp(const void *s1, const void *s2, size_t len); > > /* Access builtin version by default. */ > #define memcpy(d,s,l) __builtin_memcpy(d,s,l) > @@ -25,6 +27,7 @@ extern size_t strnlen(const char *s, size_t maxlen); > extern unsigned int atou(const char *s); > extern unsigned long long simple_strtoull(const char *cp, char **endp, > unsigned int base); > +long simple_strtol(const char *cp, char **endp, unsigned int base); > > int kstrtoull(const char *s, unsigned int base, unsigned long long *res); > int boot_kstrtoul(const char *s, unsigned int base, unsigned long *res); > -- > 2.30.2 > -- Kees Cook