From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1096177191688392416==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 13/73] sata_dwc_460ex: use generic tracepoints Date: Thu, 09 Dec 2021 19:57:31 +0800 Message-ID: <202112091923.b2cQMxCn-lkp@intel.com> In-Reply-To: <20211208163255.114660-14-hare@suse.de> List-Id: --===============1096177191688392416== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Hannes, I love your patch! Perhaps something to improve: [auto build test WARNING on rostedt-trace/for-next] [also build test WARNING on axboe-block/for-next linus/master v5.16-rc4 nex= t-20211208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-rew= ork-logging-take-II/20211209-003634 base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace= .git for-next config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/202112= 09/202112091923.b2cQMxCn-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/b3bb5eac4170da8a3e9c477ad= 4c1c8f97164abc5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hannes-Reinecke/libata-rework-logg= ing-take-II/20211209-003634 git checkout b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/at= a/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from drivers/ata/sata_dwc_460ex.c:28: drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_dma_xfer_complete': drivers/ata/sata_dwc_460ex.c:744:5: error: implicit declaration of funct= ion 'get_dma_dir_descript'; did you mean 'get_prot_descript'? [-Werror=3Dim= plicit-function-declaration] 744 | get_dma_dir_descript(qc->dma_dir), | ^~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: in definition of macro 'dev_pri= ntk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ drivers/ata/sata_dwc_460ex.c:741:3: note: in expansion of macro 'dev_inf= o' 741 | dev_info(ap->dev, | ^~~~~~~~ >> drivers/ata/sata_dwc_460ex.c:742:5: warning: format '%s' expects argumen= t of type 'char *', but argument 6 has type 'int' [-Wformat=3D] 742 | "%s tag=3D%u cmd=3D0x%02x dma dir=3D%s proto=3D%s dmacr=3D0x= %08x\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_pri= ntk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ include/linux/dev_printk.h:150:51: note: in expansion of macro 'dev_fmt' 150 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), = ##__VA_ARGS__) | ^~~~~~~ drivers/ata/sata_dwc_460ex.c:741:3: note: in expansion of macro 'dev_inf= o' 741 | dev_info(ap->dev, | ^~~~~~~~ drivers/ata/sata_dwc_460ex.c:742:36: note: format string is defined here 742 | "%s tag=3D%u cmd=3D0x%02x dma dir=3D%s proto=3D%s dmacr=3D0x= %08x\n", | ~^ | | | char * | %d cc1: some warnings being treated as errors vim +742 drivers/ata/sata_dwc_460ex.c 62936009f35a66 Rupjyoti Sarmah 2010-07-06 724 = 62936009f35a66 Rupjyoti Sarmah 2010-07-06 725 static void sata_dwc_dma_xf= er_complete(struct ata_port *ap, u32 check_status) 62936009f35a66 Rupjyoti Sarmah 2010-07-06 726 { 62936009f35a66 Rupjyoti Sarmah 2010-07-06 727 struct ata_queued_cmd *qc; 62936009f35a66 Rupjyoti Sarmah 2010-07-06 728 struct sata_dwc_device_por= t *hsdevp =3D HSDEVP_FROM_AP(ap); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 729 struct sata_dwc_device *hs= dev =3D HSDEV_FROM_AP(ap); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 730 u8 tag =3D 0; 62936009f35a66 Rupjyoti Sarmah 2010-07-06 731 = 62936009f35a66 Rupjyoti Sarmah 2010-07-06 732 tag =3D ap->link.active_ta= g; 62936009f35a66 Rupjyoti Sarmah 2010-07-06 733 qc =3D ata_qc_from_tag(ap,= tag); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 734 if (!qc) { 62936009f35a66 Rupjyoti Sarmah 2010-07-06 735 dev_err(ap->dev, "failed = to get qc"); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 736 return; 62936009f35a66 Rupjyoti Sarmah 2010-07-06 737 } 62936009f35a66 Rupjyoti Sarmah 2010-07-06 738 = 62936009f35a66 Rupjyoti Sarmah 2010-07-06 739 #ifdef DEBUG_NCQ 62936009f35a66 Rupjyoti Sarmah 2010-07-06 740 if (tag > 0) { d578514b271e7c Andy Shevchenko 2015-03-03 741 dev_info(ap->dev, d578514b271e7c Andy Shevchenko 2015-03-03 @742 "%s tag=3D%u cmd=3D0x%0= 2x dma dir=3D%s proto=3D%s dmacr=3D0x%08x\n", 4e5b6260cc9ba8 Jens Axboe 2018-05-11 743 __func__, qc->hw_tag, q= c->tf.command, 84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 @744 get_dma_dir_descript(qc= ->dma_dir), 84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 745 get_prot_descript(qc->t= f.protocol), ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 746 sata_dwc_readl(&hsdev->= sata_dwc_regs->dmacr)); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 747 } 62936009f35a66 Rupjyoti Sarmah 2010-07-06 748 #endif 62936009f35a66 Rupjyoti Sarmah 2010-07-06 749 = 62936009f35a66 Rupjyoti Sarmah 2010-07-06 750 if (ata_is_dma(qc->tf.prot= ocol)) { 62936009f35a66 Rupjyoti Sarmah 2010-07-06 751 if (hsdevp->dma_pending[t= ag] =3D=3D SATA_DWC_DMA_PENDING_NONE) { d578514b271e7c Andy Shevchenko 2015-03-03 752 dev_err(ap->dev, d578514b271e7c Andy Shevchenko 2015-03-03 753 "%s DMA protocol RX and= TX DMA not pending dmacr: 0x%08x\n", d578514b271e7c Andy Shevchenko 2015-03-03 754 __func__, ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 755 sata_dwc_readl(&hsdev->= sata_dwc_regs->dmacr)); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 756 } 62936009f35a66 Rupjyoti Sarmah 2010-07-06 757 = 62936009f35a66 Rupjyoti Sarmah 2010-07-06 758 hsdevp->dma_pending[tag] = =3D SATA_DWC_DMA_PENDING_NONE; 62936009f35a66 Rupjyoti Sarmah 2010-07-06 759 sata_dwc_qc_complete(ap, = qc, check_status); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 760 ap->link.active_tag =3D A= TA_TAG_POISON; 62936009f35a66 Rupjyoti Sarmah 2010-07-06 761 } else { 62936009f35a66 Rupjyoti Sarmah 2010-07-06 762 sata_dwc_qc_complete(ap, = qc, check_status); 62936009f35a66 Rupjyoti Sarmah 2010-07-06 763 } 62936009f35a66 Rupjyoti Sarmah 2010-07-06 764 } 62936009f35a66 Rupjyoti Sarmah 2010-07-06 765 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============1096177191688392416==--