From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/usb/cdns3/cdnsp-pci.c:181 cdnsp_pci_probe() warn: possible memory leak of 'cdnsp'
Date: Thu, 09 Dec 2021 21:50:59 +0800 [thread overview]
Message-ID: <202112092103.65goOmME-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 10341 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Randy Dunlap <rdunlap@infradead.org>
CC: Peter Chen <peter.chen@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2a987e65025e2b79c6d453b78cb5985ac6e5eb26
commit: 28a25ba3e59263a66b2a2cd3e153351b2db2a6b6 usb: cdns3: fix build when PM_SLEEP is not set
date: 12 months ago
:::::: branch date: 2 days ago
:::::: commit date: 12 months ago
config: x86_64-randconfig-m031-20211206 (https://download.01.org/0day-ci/archive/20211209/202112092103.65goOmME-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/usb/cdns3/cdnsp-pci.c:181 cdnsp_pci_probe() warn: possible memory leak of 'cdnsp'
vim +/cdnsp +181 drivers/usb/cdns3/cdnsp-pci.c
3d82904559f4f5 Pawel Laszczak 2020-12-07 57
3d82904559f4f5 Pawel Laszczak 2020-12-07 58 static int cdnsp_pci_probe(struct pci_dev *pdev,
3d82904559f4f5 Pawel Laszczak 2020-12-07 59 const struct pci_device_id *id)
3d82904559f4f5 Pawel Laszczak 2020-12-07 60 {
3d82904559f4f5 Pawel Laszczak 2020-12-07 61 struct device *dev = &pdev->dev;
3d82904559f4f5 Pawel Laszczak 2020-12-07 62 struct pci_dev *func;
3d82904559f4f5 Pawel Laszczak 2020-12-07 63 struct resource *res;
3d82904559f4f5 Pawel Laszczak 2020-12-07 64 struct cdns *cdnsp;
3d82904559f4f5 Pawel Laszczak 2020-12-07 65 int ret;
3d82904559f4f5 Pawel Laszczak 2020-12-07 66
3d82904559f4f5 Pawel Laszczak 2020-12-07 67 /*
3d82904559f4f5 Pawel Laszczak 2020-12-07 68 * For GADGET/HOST PCI (devfn) function number is 0,
3d82904559f4f5 Pawel Laszczak 2020-12-07 69 * for OTG PCI (devfn) function number is 1.
3d82904559f4f5 Pawel Laszczak 2020-12-07 70 */
3d82904559f4f5 Pawel Laszczak 2020-12-07 71 if (!id || (pdev->devfn != PCI_DEV_FN_HOST_DEVICE &&
3d82904559f4f5 Pawel Laszczak 2020-12-07 72 pdev->devfn != PCI_DEV_FN_OTG))
3d82904559f4f5 Pawel Laszczak 2020-12-07 73 return -EINVAL;
3d82904559f4f5 Pawel Laszczak 2020-12-07 74
3d82904559f4f5 Pawel Laszczak 2020-12-07 75 func = cdnsp_get_second_fun(pdev);
3d82904559f4f5 Pawel Laszczak 2020-12-07 76 if (!func)
3d82904559f4f5 Pawel Laszczak 2020-12-07 77 return -EINVAL;
3d82904559f4f5 Pawel Laszczak 2020-12-07 78
3d82904559f4f5 Pawel Laszczak 2020-12-07 79 if (func->class == PCI_CLASS_SERIAL_USB_XHCI ||
3d82904559f4f5 Pawel Laszczak 2020-12-07 80 pdev->class == PCI_CLASS_SERIAL_USB_XHCI) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 81 ret = -EINVAL;
3d82904559f4f5 Pawel Laszczak 2020-12-07 82 goto put_pci;
3d82904559f4f5 Pawel Laszczak 2020-12-07 83 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 84
3d82904559f4f5 Pawel Laszczak 2020-12-07 85 ret = pcim_enable_device(pdev);
3d82904559f4f5 Pawel Laszczak 2020-12-07 86 if (ret) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 87 dev_err(&pdev->dev, "Enabling PCI device has failed %d\n", ret);
3d82904559f4f5 Pawel Laszczak 2020-12-07 88 goto put_pci;
3d82904559f4f5 Pawel Laszczak 2020-12-07 89 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 90
3d82904559f4f5 Pawel Laszczak 2020-12-07 91 pci_set_master(pdev);
3d82904559f4f5 Pawel Laszczak 2020-12-07 92 if (pci_is_enabled(func)) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 93 cdnsp = pci_get_drvdata(func);
3d82904559f4f5 Pawel Laszczak 2020-12-07 94 } else {
3d82904559f4f5 Pawel Laszczak 2020-12-07 95 cdnsp = kzalloc(sizeof(*cdnsp), GFP_KERNEL);
3d82904559f4f5 Pawel Laszczak 2020-12-07 96 if (!cdnsp) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 97 ret = -ENOMEM;
3d82904559f4f5 Pawel Laszczak 2020-12-07 98 goto disable_pci;
3d82904559f4f5 Pawel Laszczak 2020-12-07 99 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 100 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 101
3d82904559f4f5 Pawel Laszczak 2020-12-07 102 /* For GADGET device function number is 0. */
3d82904559f4f5 Pawel Laszczak 2020-12-07 103 if (pdev->devfn == 0) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 104 resource_size_t rsrc_start, rsrc_len;
3d82904559f4f5 Pawel Laszczak 2020-12-07 105
3d82904559f4f5 Pawel Laszczak 2020-12-07 106 /* Function 0: host(BAR_0) + device(BAR_1).*/
3d82904559f4f5 Pawel Laszczak 2020-12-07 107 dev_dbg(dev, "Initialize resources\n");
3d82904559f4f5 Pawel Laszczak 2020-12-07 108 rsrc_start = pci_resource_start(pdev, PCI_BAR_DEV);
3d82904559f4f5 Pawel Laszczak 2020-12-07 109 rsrc_len = pci_resource_len(pdev, PCI_BAR_DEV);
3d82904559f4f5 Pawel Laszczak 2020-12-07 110 res = devm_request_mem_region(dev, rsrc_start, rsrc_len, "dev");
3d82904559f4f5 Pawel Laszczak 2020-12-07 111 if (!res) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 112 dev_dbg(dev, "controller already in use\n");
3d82904559f4f5 Pawel Laszczak 2020-12-07 113 ret = -EBUSY;
3d82904559f4f5 Pawel Laszczak 2020-12-07 114 goto free_cdnsp;
3d82904559f4f5 Pawel Laszczak 2020-12-07 115 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 116
3d82904559f4f5 Pawel Laszczak 2020-12-07 117 cdnsp->dev_regs = devm_ioremap(dev, rsrc_start, rsrc_len);
3d82904559f4f5 Pawel Laszczak 2020-12-07 118 if (!cdnsp->dev_regs) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 119 dev_dbg(dev, "error mapping memory\n");
3d82904559f4f5 Pawel Laszczak 2020-12-07 120 ret = -EFAULT;
3d82904559f4f5 Pawel Laszczak 2020-12-07 121 goto free_cdnsp;
3d82904559f4f5 Pawel Laszczak 2020-12-07 122 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 123
3d82904559f4f5 Pawel Laszczak 2020-12-07 124 cdnsp->dev_irq = pdev->irq;
3d82904559f4f5 Pawel Laszczak 2020-12-07 125 dev_dbg(dev, "USBSS-DEV physical base addr: %pa\n",
3d82904559f4f5 Pawel Laszczak 2020-12-07 126 &rsrc_start);
3d82904559f4f5 Pawel Laszczak 2020-12-07 127
3d82904559f4f5 Pawel Laszczak 2020-12-07 128 res = &cdnsp->xhci_res[0];
3d82904559f4f5 Pawel Laszczak 2020-12-07 129 res->start = pci_resource_start(pdev, PCI_BAR_HOST);
3d82904559f4f5 Pawel Laszczak 2020-12-07 130 res->end = pci_resource_end(pdev, PCI_BAR_HOST);
3d82904559f4f5 Pawel Laszczak 2020-12-07 131 res->name = "xhci";
3d82904559f4f5 Pawel Laszczak 2020-12-07 132 res->flags = IORESOURCE_MEM;
3d82904559f4f5 Pawel Laszczak 2020-12-07 133 dev_dbg(dev, "USBSS-XHCI physical base addr: %pa\n",
3d82904559f4f5 Pawel Laszczak 2020-12-07 134 &res->start);
3d82904559f4f5 Pawel Laszczak 2020-12-07 135
3d82904559f4f5 Pawel Laszczak 2020-12-07 136 /* Interrupt for XHCI, */
3d82904559f4f5 Pawel Laszczak 2020-12-07 137 res = &cdnsp->xhci_res[1];
3d82904559f4f5 Pawel Laszczak 2020-12-07 138 res->start = pdev->irq;
3d82904559f4f5 Pawel Laszczak 2020-12-07 139 res->name = "host";
3d82904559f4f5 Pawel Laszczak 2020-12-07 140 res->flags = IORESOURCE_IRQ;
3d82904559f4f5 Pawel Laszczak 2020-12-07 141 } else {
3d82904559f4f5 Pawel Laszczak 2020-12-07 142 res = &cdnsp->otg_res;
3d82904559f4f5 Pawel Laszczak 2020-12-07 143 res->start = pci_resource_start(pdev, PCI_BAR_OTG);
3d82904559f4f5 Pawel Laszczak 2020-12-07 144 res->end = pci_resource_end(pdev, PCI_BAR_OTG);
3d82904559f4f5 Pawel Laszczak 2020-12-07 145 res->name = "otg";
3d82904559f4f5 Pawel Laszczak 2020-12-07 146 res->flags = IORESOURCE_MEM;
3d82904559f4f5 Pawel Laszczak 2020-12-07 147 dev_dbg(dev, "CDNSP-DRD physical base addr: %pa\n",
3d82904559f4f5 Pawel Laszczak 2020-12-07 148 &res->start);
3d82904559f4f5 Pawel Laszczak 2020-12-07 149
3d82904559f4f5 Pawel Laszczak 2020-12-07 150 /* Interrupt for OTG/DRD. */
3d82904559f4f5 Pawel Laszczak 2020-12-07 151 cdnsp->otg_irq = pdev->irq;
3d82904559f4f5 Pawel Laszczak 2020-12-07 152 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 153
3d82904559f4f5 Pawel Laszczak 2020-12-07 154 if (pci_is_enabled(func)) {
3d82904559f4f5 Pawel Laszczak 2020-12-07 155 cdnsp->dev = dev;
3d82904559f4f5 Pawel Laszczak 2020-12-07 156 cdnsp->gadget_init = cdnsp_gadget_init;
3d82904559f4f5 Pawel Laszczak 2020-12-07 157
3d82904559f4f5 Pawel Laszczak 2020-12-07 158 ret = cdns_init(cdnsp);
3d82904559f4f5 Pawel Laszczak 2020-12-07 159 if (ret)
3d82904559f4f5 Pawel Laszczak 2020-12-07 160 goto free_cdnsp;
3d82904559f4f5 Pawel Laszczak 2020-12-07 161 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 162
3d82904559f4f5 Pawel Laszczak 2020-12-07 163 pci_set_drvdata(pdev, cdnsp);
3d82904559f4f5 Pawel Laszczak 2020-12-07 164
3d82904559f4f5 Pawel Laszczak 2020-12-07 165 device_wakeup_enable(&pdev->dev);
3d82904559f4f5 Pawel Laszczak 2020-12-07 166 if (pci_dev_run_wake(pdev))
3d82904559f4f5 Pawel Laszczak 2020-12-07 167 pm_runtime_put_noidle(&pdev->dev);
3d82904559f4f5 Pawel Laszczak 2020-12-07 168
3d82904559f4f5 Pawel Laszczak 2020-12-07 169 return 0;
3d82904559f4f5 Pawel Laszczak 2020-12-07 170
3d82904559f4f5 Pawel Laszczak 2020-12-07 171 free_cdnsp:
3d82904559f4f5 Pawel Laszczak 2020-12-07 172 if (!pci_is_enabled(func))
3d82904559f4f5 Pawel Laszczak 2020-12-07 173 kfree(cdnsp);
3d82904559f4f5 Pawel Laszczak 2020-12-07 174
3d82904559f4f5 Pawel Laszczak 2020-12-07 175 disable_pci:
3d82904559f4f5 Pawel Laszczak 2020-12-07 176 pci_disable_device(pdev);
3d82904559f4f5 Pawel Laszczak 2020-12-07 177
3d82904559f4f5 Pawel Laszczak 2020-12-07 178 put_pci:
3d82904559f4f5 Pawel Laszczak 2020-12-07 179 pci_dev_put(func);
3d82904559f4f5 Pawel Laszczak 2020-12-07 180
3d82904559f4f5 Pawel Laszczak 2020-12-07 @181 return ret;
3d82904559f4f5 Pawel Laszczak 2020-12-07 182 }
3d82904559f4f5 Pawel Laszczak 2020-12-07 183
:::::: The code at line 181 was first introduced by commit
:::::: 3d82904559f4f5a2622db1b21de3edf2eded7664 usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver
:::::: TO: Pawel Laszczak <pawell@cadence.com>
:::::: CC: Peter Chen <peter.chen@nxp.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2021-12-09 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 13:50 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-25 22:54 drivers/usb/cdns3/cdnsp-pci.c:181 cdnsp_pci_probe() warn: possible memory leak of 'cdnsp' kernel test robot
2021-11-24 18:05 kernel test robot
2021-08-03 4:06 kernel test robot
2021-07-02 10:06 kernel test robot
2021-04-17 8:49 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112092103.65goOmME-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.