From: Hannes Reinecke <hare@suse.de>
To: Damien LeMoal <damien.lemoal@wdc.com>
Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv2 00/68] libata: rework logging, take II
Date: Fri, 10 Dec 2021 08:27:57 +0100 [thread overview]
Message-ID: <20211210072905.15666-1-hare@suse.de> (raw)
Hi all,
after some prodding from individual persons I've resurrected my
patchset to put libata logging on a even keel, and use structured
logging for everything.
So this patch does away with DPRINTK, ATA_DEBUG or ata_msg_XXX()
calls, and moves everything over to structured logging
(ie the dev_XXX() calls).
Additionally I've added tracepoints to trace command flow,
error handling, host state machine etc.
So everything is looking far saner now.
As usual, comments and reviews are welcome.
I know that the device names suck. Blame Tejun.
Changes to the original submission:
- Converted all printk() and pr_XXX() calls, too
- Included reviews from Damien
- Included reviews from Sergey
Hannes Reinecke (68):
libata: remove pointless debugging messages
libata: whitespace cleanup
libata: Add ata_port_classify() helper
libata: move ata_dump_id() to dynamic debugging
libata: sanitize ATA_HORKAGE_DUMP_ID
libata: add reset tracepoints
libata: add qc_prep tracepoint
libata: tracepoints for bus-master DMA
libata-sff: tracepoints for HSM state machine
libata-scsi: drop DPRINTK calls for cdb translation
libata: add tracepoints for ATA error handling
libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros
libata: revamp ata_get_cmd_descript()
libata: move DPRINTK to ata debugging
sata_mv: kill 'port' argument in mv_dump_all_regs()
sata_mv: replace DPRINTK with dynamic debugging
pata_octeon_cf: remove DPRINTK() macro in interrupt context
pdc_adma: Remove DPRINTK call
sata_fsl: move DPRINTK to ata debugging
sata_rcar: replace DPRINTK() with ata_port_dbg()
sata_qstor: replace DPRINTK() with ata_port_dbg()
pata_pdc2027x: Replace PDPRINTK() with standard ata logging
libata: remove pointless VPRINTK() calls
ahci: Drop pointless VPRINTK() calls and convert the remaining ones
pdc_adma: Drop pointless VPRINTK() calls and remove disabled NCQ
debugging
pata_octeon_cf: Drop pointless VPRINTK() calls and convert the
remaining one
pata_via: Drop pointless VPRINTK() calls
sata_promise: Drop pointless VPRINTK() calls and convert the remaining
ones
sata_qstor: Drop pointless VPRINTK() calls
sata_rcar: Drop pointless VPRINTK() calls
sata_inic162x: Drop pointless VPRINTK() calls
sata_mv: Drop pointless VPRINTK() call and convert the remaining one
sata_nv: drop pointless VPRINTK() calls and convert remaining ones
sata_fsl: convert VPRINTK() calls to ata_port_dbg()
sata_sil: Drop pointless VPRINTK() calls
sata_sx4: Drop pointless VPRINTK() calls and convert the remaining
ones
sata_sx4: add module parameter 'dimm_test'
libata: drop ata_msg_error() and ata_msg_intr()
libata: drop ata_msg_ctl()
libata: drop ata_msg_malloc()
libata: drop ata_msg_warn()
libata: drop ata_msg_probe()
libata: drop ata_msg_info()
libata: drop ata_msg_drv()
libata: remove 'new' ata message handling
libata: remove debug compilation switches
pata_atp867x: convert printk() calls
pata_cmd640: convert printk() calls
pata_cmd64x: convert printk() calls
pata_cs5520: convert printk() calls
pata_cs5536: convert printk() calls
pata_cypress: convert printk() calls
pata_it821x: convert printk() calls
pata_marvell: convert printk() calls
pata_rz1000: convert printk() calls
pata_serverworks: convert printk() calls
pata_sil680: convert printk() calls
sata_sx4: convert printk() calls
sata_mv: convert remaining printk() to structured logging
pata_hpt37x: convert pr_XXX() calls
pata_octeon_cf: Replace pr_XXX() calls with structured logging
pata_hpt3x2n: convert pr_XXX() calls
sata_gemini: convert pr_err() calls
pata_hpt366: convert pr_warn() calls
libata-scsi: rework ata_dump_status to avoid using pr_cont()
sata_dwc_460ex: drop DEBUG_NCQ
sata_dwc_460ex: remove 'checkstatus' argument
sata_dwc_460ex: Remove debug compile options
drivers/ata/Kconfig | 12 -
drivers/ata/acard-ahci.c | 4 -
drivers/ata/ahci.c | 13 +-
drivers/ata/ahci_qoriq.c | 4 -
drivers/ata/ahci_xgene.c | 4 -
drivers/ata/ata_piix.c | 11 +-
drivers/ata/libahci.c | 33 +--
drivers/ata/libata-acpi.c | 69 +++---
drivers/ata/libata-core.c | 225 ++++-------------
drivers/ata/libata-eh.c | 70 +++---
drivers/ata/libata-pmp.c | 8 -
drivers/ata/libata-sata.c | 5 -
drivers/ata/libata-scsi.c | 111 ++-------
drivers/ata/libata-sff.c | 88 +++----
drivers/ata/libata-trace.c | 47 ++++
drivers/ata/libata-transport.c | 45 +++-
drivers/ata/libata.h | 5 +-
drivers/ata/pata_arasan_cf.c | 3 +
drivers/ata/pata_atp867x.c | 29 +--
drivers/ata/pata_cmd640.c | 2 +-
drivers/ata/pata_cmd64x.c | 4 +-
drivers/ata/pata_cs5520.c | 4 +-
drivers/ata/pata_cs5536.c | 4 +-
drivers/ata/pata_cypress.c | 2 +-
drivers/ata/pata_ep93xx.c | 1 -
drivers/ata/pata_hpt366.c | 5 +-
drivers/ata/pata_hpt37x.c | 20 +-
drivers/ata/pata_hpt3x2n.c | 12 +-
drivers/ata/pata_it821x.c | 43 ++--
drivers/ata/pata_ixp4xx_cf.c | 6 +-
drivers/ata/pata_marvell.c | 9 +-
drivers/ata/pata_octeon_cf.c | 48 +---
drivers/ata/pata_pdc2027x.c | 71 +++---
drivers/ata/pata_pdc202xx_old.c | 2 -
drivers/ata/pata_rz1000.c | 4 +-
drivers/ata/pata_serverworks.c | 4 +-
drivers/ata/pata_sil680.c | 9 +-
drivers/ata/pata_via.c | 12 -
drivers/ata/pdc_adma.c | 33 +--
drivers/ata/sata_dwc_460ex.c | 120 ++-------
drivers/ata/sata_fsl.c | 165 +++++--------
drivers/ata/sata_gemini.c | 4 +-
drivers/ata/sata_inic162x.c | 4 +-
drivers/ata/sata_mv.c | 130 +++++-----
drivers/ata/sata_nv.c | 54 ++---
drivers/ata/sata_promise.c | 31 +--
drivers/ata/sata_qstor.c | 15 +-
drivers/ata/sata_rcar.c | 26 +-
drivers/ata/sata_sil.c | 1 -
drivers/ata/sata_sil24.c | 5 +-
drivers/ata/sata_sx4.c | 148 ++++--------
include/linux/libata.h | 99 ++------
include/trace/events/libata.h | 416 +++++++++++++++++++++++++++++++-
53 files changed, 1049 insertions(+), 1250 deletions(-)
--
2.29.2
next reply other threads:[~2021-12-10 7:29 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 7:27 Hannes Reinecke [this message]
2021-12-10 7:27 ` [PATCH 01/68] libata: remove pointless debugging messages Hannes Reinecke
2021-12-10 7:27 ` [PATCH 02/68] libata: whitespace cleanup Hannes Reinecke
2021-12-10 7:28 ` [PATCH 03/68] libata: Add ata_port_classify() helper Hannes Reinecke
2021-12-10 7:28 ` [PATCH 04/68] libata: move ata_dump_id() to dynamic debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 05/68] libata: sanitize ATA_HORKAGE_DUMP_ID Hannes Reinecke
2021-12-10 7:28 ` [PATCH 06/68] libata: add reset tracepoints Hannes Reinecke
2021-12-10 7:28 ` [PATCH 07/68] libata: add qc_prep tracepoint Hannes Reinecke
2021-12-10 7:28 ` [PATCH 08/68] libata: tracepoints for bus-master DMA Hannes Reinecke
2021-12-10 7:28 ` [PATCH 09/68] libata-sff: tracepoints for HSM state machine Hannes Reinecke
2021-12-10 7:28 ` [PATCH 10/68] libata-scsi: drop DPRINTK calls for cdb translation Hannes Reinecke
2021-12-10 7:28 ` [PATCH 11/68] libata: add tracepoints for ATA error handling Hannes Reinecke
2021-12-10 7:28 ` [PATCH 12/68] libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros Hannes Reinecke
2021-12-10 7:28 ` [PATCH 13/68] libata: revamp ata_get_cmd_descript() Hannes Reinecke
2021-12-12 9:33 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 14/68] libata: move DPRINTK to ata debugging Hannes Reinecke
2021-12-12 9:36 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 15/68] sata_mv: kill 'port' argument in mv_dump_all_regs() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 16/68] sata_mv: replace DPRINTK with dynamic debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 17/68] pata_octeon_cf: remove DPRINTK() macro in interrupt context Hannes Reinecke
2021-12-10 7:28 ` [PATCH 18/68] pdc_adma: Remove DPRINTK call Hannes Reinecke
2021-12-10 7:28 ` [PATCH 19/68] sata_fsl: move DPRINTK to ata debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 20/68] sata_rcar: replace DPRINTK() with ata_port_dbg() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 21/68] sata_qstor: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 22/68] pata_pdc2027x: Replace PDPRINTK() with standard ata logging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 23/68] libata: remove pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 24/68] ahci: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-10 7:28 ` [PATCH 25/68] pdc_adma: Drop pointless VPRINTK() calls and remove disabled NCQ debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 26/68] pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining one Hannes Reinecke
2021-12-12 9:23 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 27/68] pata_via: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 28/68] sata_promise: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-10 16:19 ` Mikael Pettersson
2021-12-12 9:52 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 29/68] sata_qstor: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 30/68] sata_rcar: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 31/68] sata_inic162x: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 32/68] sata_mv: Drop pointless VPRINTK() call and convert the remaining one Hannes Reinecke
2021-12-10 7:28 ` [PATCH 33/68] sata_nv: drop pointless VPRINTK() calls and convert remaining ones Hannes Reinecke
2021-12-10 7:28 ` [PATCH 34/68] sata_fsl: convert VPRINTK() calls to ata_port_dbg() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 35/68] sata_sil: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 36/68] sata_sx4: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-10 7:28 ` [PATCH 37/68] sata_sx4: add module parameter 'dimm_test' Hannes Reinecke
2021-12-10 7:28 ` [PATCH 38/68] libata: drop ata_msg_error() and ata_msg_intr() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 39/68] libata: drop ata_msg_ctl() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 40/68] libata: drop ata_msg_malloc() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 41/68] libata: drop ata_msg_warn() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 42/68] libata: drop ata_msg_probe() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 43/68] libata: drop ata_msg_info() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 44/68] libata: drop ata_msg_drv() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 45/68] libata: remove 'new' ata message handling Hannes Reinecke
2021-12-10 7:28 ` [PATCH 46/68] libata: remove debug compilation switches Hannes Reinecke
2021-12-12 9:21 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 47/68] pata_atp867x: convert printk() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 48/68] pata_cmd640: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 49/68] pata_cmd64x: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 50/68] pata_cs5520: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 51/68] pata_cs5536: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 52/68] pata_cypress: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 53/68] pata_it821x: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 54/68] pata_marvell: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 55/68] pata_rz1000: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 56/68] pata_serverworks: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 57/68] pata_sil680: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 58/68] sata_sx4: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 59/68] sata_mv: convert remaining printk() to structured logging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 60/68] pata_hpt37x: convert pr_XXX() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 61/68] pata_octeon_cf: Replace pr_XXX() calls with structured logging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 62/68] pata_hpt3x2n: convert pr_XXX() calls Hannes Reinecke
2021-12-10 7:29 ` [PATCH 63/68] sata_gemini: convert pr_err() calls Hannes Reinecke
2021-12-10 7:29 ` [PATCH 64/68] pata_hpt366: convert pr_warn() calls Hannes Reinecke
2021-12-10 7:29 ` [PATCH 65/68] libata-scsi: rework ata_dump_status to avoid using pr_cont() Hannes Reinecke
2021-12-10 7:29 ` [PATCH 66/68] sata_dwc_460ex: drop DEBUG_NCQ Hannes Reinecke
2021-12-10 7:29 ` [PATCH 67/68] sata_dwc_460ex: remove 'checkstatus' argument Hannes Reinecke
2021-12-12 9:18 ` Sergey Shtylyov
2021-12-10 7:29 ` [PATCH 68/68] sata_dwc_460ex: Remove debug compile options Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210072905.15666-1-hare@suse.de \
--to=hare@suse.de \
--cc=damien.lemoal@wdc.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.