From: Masami Hiramatsu <mhiramat@kernel.org>
To: Yanteng Si <siyanteng01@gmail.com>
Cc: rostedt@goodmis.org, corbet@lwn.net, linux-doc@vger.kernel.org,
akiyks@gmail.com, Yanteng Si <siyanteng@loongson.cn>
Subject: Re: [PATCH v2] docs/trace: fix a label of boottime-trace
Date: Fri, 10 Dec 2021 14:19:36 +0900 [thread overview]
Message-ID: <20211210141936.56fb2cfb71e057148cef15c7@kernel.org> (raw)
In-Reply-To: <20211210041536.1446734-1-siyanteng@loongson.cn>
On Fri, 10 Dec 2021 12:15:36 +0800
Yanteng Si <siyanteng01@gmail.com> wrote:
> Since 559789539255 ("Documentation: tracing: Add histogram syntax to boot-time tracing") which
> introduced a warning:
>
> linux/Documentation/trace/boottime-trace.rst:136: WARNING: undefined label: histogram (if the link has no caption the label must precede a section header)
>
> Replace with: (path)
>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Fixes: 559789539255 ("Documentation: tracing: Add histogram syntax to boot-time tracing")
Thank you,
> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
> ---
> Documentation/trace/boottime-trace.rst | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/trace/boottime-trace.rst b/Documentation/trace/boottime-trace.rst
> index 6dcfbc64014d..d594597201fd 100644
> --- a/Documentation/trace/boottime-trace.rst
> +++ b/Documentation/trace/boottime-trace.rst
> @@ -131,9 +131,7 @@ Ftrace Histogram Options
> Since it is too long to write a histogram action as a string for per-event
> action option, there are tree-style options under per-event 'hist' subkey
> for the histogram actions. For the detail of the each parameter,
> -please read the event histogram document [3]_.
> -
> -.. [3] See :ref:`Documentation/trace/histogram.rst <histogram>`
> +please read the event histogram document (Documentation/trace/histogram.rst)
>
> ftrace.[instance.INSTANCE.]event.GROUP.EVENT.hist.[N.]keys = KEY1[, KEY2[...]]
> Set histogram key parameters. (Mandatory)
> --
> 2.27.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-12-10 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 4:15 [PATCH v2] docs/trace: fix a label of boottime-trace Yanteng Si
2021-12-10 5:19 ` Masami Hiramatsu [this message]
2021-12-10 17:37 ` Steven Rostedt
2021-12-10 20:59 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210141936.56fb2cfb71e057148cef15c7@kernel.org \
--to=mhiramat@kernel.org \
--cc=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=siyanteng01@gmail.com \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.