From: Florian Westphal <fw@strlen.de>
To: "Ignacy Gawędzki" <ignacy.gawedzki@green-communications.fr>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: fix regression in looped (broad|multi)cast's MAC handling
Date: Fri, 10 Dec 2021 16:09:44 +0100 [thread overview]
Message-ID: <20211210150944.GG26636@breakpoint.cc> (raw)
In-Reply-To: <20211210142741.fsklz2vzlsow3qre@zenon.in.qult.net>
Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr> wrote:
> In commit 5648b5e1169f ("netfilter: nfnetlink_queue: fix OOB when mac
> header was cleared"), the test for non-empty MAC header introduced in
> commit 2c38de4c1f8da7 ("netfilter: fix looped (broad|multi)cast's MAC
> handling") has been replaced with a test for a set MAC header, which
> breaks the case when the MAC header has been reset (using
> skb_reset_mac_header), as is the case with looped-back multicast
> packets.
Please rephrase this to say what breaks here.
I guess you get a bogus hwaddr in the netlink message?
Also, this should be sent to netfilter-devel@, not netdev@.
For the patch itself:
Reviewed-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2021-12-10 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 14:27 [PATCH v2] netfilter: fix regression in looped (broad|multi)cast's MAC handling Ignacy Gawędzki
2021-12-10 15:09 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210150944.GG26636@breakpoint.cc \
--to=fw@strlen.de \
--cc=ignacy.gawedzki@green-communications.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.