All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:8506 mlxsw_sp_rif_mac_profile_replace() error: uninitialized symbol 'mac_profile'.
Date: Sat, 11 Dec 2021 23:42:10 +0800	[thread overview]
Message-ID: <202112112241.bJRLJ5Md-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3119 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Danielle Ratson <danieller@nvidia.com>
CC: Ido Schimmel <idosch@nvidia.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6f513529296fd4f696afb4354c46508abe646541
commit: 605d25cd782a67f0c9d871096ee04acfe14f89ca mlxsw: spectrum_router: Add RIF MAC profiles support
date:   7 weeks ago
:::::: branch date: 13 hours ago
:::::: commit date: 7 weeks ago
config: x86_64-randconfig-m001-20211210 (https://download.01.org/0day-ci/archive/20211211/202112112241.bJRLJ5Md-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:8506 mlxsw_sp_rif_mac_profile_replace() error: uninitialized symbol 'mac_profile'.
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:9281 mlxsw_sp_rif_subport_configure() error: uninitialized symbol 'mac_profile'.
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:9363 mlxsw_sp_rif_fid_configure() error: uninitialized symbol 'mac_profile'.

vim +/mac_profile +8506 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

605d25cd782a67 Danielle Ratson 2021-10-26  8487  
605d25cd782a67 Danielle Ratson 2021-10-26  8488  static int
605d25cd782a67 Danielle Ratson 2021-10-26  8489  mlxsw_sp_rif_mac_profile_replace(struct mlxsw_sp *mlxsw_sp,
605d25cd782a67 Danielle Ratson 2021-10-26  8490  				 struct mlxsw_sp_rif *rif,
605d25cd782a67 Danielle Ratson 2021-10-26  8491  				 const char *new_mac,
605d25cd782a67 Danielle Ratson 2021-10-26  8492  				 struct netlink_ext_ack *extack)
605d25cd782a67 Danielle Ratson 2021-10-26  8493  {
605d25cd782a67 Danielle Ratson 2021-10-26  8494  	u8 mac_profile;
605d25cd782a67 Danielle Ratson 2021-10-26  8495  	int err;
605d25cd782a67 Danielle Ratson 2021-10-26  8496  
605d25cd782a67 Danielle Ratson 2021-10-26  8497  	if (!mlxsw_sp_rif_mac_profile_is_shared(rif))
605d25cd782a67 Danielle Ratson 2021-10-26  8498  		return mlxsw_sp_rif_mac_profile_edit(rif, new_mac);
605d25cd782a67 Danielle Ratson 2021-10-26  8499  
605d25cd782a67 Danielle Ratson 2021-10-26  8500  	err = mlxsw_sp_rif_mac_profile_get(mlxsw_sp, new_mac,
605d25cd782a67 Danielle Ratson 2021-10-26  8501  					   &mac_profile, extack);
605d25cd782a67 Danielle Ratson 2021-10-26  8502  	if (err)
605d25cd782a67 Danielle Ratson 2021-10-26  8503  		return err;
605d25cd782a67 Danielle Ratson 2021-10-26  8504  
605d25cd782a67 Danielle Ratson 2021-10-26  8505  	mlxsw_sp_rif_mac_profile_put(mlxsw_sp, rif->mac_profile_id);
605d25cd782a67 Danielle Ratson 2021-10-26 @8506  	rif->mac_profile_id = mac_profile;
605d25cd782a67 Danielle Ratson 2021-10-26  8507  	return 0;
605d25cd782a67 Danielle Ratson 2021-10-26  8508  }
605d25cd782a67 Danielle Ratson 2021-10-26  8509  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

             reply	other threads:[~2021-12-11 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-11 15:42 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-08-11  6:02 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:8506 mlxsw_sp_rif_mac_profile_replace() error: uninitialized symbol 'mac_profile' kernel test robot
2022-08-12  7:23 kernel test robot
2022-08-13  4:31 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202112112241.bJRLJ5Md-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.