From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C281C4332F for ; Mon, 13 Dec 2021 10:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JDFX3MAHOf/TXx2nbG2IZHnW1Dfejo1M1j2tQ7JWRxM=; b=CuWxFCvbEoRNTE TUYT2eZKLtasqRmaWR6xpmwhcX9kSaavbuQkKDBt4Zsol7+ObiVGo99WXK6XH9EXtrWw32xPz/ZDP krXOi6WWnKAHiGPaNAhyZ4TWz+cl9xq+OA0GLlPfeFr3Cll7AlwjeKScaacRXHzo01sQvsB/5Fynr AjYgwZaHVc1E/QfQFOBAhMmRXhmwXFMHLQxAbCOvv2iE30XKPfiCRpADQvuAmEZ4suAtLGyZxsHh4 YN4FWIAWV01Rzx0EuBw25AeAmNXHou8K0g87+A7T1uoSx/fZgqjPfUt9gmYRdyav0pfDDp29825I6 8plphpbCftLmLFCpq4fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwiLW-008vBf-2Q; Mon, 13 Dec 2021 10:14:14 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwi1d-008mWr-74 for linux-mtd@lists.infradead.org; Mon, 13 Dec 2021 09:53:42 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 746991F44A0B; Mon, 13 Dec 2021 09:53:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1639389219; bh=KzIEkt0Pnf8oSDZnNFpPbqadcja3KMzzDBPP+J7Iedw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fv5HNHGpu9Wq5mN73A3tH5QrrgoMtr+yrsL+2S0pRK+J2FH0PL+jp3VvGsKYNNM2q RHF5VljJ/gHNCc+MfqvKVQHX9OJ3CKPIJtN6w3OB41Ge6nNrwhH1e482E85TVrAbTH 6Q4UmdCifr3weDEFoXJc2YBRopfsIdIWID3/HxgVq/8Kjp3qLgmGpumhltKW9NkT3l bmlrEZkVCqG7tJp5Nw9k3L1sWrjOSJjIGcffzt4fszjFSwnhIHnJk0cAGrHXtD9vbL WcDooXyWzU/26+xh55+cu/UzML7o7z+CGCQ+4P4jk5+7qG4axnMKLmuShQEdmA1Q3E VnLlrL9Gkm/Fw== Date: Mon, 13 Dec 2021 10:53:36 +0100 From: Boris Brezillon To: Miquel Raynal Cc: Sean Nyekjaer , linux-kernel@vger.kernel.org, Marek Szyprowski , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , linux-mtd@lists.infradead.org Subject: Re: [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend Message-ID: <20211213105336.7be369b7@collabora.com> In-Reply-To: <20211213103350.22590c13@xps13> References: <20211129101908.6f1aa715@xps13> <20211129094129.xn364czofrgtvfb4@skn-laptop> <63be9121-18c3-1ef2-c448-f99fb861490f@samsung.com> <20211130124131.6pgu7enjgk6y536m@skn-laptop> <20211130141551.400331c8@collabora.com> <20211130132912.v6v45boce2zbnoy3@skn-laptop> <20211130143705.5d0404aa@collabora.com> <20211203143958.40645506@xps13> <20211209140721.6ki7gznvxwyn3cze@skn-laptop.hinnerup> <20211209152811.318bdf17@xps13> <20211210132535.gy7rqj5zblqlnz5y@skn-laptop.hadsten> <20211213101025.42c27b43@xps13> <20211213102801.569b50b1@collabora.com> <20211213103350.22590c13@xps13> Organization: Collabora X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_015341_453225_BBEF104F X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxMyBEZWMgMjAyMSAxMDozMzo1MCArMDEwMApNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwu cmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZToKCj4gSGVsbG8sCj4gCj4gYm9yaXMuYnJlemlsbG9u QGNvbGxhYm9yYS5jb20gd3JvdGUgb24gTW9uLCAxMyBEZWMgMjAyMSAxMDoyODowMSArMDEwMDoK PiAKPiA+IE9uIE1vbiwgMTMgRGVjIDIwMjEgMTA6MTA6MjUgKzAxMDAKPiA+IE1pcXVlbCBSYXlu YWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3RlOgo+ID4gICAKPiA+ID4gSGkgU2Vh biwKPiA+ID4gCj4gPiA+IHNlYW5AZ2Vhbml4LmNvbSB3cm90ZSBvbiBGcmksIDEwIERlYyAyMDIx IDE0OjI1OjM1ICswMTAwOgo+ID4gPiAgICAgCj4gPiA+ID4gT24gVGh1LCBEZWMgMDksIDIwMjEg YXQgMDM6Mjg6MTFQTSArMDEwMCwgTWlxdWVsIFJheW5hbCB3cm90ZTogICAgICAKPiA+ID4gPiA+ IEhpIFNlYW4sCj4gPiA+ID4gPiAKPiA+ID4gPiA+IHNlYW5AZ2Vhbml4LmNvbSB3cm90ZSBvbiBU aHUsIDkgRGVjIDIwMjEgMTU6MDc6MjEgKzAxMDA6Cj4gPiA+ID4gPiAgICAgICAgIAo+ID4gPiA+ ID4gPiBPbiBGcmksIERlYyAwMywgMjAyMSBhdCAwMjozOTo1OFBNICswMTAwLCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOiAgICAgICAgCj4gPiA+ID4gPiA+ID4gSGVsbG8sCj4gPiA+ID4gPiA+ID4gICAg ICAgICAgIAo+ID4gPiA+ID4gPiA+ID4gPiBGaW5lIGJ5IG1lLCBsZXRzIGRyb3AgdGhpcyBzZXJp ZXMuICAgICAgICAgIAo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IEZZSSBJJ3ZlIGRyb3Bw ZWQgdGhlIGVudGlyZSBzZXJpZXMgZnJvbSBtdGQvbmV4dC4gSSdtIHdhaXRpbmcgZm9yIHRoZQo+ ID4gPiA+ID4gPiA+IGZpeCBkaXNjdXNzZWQgYmVsb3cgKHdpdGhvdXQgYWJ1c2luZyB0aGUgY2hp cCBtdXRleCA7LSkgKS4gICAgICAgICAgCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBDb29sLCBs b29raW5nIGZvcndhcmQgdG8gdGVzdCBhIHBhdGNoIHNlcmllcyA6KSAgICAgICAgCj4gPiA+ID4g PiAKPiA+ID4gPiA+IFRlc3Q/IFlvdSBtZWFuICJ3cml0ZSI/IDopCj4gPiA+ID4gPiAKPiA+ID4g PiA+IENoZWVycywKPiA+ID4gPiA+IE1pcXXDqGwgICAgICAgIAo+ID4gPiA+IAo+ID4gPiA+IEhp IE1pcXVlbCwKPiA+ID4gPiAKPiA+ID4gPiBTaG91bGQgd2UgdXMgYSBhdG9taWMgZm9yIHRoZSBz dXNwZW5kZWQgdmFyaWFibGU/ICAgICAgCj4gPiA+IAo+ID4gPiBJIGhhdmVuJ3QgdGhvdWdodCBh Ym91dCBpdCBleHRlbnNpdmVseSwgYW4gYXRvbWljIHZhcmlhYmxlIHNvdW5kIGZpbmUKPiA+ID4g YnV0IEkgYW0gZGVmaW5pdGVseSBub3QgYSBsb2NraW5nIGV4cGVydC4uLiAgICAKPiA+IAo+ID4g Tm8gbmVlZCB0byB1c2UgYW4gYXRvbWljIGlmIHRoZSB2YXJpYWJsZSBpcyBhbHJlYWR5IHByb3Rl Y3RlZCBieSBhIGxvY2sKPiA+IHdoZW4gYWNjZXNzZWQsIGFuZCB0aGlzIHNlZW1zIHRvIGJlIGNh c2UuICAKPiAKPiBNYXliZSB0aGVyZSB3YXMgYSBjb25mdXNpb24gYWJvdXQgdGhpcyBsb2NrOiBJ IHRoaW5rIEJvcmlzIGp1c3QgZG8gbm90Cj4gd2FudCB0aGUgY29yZSB0byB0YWtlIGFueSBsb2Nr IGR1cmluZyBhIHN1c3BlbmQgb3BlcmF0aW9uLiBCdXQgeW91IGNhbgo+IHN0aWxsIHVzZSBsb2Nr cywgYXMgbG9uZyBhcyB5b3UgcmVsZWFzZSB0aGVtIGJlZm9yZSBzdXNwZW5kaW5nLgo+IAo+IEFu ZCBhbHNvLCB0aGF0IGNoaXAgbG9jayBtaWdodCBub3QgYmUgdGhlIG9uZSB5b3Ugd2FudCB0byB0 YWtlIGJlY2F1c2UKPiBpdCdzIGJlZW4gaW50cm9kdWNlZCBmb3IgYW5vdGhlciBwdXJwb3NlLgoK QWNjZXNzIHRvIHRoZSBzdXNwZW5kZWQgZmllbGQgaXMgYWxyZWFkeSBwcm90ZWN0ZWQgYnkgdGhl IGNoaXAgbG9jaywKYW5kIEkgdGhpbmsgaXQncyBqdXN0IGZpbmUgdG8ga2VlcCBpdCB0aGlzIHdh eS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63100C433F5 for ; Mon, 13 Dec 2021 10:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240493AbhLMKCA (ORCPT ); Mon, 13 Dec 2021 05:02:00 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36618 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236560AbhLMJxl (ORCPT ); Mon, 13 Dec 2021 04:53:41 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 746991F44A0B; Mon, 13 Dec 2021 09:53:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1639389219; bh=KzIEkt0Pnf8oSDZnNFpPbqadcja3KMzzDBPP+J7Iedw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fv5HNHGpu9Wq5mN73A3tH5QrrgoMtr+yrsL+2S0pRK+J2FH0PL+jp3VvGsKYNNM2q RHF5VljJ/gHNCc+MfqvKVQHX9OJ3CKPIJtN6w3OB41Ge6nNrwhH1e482E85TVrAbTH 6Q4UmdCifr3weDEFoXJc2YBRopfsIdIWID3/HxgVq/8Kjp3qLgmGpumhltKW9NkT3l bmlrEZkVCqG7tJp5Nw9k3L1sWrjOSJjIGcffzt4fszjFSwnhIHnJk0cAGrHXtD9vbL WcDooXyWzU/26+xh55+cu/UzML7o7z+CGCQ+4P4jk5+7qG4axnMKLmuShQEdmA1Q3E VnLlrL9Gkm/Fw== Date: Mon, 13 Dec 2021 10:53:36 +0100 From: Boris Brezillon To: Miquel Raynal Cc: Sean Nyekjaer , linux-kernel@vger.kernel.org, Marek Szyprowski , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , linux-mtd@lists.infradead.org Subject: Re: [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend Message-ID: <20211213105336.7be369b7@collabora.com> In-Reply-To: <20211213103350.22590c13@xps13> References: <20211129101908.6f1aa715@xps13> <20211129094129.xn364czofrgtvfb4@skn-laptop> <63be9121-18c3-1ef2-c448-f99fb861490f@samsung.com> <20211130124131.6pgu7enjgk6y536m@skn-laptop> <20211130141551.400331c8@collabora.com> <20211130132912.v6v45boce2zbnoy3@skn-laptop> <20211130143705.5d0404aa@collabora.com> <20211203143958.40645506@xps13> <20211209140721.6ki7gznvxwyn3cze@skn-laptop.hinnerup> <20211209152811.318bdf17@xps13> <20211210132535.gy7rqj5zblqlnz5y@skn-laptop.hadsten> <20211213101025.42c27b43@xps13> <20211213102801.569b50b1@collabora.com> <20211213103350.22590c13@xps13> Organization: Collabora X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Dec 2021 10:33:50 +0100 Miquel Raynal wrote: > Hello, >=20 > boris.brezillon@collabora.com wrote on Mon, 13 Dec 2021 10:28:01 +0100: >=20 > > On Mon, 13 Dec 2021 10:10:25 +0100 > > Miquel Raynal wrote: > > =20 > > > Hi Sean, > > >=20 > > > sean@geanix.com wrote on Fri, 10 Dec 2021 14:25:35 +0100: > > > =20 > > > > On Thu, Dec 09, 2021 at 03:28:11PM +0100, Miquel Raynal wrote: = =20 > > > > > Hi Sean, > > > > >=20 > > > > > sean@geanix.com wrote on Thu, 9 Dec 2021 15:07:21 +0100: > > > > > =20 > > > > > > On Fri, Dec 03, 2021 at 02:39:58PM +0100, Miquel Raynal wrote: = =20 > > > > > > > Hello, > > > > > > > =20 > > > > > > > > > Fine by me, lets drop this series. =20 > > > > > > >=20 > > > > > > > FYI I've dropped the entire series from mtd/next. I'm waiting= for the > > > > > > > fix discussed below (without abusing the chip mutex ;-) ). = =20 > > > > > >=20 > > > > > > Cool, looking forward to test a patch series :) =20 > > > > >=20 > > > > > Test? You mean "write"? :) > > > > >=20 > > > > > Cheers, > > > > > Miqu=C3=A8l =20 > > > >=20 > > > > Hi Miquel, > > > >=20 > > > > Should we us a atomic for the suspended variable? =20 > > >=20 > > > I haven't thought about it extensively, an atomic variable sound fine > > > but I am definitely not a locking expert... =20 > >=20 > > No need to use an atomic if the variable is already protected by a lock > > when accessed, and this seems to be case. =20 >=20 > Maybe there was a confusion about this lock: I think Boris just do not > want the core to take any lock during a suspend operation. But you can > still use locks, as long as you release them before suspending. >=20 > And also, that chip lock might not be the one you want to take because > it's been introduced for another purpose. Access to the suspended field is already protected by the chip lock, and I think it's just fine to keep it this way.