From: Trevor Woerner <twoerner@gmail.com>
To: yocto@lists.yoctoproject.org
Subject: Re: [meta-rockchip][PATCH v2] override syntax fixup
Date: Mon, 13 Dec 2021 17:31:46 -0500 [thread overview]
Message-ID: <20211213223146.GB36849@localhost> (raw)
In-Reply-To: <20211211135543.15070-1-twoerner@gmail.com>
On Sat 2021-12-11 @ 08:55:43 AM, Trevor Woerner wrote:
> The _virtual notation is not an override. These syntax "fixes" need to be
> reverted.
>
> In the case of the kernel override, when it was added, the rock-pi-e needed
> the latest kernel (linux-yocto-dev) but now the default linux-yocto kernel
> will suffice. So this mistake actually switched the rock-pi-e from
> linux-yocto-dev back to linux-yocto inadvertently but at a time when
> linux-yocto-dev was no longer required.
>
> In the case of the bootloader overrides, u-boot was always the default, so
> these overrides were always redundant.
>
> Therefore, in the end, simply removing these overrides is the best way
> forward (considering these aren't doing anything, and the builds are working
> fine regardless).
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> conf/machine/include/rk3288.inc | 1 -
> conf/machine/include/rk3328.inc | 2 --
> conf/machine/include/rk3399.inc | 2 --
> conf/machine/include/rockchip-defaults.inc | 1 -
> conf/machine/rock-pi-e.conf | 2 --
> 5 files changed, 8 deletions(-)
Applied to meta-rockchip, master.
prev parent reply other threads:[~2021-12-13 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 13:55 [meta-rockchip][PATCH v2] override syntax fixup Trevor Woerner
2021-12-12 4:03 ` [yocto] " Khem Raj
2021-12-13 22:31 ` Trevor Woerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213223146.GB36849@localhost \
--to=twoerner@gmail.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.