From: Shawn Guo <shawn.guo@linaro.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND 0/5] Add QCM2290 interconnect support
Date: Wed, 15 Dec 2021 08:17:08 +0800 [thread overview]
Message-ID: <20211215001707.GA15936@dragon> (raw)
In-Reply-To: <0549abbb-9e75-70e9-399b-1b3f84dc5c20@kernel.org>
On Tue, Dec 14, 2021 at 01:24:37PM +0200, Georgi Djakov wrote:
> Hi Shawn,
>
> On 14.12.21 11:30, Shawn Guo wrote:
> > Changes for v3 resend:
> > - Rebase on linux-next
>
> Did you try compiling it? There is one more driver where we need to
> add the QoS type, otherwise I see this error:
>
> drivers/interconnect/qcom/msm8996.c:1884:3: error: ‘const struct
> qcom_icc_desc’ has no member named ‘is_bimc_node’
> 1884 | .is_bimc_node = true,
Oops! I did compile, but just noticed that INTERCONNECT_QCOM_MSM8996 was
not enabled in my defconfig. I will fix it with v4. Sorry about that,
and thanks for spotting the error, Georgi!
Shawn
prev parent reply other threads:[~2021-12-15 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 9:30 [PATCH v3 RESEND 0/5] Add QCM2290 interconnect support Shawn Guo
2021-12-14 9:30 ` [PATCH v3 RESEND 1/5] interconnect: icc-rpm: Define ICC device type Shawn Guo
2021-12-14 9:30 ` [PATCH v3 RESEND 2/5] interconnect: icc-rpm: Add QNOC type QoS support Shawn Guo
2021-12-14 9:30 ` [PATCH v3 RESEND 3/5] interconnect: icc-rpm: Support child NoC device probe Shawn Guo
2021-12-14 9:30 ` [PATCH v3 RESEND 4/5] dt-bindings: interconnect: Add Qualcomm QCM2290 NoC support Shawn Guo
2021-12-14 9:30 ` [PATCH v3 RESEND 5/5] interconnect: qcom: Add QCM2290 driver support Shawn Guo
2021-12-14 11:24 ` [PATCH v3 RESEND 0/5] Add QCM2290 interconnect support Georgi Djakov
2021-12-15 0:17 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215001707.GA15936@dragon \
--to=shawn.guo@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.