From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: [PATCH 5/6] i2c: designware-pci: use __maybe_unused for PM functions
Date: Wed, 15 Dec 2021 17:12:04 +0200 [thread overview]
Message-ID: <20211215151205.584264-5-jarkko.nikula@linux.intel.com> (raw)
In-Reply-To: <20211215151205.584264-1-jarkko.nikula@linux.intel.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Use __maybe_unused for PM functions instead of ifdeffery.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
Jarkko: In my opinion this was worth to take before cleanups so hand
edited to apply to currect code.
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index 021eee44fa3d..855ea666029f 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -213,8 +213,7 @@ static struct dw_pci_controller dw_pci_controllers[] = {
},
};
-#ifdef CONFIG_PM
-static int i2c_dw_pci_suspend(struct device *dev)
+static int __maybe_unused i2c_dw_pci_suspend(struct device *dev)
{
struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
@@ -224,7 +223,7 @@ static int i2c_dw_pci_suspend(struct device *dev)
return 0;
}
-static int i2c_dw_pci_resume(struct device *dev)
+static int __maybe_unused i2c_dw_pci_resume(struct device *dev)
{
struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
int ret;
@@ -234,7 +233,6 @@ static int i2c_dw_pci_resume(struct device *dev)
return ret;
}
-#endif
static UNIVERSAL_DEV_PM_OPS(i2c_dw_pm_ops, i2c_dw_pci_suspend,
i2c_dw_pci_resume, NULL);
--
2.34.1
next prev parent reply other threads:[~2021-12-15 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 15:12 [PATCH 1/6] i2c: designware: Do not complete i2c read without RX_FULL interrupt Jarkko Nikula
2021-12-15 15:12 ` [PATCH 2/6] i2c: designware-pci: Fix to change data types of hcnt and lcnt parameters Jarkko Nikula
2021-12-16 21:17 ` Wolfram Sang
2021-12-15 15:12 ` [PATCH 3/6] i2c: designware-pci: Add a note about struct dw_scl_sda_cfg usage Jarkko Nikula
2021-12-16 21:17 ` Wolfram Sang
2021-12-15 15:12 ` [PATCH 4/6] i2c: designware-pci: Group MODULE_*() macros Jarkko Nikula
2021-12-16 21:18 ` Wolfram Sang
2021-12-17 11:30 ` Andy Shevchenko
2021-12-15 15:12 ` Jarkko Nikula [this message]
2021-12-16 21:18 ` [PATCH 5/6] i2c: designware-pci: use __maybe_unused for PM functions Wolfram Sang
2021-12-15 15:12 ` [PATCH 6/6] i2c: designware-pci: Convert to use dev_err_probe() Jarkko Nikula
2021-12-16 21:18 ` Wolfram Sang
2021-12-16 21:17 ` [PATCH 1/6] i2c: designware: Do not complete i2c read without RX_FULL interrupt Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215151205.584264-5-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.