From: Stephen Boyd <sboyd@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 16/16] clk: qcom: gcc-msm8996: start getting rid of xo clk
Date: Wed, 15 Dec 2021 19:43:38 -0800 [thread overview]
Message-ID: <20211216034339.8815EC36AE0@smtp.kernel.org> (raw)
In-Reply-To: <20211215201153.orgyt6mlmxryrdpn@SoMainline.org>
Quoting Marijn Suijten (2021-12-15 12:11:53)
> On 2021-12-15 22:37:04, Dmitry Baryshkov wrote:
> > The "xo" fixed_factor clock is a leftover/hack from a time when we
> > couldn't make rpmhcc the root of all clocks. It is going to be removed
> > once all users of this clock are converted to use clocks specified
> > through the DTS. Replace internal usage of the xo clock with the cxo
> > (RPM_SMD_BB_CLK1) parent, specifying xo_board as a fallback.
>
> Nit: as mentioned in another reply I don't think rpmhcc is the sole
> problem why "xo" exists (xo_board exists to subustitute it for now).
> Rather, "xo" seems to be a remnant from an era where clock dependencies
> were not (fully) specified in DT but instead relied on fixed, well known
> global names for these inter-driver (inter-clock) dependencies. Maybe
> this alias was needed to streamline the use of xo_board until rpmcc
> could be used though?
A long time ago, in a company far, far away... oh wait that's not it.
I was trying to get by without the rpm clk driver. The idea to express
relationships between clk controllers in DT didn't really take off for
another few years.
Registering the xo_board clk from the GCC driver eased these problems by
letting us set the parent of the gcc clks to an intermediary "xo" that
we could replace with the rpm version of that whenever the rpm clk
driver existed. It was also supposed to be a drop in replacement for
when rpm wasn't enabled, but nobody does that so that idea sort of fell
away. See commit a085f877a882 ("clk: qcom: Move cxo/pxo/xo into dt
files") and how the parent is ee15faffef11 ("clk: qcom: common: Add API
to register board clocks backwards compatibly").
prev parent reply other threads:[~2021-12-16 3:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 19:36 [PATCH v3 00/16] clk: qcom: another round of clock drivers cleanup Dmitry Baryshkov
2021-12-15 19:36 ` [PATCH v3 01/16] clk: qcom: gpucc-sdm660: fix two clocks with parent_names Dmitry Baryshkov
2021-12-16 1:52 ` Stephen Boyd
2021-12-15 19:36 ` [PATCH v3 02/16] clk: qcom: gpucc-sdm660: get rid of the test clock Dmitry Baryshkov
2021-12-15 19:36 ` [PATCH v3 03/16] clk: qcom: gpucc-sdm660: use parent_hws instead of parent_data Dmitry Baryshkov
2021-12-15 19:36 ` [PATCH v3 04/16] clk: qcom: camcc-sc7180: use ARRAY_SIZE instead of specifying num_parents Dmitry Baryshkov
2021-12-16 1:52 ` Stephen Boyd
2021-12-15 19:36 ` [PATCH v3 05/16] clk: qcom: camcc-sc7180: get rid of the test clock Dmitry Baryshkov
2021-12-15 19:36 ` [PATCH v3 06/16] clk: qcom: camcc-sc7180: use parent_hws instead of parent_data Dmitry Baryshkov
2021-12-15 19:36 ` [PATCH v3 07/16] clk: qcom: camcc-sdm845: use ARRAY_SIZE instead of specifying num_parents Dmitry Baryshkov
2021-12-15 19:36 ` [PATCH v3 08/16] clk: qcom: camcc-sdm845: get rid of the test clock Dmitry Baryshkov
2021-12-15 19:36 ` [PATCH v3 09/16] clk: qcom: camcc-sdm845: move clock parent tables down Dmitry Baryshkov
2021-12-15 20:24 ` Marijn Suijten
2021-12-16 1:57 ` Stephen Boyd
2021-12-15 19:36 ` [PATCH v3 10/16] clk: qcom: camcc-sdm845: convert to parent_hws/_data Dmitry Baryshkov
2021-12-16 1:58 ` Stephen Boyd
2021-12-15 19:36 ` [PATCH v3 11/16] clk: qcom: videocc-sc7180: use parent_hws instead of parent_data Dmitry Baryshkov
2021-12-15 19:37 ` [PATCH v3 12/16] clk: qcom: gcc-msm8996: use ARRAY_SIZE instead of specifying num_parents Dmitry Baryshkov
2021-12-15 19:37 ` [PATCH v3 13/16] clk: qcom: gcc-msm8996: drop unsupported clock sources Dmitry Baryshkov
2021-12-15 19:37 ` [PATCH v3 14/16] clk: qcom: gcc-msm8996: move clock parent tables down Dmitry Baryshkov
2021-12-15 19:37 ` [PATCH v3 15/16] clk: qcom: gcc-msm8996: use parent_hws/_data instead of parent_names Dmitry Baryshkov
2021-12-15 20:19 ` Marijn Suijten
2021-12-15 19:37 ` [PATCH v3 16/16] clk: qcom: gcc-msm8996: start getting rid of xo clk Dmitry Baryshkov
2021-12-15 20:11 ` Marijn Suijten
2021-12-16 3:43 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216034339.8815EC36AE0@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.