From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD7BC433FE for ; Thu, 16 Dec 2021 06:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234190AbhLPGp5 (ORCPT ); Thu, 16 Dec 2021 01:45:57 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:33726 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230062AbhLPGp5 (ORCPT ); Thu, 16 Dec 2021 01:45:57 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A55C61C4A; Thu, 16 Dec 2021 06:45:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50385C36AE2; Thu, 16 Dec 2021 06:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639637156; bh=DAHiQZ/A9fSoAedgWlGLb4HM/aUKVwB/P8OFL5cQTpE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=uzi1gsDjoSzvtQLPxTsFIOiMBj4s//5SeulcHvdqPHR9atceMdIJLt8sxPvBf24j1 VLfOnw13I3CdNY9dT47QSX8zknqH0AEosCTpB7XAeVB5+XRMjtbRZZb4oS0vBml4U2 2SzgVz0cm4QtDnDQliCeTk8oB3cNq27VqNilQCXwbYEAfCDrbDdqnZGqzhLH9COBhc yjTzT8VMeUQHyzu6wjpc6BMSga04o+zs/1+dlqNs67kMyByakhDU/y5bXCUx1uwhNn DbCXaobSA9y81til1dzqnK76XTqlp2hO6fz9q+BTjADqpPfOXsffUpX3238d/H8sTc qsHS6pzIfOhZQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1635232282-3992-10-git-send-email-dillon.minfei@gmail.com> References: <1635232282-3992-1-git-send-email-dillon.minfei@gmail.com> <1635232282-3992-10-git-send-email-dillon.minfei@gmail.com> Subject: Re: [PATCH v7 09/10] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell From: Stephen Boyd Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, lkp@intel.com, kbuild-all@lists.01.org, llvm@lists.linux.dev To: Dillon Min , alexandre.torgue@foss.st.com, ezequiel@collabora.com, gabriel.fernandez@foss.st.com, gabriel.fernandez@st.com, gnurou@gmail.com, hverkuil-cisco@xs4all.nl, mchehab+huawei@kernel.org, mchehab@kernel.org, mcoquelin.stm32@gmail.com, mturquette@baylibre.com, pihsun@chromium.org, robh+dt@kernel.org Date: Wed, 15 Dec 2021 22:45:55 -0800 User-Agent: alot/0.9.1 Message-Id: <20211216064556.50385C36AE2@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Dillon Min (2021-10-26 00:11:21) > stm32's clk driver register two ltdc gate clk to clk core by > clk_hw_register_gate() and clk_hw_register_composite() >=20 > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver >=20 > both of them point to the same offset of stm32's RCC register. after > kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' > is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. >=20 > stm32f469/746/769 have the same issue, fix it. >=20 > Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") > Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-sen= d-email-dillon.minfei@gmail.com/ > Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDU= jqFFwkOeQeFDg@mail.gmail.com/ > Signed-off-by: Dillon Min > Reviewed-by: Patrice Chotard > Acked-by: Gabriel Fernandez > Acked-by: Stephen Boyd > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06776C433EF for ; Thu, 16 Dec 2021 06:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gy//AobF3NwXpLzLOtRCOy+yEpmelTgZhv7M1K4cbNs=; b=vLUmngJdC5uVQC QxaIg9twHOaxaxLY9LWhyZODeAdT9qTT99yGTI9V3uRwzRq2MXC9D4GhWZmd7to08cXbL1Ql1BYsA UrY92nY7jND2taRRE83AvZwygqphuknzWM/Za2w+Wf8XNzeMPiSkH1OmbGX5fGxu1wmwhLvvP64Mh q071IXV4SkxRxdjv5/RA5RjJIMsDjYt3ZV8yyEzoKPqF0/Bjk+0Sfb3V4LOf0NqZBRW1Bb2uKadim KHk5J4vQtzAOX+Jq/4XXYcn4t48JzJwcUeRn0k4RKBXhbrD/OmgFCGGwoP+z+BZ/bYWPKRa2+DCuJ sbvdIK5ZK7qMWz1qlJcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxkWj-003o1J-DA; Thu, 16 Dec 2021 06:46:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxkWd-003nys-MM for linux-arm-kernel@lists.infradead.org; Thu, 16 Dec 2021 06:46:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC11A61C0A; Thu, 16 Dec 2021 06:45:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50385C36AE2; Thu, 16 Dec 2021 06:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639637156; bh=DAHiQZ/A9fSoAedgWlGLb4HM/aUKVwB/P8OFL5cQTpE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=uzi1gsDjoSzvtQLPxTsFIOiMBj4s//5SeulcHvdqPHR9atceMdIJLt8sxPvBf24j1 VLfOnw13I3CdNY9dT47QSX8zknqH0AEosCTpB7XAeVB5+XRMjtbRZZb4oS0vBml4U2 2SzgVz0cm4QtDnDQliCeTk8oB3cNq27VqNilQCXwbYEAfCDrbDdqnZGqzhLH9COBhc yjTzT8VMeUQHyzu6wjpc6BMSga04o+zs/1+dlqNs67kMyByakhDU/y5bXCUx1uwhNn DbCXaobSA9y81til1dzqnK76XTqlp2hO6fz9q+BTjADqpPfOXsffUpX3238d/H8sTc qsHS6pzIfOhZQ== MIME-Version: 1.0 In-Reply-To: <1635232282-3992-10-git-send-email-dillon.minfei@gmail.com> References: <1635232282-3992-1-git-send-email-dillon.minfei@gmail.com> <1635232282-3992-10-git-send-email-dillon.minfei@gmail.com> Subject: Re: [PATCH v7 09/10] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell From: Stephen Boyd Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, lkp@intel.com, kbuild-all@lists.01.org, llvm@lists.linux.dev To: Dillon Min , alexandre.torgue@foss.st.com, ezequiel@collabora.com, gabriel.fernandez@foss.st.com, gabriel.fernandez@st.com, gnurou@gmail.com, hverkuil-cisco@xs4all.nl, mchehab+huawei@kernel.org, mchehab@kernel.org, mcoquelin.stm32@gmail.com, mturquette@baylibre.com, pihsun@chromium.org, robh+dt@kernel.org Date: Wed, 15 Dec 2021 22:45:55 -0800 User-Agent: alot/0.9.1 Message-Id: <20211216064556.50385C36AE2@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_224559_778237_330E9B34 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Dillon Min (2021-10-26 00:11:21) > stm32's clk driver register two ltdc gate clk to clk core by > clk_hw_register_gate() and clk_hw_register_composite() > > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver > > both of them point to the same offset of stm32's RCC register. after > kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' > is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. > > stm32f469/746/769 have the same issue, fix it. > > Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") > Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/ > Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDUjqFFwkOeQeFDg@mail.gmail.com/ > Signed-off-by: Dillon Min > Reviewed-by: Patrice Chotard > Acked-by: Gabriel Fernandez > Acked-by: Stephen Boyd > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7316192393557355179==" MIME-Version: 1.0 From: Stephen Boyd To: kbuild-all@lists.01.org Subject: Re: [PATCH v7 09/10] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell Date: Wed, 15 Dec 2021 22:45:55 -0800 Message-ID: <20211216064556.50385C36AE2@smtp.kernel.org> In-Reply-To: <1635232282-3992-10-git-send-email-dillon.minfei@gmail.com> List-Id: --===============7316192393557355179== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Quoting Dillon Min (2021-10-26 00:11:21) > stm32's clk driver register two ltdc gate clk to clk core by > clk_hw_register_gate() and clk_hw_register_composite() > = > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver > = > both of them point to the same offset of stm32's RCC register. after > kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' > is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. > = > stm32f469/746/769 have the same issue, fix it. > = > Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") > Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-sen= d-email-dillon.minfei(a)gmail.com/ > Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDU= jqFFwkOeQeFDg(a)mail.gmail.com/ > Signed-off-by: Dillon Min > Reviewed-by: Patrice Chotard > Acked-by: Gabriel Fernandez > Acked-by: Stephen Boyd > --- Applied to clk-next --===============7316192393557355179==--