Re: [PATCH 1/2] patchwork-bot: Ignore empty context lines

[Kees Cook <keescook@chromium.org>]

On Thu, Dec 02, 2021 at 03:38:35PM -0800, Kees Cook wrote:
> It seems that there is some mismatch in diff output (or storage?) between
> git and patchwork under conditions I haven't figured out (MUA or MTA
> whitespace stripping?): patchwork appears to ignore empty context lines
> (i.e. a line that is only a single space). As a result, the patchwork
> hash will not match, and commits will not be identified in patchwork.
> 
> As an example of a commit in upstream that patchwork-bot cannot locate
> in patchwork due to a different hash, due to the differing empty context
> lines:
> 
> $ MSGID=20210911102818.3804-1-len.baker@gmx.com
> $ wget -qO- https://patchwork.kernel.org/project/linux-hardening/patch/$MSGID/raw/ | \
> 	grep '^ $' | wc -l
> 0
> 
> $ SHA=f11ee2ad25b22c2ee587045dd6999434375532f7
> $ git diff ${SHA}~..${SHA} | \
> 	grep '^ $' | wc -l
> 2
> 
> Teaching patchwork-bot to ignore empty context lines allows pwhashes to
> match in these cases, which lets those patches get located again.

With regard to the revert, do you not see the above problem with your
repos? I'm working against the same patchwork. I guess there is some
other root cause?

-- 
Kees Cook