All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: devicetree@vger.kernel.org
Cc: dinguyen@kernel.org, robh+dt@kernel.org, p.yadav@ti.com
Subject: [PATCHv3 0/2] arm: dts: socfpga: introduce "intel,socfpga-qspi"
Date: Thu, 16 Dec 2021 16:49:00 -0600	[thread overview]
Message-ID: <20211216224902.374403-1-dinguyen@kernel.org> (raw)

Introduce "intel,socfpga-qspi" as the compatible for the Cadence QSPI
controller that is on all flavors of SoCFPGA devices:

Cyclone5/Arria5/Arria10/Stratix10/Agilex/N5X

The reason for this change is because the standard driver recently
introduced a patch to write to the CQSPI_REG_WR_COMPLETION_CTRL without
any condition. But the QSPI controller that is on the SoCFPGA platforms
does not implement the CQSPI_REG_WR_COMPLETION_CTRL register, thus a
write to this register, results in a kernel crash.

I don't believe we need a chip specific compatible for each chip because
the MODULE_ID for all flavors of SoCFPGA is identical. Thus, I think the
"intel,socfpga-qspi" compatible is appropriate to cover all variants of
the SoCFPGA platform.

Dinh Nguyen (2):
  dt-bindings: spi: cadence-quadspi: document "intel,socfpga-qspi"
  ARM: dts: socfpga: change qspi to "intel,socfpga-qspi"

 Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 1 +
 arch/arm/boot/dts/socfpga.dtsi                           | 2 +-
 arch/arm/boot/dts/socfpga_arria10.dtsi                   | 2 +-
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi        | 2 +-
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi            | 2 +-
 5 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.25.1


             reply	other threads:[~2021-12-16 22:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 22:49 Dinh Nguyen [this message]
2021-12-16 22:49 ` [PATCHv3 1/2] dt-bindings: spi: cadence-quadspi: document "intel,socfpga-qspi" Dinh Nguyen
2021-12-17  3:47   ` Rob Herring
2021-12-17  8:52   ` Pratyush Yadav
2021-12-21 17:05   ` Rob Herring
2021-12-16 22:49 ` [PATCHv3 2/2] ARM: dts: socfpga: change qspi to "intel,socfpga-qspi" Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211216224902.374403-1-dinguyen@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=p.yadav@ti.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.