From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH 17/17] fortify: Work around Clang inlining bugs
Date: Thu, 16 Dec 2021 23:37:54 +0800 [thread overview]
Message-ID: <202112162317.HYiDRObX-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 18196 bytes --]
CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20211213223331.135412-18-keescook@chromium.org>
References: <20211213223331.135412-18-keescook@chromium.org>
TO: Kees Cook <keescook@chromium.org>
Hi Kees,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc5]
[cannot apply to rdma/for-next axboe-block/for-next kvm/queue tip/x86/core mkp-scsi/for-next jejb-scsi/for-next next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kees-Cook/Enable-strict-compile-time-memcpy-fortify-checks/20211214-064002
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git aa50faff4416c869b52dff68a937c84d29e12f4b
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-c007-20211215 (https://download.01.org/0day-ci/archive/20211216/202112162317.HYiDRObX-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dd245bab9fbb364faa1581e4f92ba3119a872fba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e5d600e1abbdd2034dbc844654957a4ec1182dbf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kees-Cook/Enable-strict-compile-time-memcpy-fortify-checks/20211214-064002
git checkout e5d600e1abbdd2034dbc844654957a4ec1182dbf
# save the config file to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
^
fs/jfs/jfs_logmgr.c:892:8: note: Assuming field 'gcrtc' is > 0
((log->gcrtc > 0) || (tblk->bp->l_wqnext != NULL) ||
^~~~~~~~~~~~~~
fs/jfs/jfs_logmgr.c:892:24: note: Left side of '||' is true
((log->gcrtc > 0) || (tblk->bp->l_wqnext != NULL) ||
^
fs/jfs/jfs_logmgr.c:897:3: note: Calling 'lmGCwrite'
lmGCwrite(log, 1);
^~~~~~~~~~~~~~~~~
fs/jfs/jfs_logmgr.c:751:2: note: 'xtblk' initialized to a null pointer value
struct tblock *xtblk = NULL;
^~~~~~~~~~~~~~~~~~~~
fs/jfs/jfs_logmgr.c:762:2: note: Loop condition is false. Execution continues on line 771
list_for_each_entry(tblk, &log->cqueue, cqueue) {
^
include/linux/list.h:630:2: note: expanded from macro 'list_for_each_entry'
for (pos = list_first_entry(head, typeof(*pos), member); \
^
fs/jfs/jfs_logmgr.c:771:2: note: Null pointer value stored to 'tblk'
tblk = xtblk; /* last tblk of the page */
^~~~~~~~~~~~
fs/jfs/jfs_logmgr.c:776:23: note: Access to field 'bp' results in a dereference of a null pointer (loaded from variable 'tblk')
bp = (struct lbuf *) tblk->bp;
^~~~
fs/jfs/jfs_logmgr.c:1346:3: warning: Value stored to 'lp' is never read [clang-analyzer-deadcode.DeadStores]
lp = (struct logpage *) bp->l_ldata;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/jfs/jfs_logmgr.c:1346:3: note: Value stored to 'lp' is never read
lp = (struct logpage *) bp->l_ldata;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings generated.
Suppressed 3 warnings (3 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
11 warnings generated.
fs/dlm/config.c:723:4: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
strcat(buf, buf0);
^~~~~~
fs/dlm/config.c:723:4: note: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119
strcat(buf, buf0);
^~~~~~
>> include/linux/fortify-string.h:137:3: warning: Null pointer passed as 1st argument to memory copy function [clang-analyzer-unix.cstring.NullArg]
__underlying_memcpy(p, q, len);
^
include/linux/fortify-string.h:43:29: note: expanded from macro '__underlying_memcpy'
#define __underlying_memcpy __builtin_memcpy
^
fs/dlm/config.c:125:10: note: Passing null pointer value via 1st parameter 'p'
strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name));
^
include/linux/fortify-string.h:114:44: note: expanded from macro 'strlcpy'
#define strlcpy(p, q, s) __fortify_strlcpy(p, q, s, \
^
fs/dlm/config.c:125:2: note: Calling '__fortify_strlcpy'
strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name));
^
include/linux/fortify-string.h:114:26: note: expanded from macro 'strlcpy'
#define strlcpy(p, q, s) __fortify_strlcpy(p, q, s, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fortify-string.h:125:27: note: Left side of '&&' is false
if (p_size == (size_t)-1 && q_size == (size_t)-1)
^
include/linux/fortify-string.h:128:9: note: 'q_len' is >= 'size'
len = (q_len >= size) ? size - 1 : q_len;
^~~~~
include/linux/fortify-string.h:128:8: note: '?' condition is true
len = (q_len >= size) ? size - 1 : q_len;
^
include/linux/fortify-string.h:129:33: note: Left side of '&&' is false
if (__builtin_constant_p(size) && __builtin_constant_p(q_len) && size) {
^
include/linux/fortify-string.h:134:6: note: 'size' is 64
if (size) {
^~~~
include/linux/fortify-string.h:134:2: note: Taking true branch
if (size) {
^
include/linux/fortify-string.h:135:7: note: 'len' is < 'p_size'
if (len >= p_size)
^~~
include/linux/fortify-string.h:135:3: note: Taking false branch
if (len >= p_size)
^
include/linux/fortify-string.h:137:3: note: Null pointer passed as 1st argument to memory copy function
__underlying_memcpy(p, q, len);
^ ~
include/linux/fortify-string.h:43:29: note: expanded from macro '__underlying_memcpy'
#define __underlying_memcpy __builtin_memcpy
^
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (4 in non-user code, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (6 in non-user code, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
fs/ntfs/inode.c:1840:3: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]
err = -ENOMEM;
^ ~~~~~~~
fs/ntfs/inode.c:1840:3: note: Value stored to 'err' is never read
err = -ENOMEM;
^ ~~~~~~~
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
vim +137 include/linux/fortify-string.h
a28a6e860c6cf2 Francis Laniel 2021-02-25 111
a28a6e860c6cf2 Francis Laniel 2021-02-25 112 /* defined after fortified strlen to reuse it */
a28a6e860c6cf2 Francis Laniel 2021-02-25 113 extern size_t __real_strlcpy(char *, const char *, size_t) __RENAME(strlcpy);
e5d600e1abbdd2 Kees Cook 2021-12-13 114 #define strlcpy(p, q, s) __fortify_strlcpy(p, q, s, \
e5d600e1abbdd2 Kees Cook 2021-12-13 115 __builtin_object_size(p, 1), \
e5d600e1abbdd2 Kees Cook 2021-12-13 116 __builtin_object_size(q, 1))
e5d600e1abbdd2 Kees Cook 2021-12-13 117 __FORTIFY_INLINE size_t __fortify_strlcpy(char *p, const char *q,
e5d600e1abbdd2 Kees Cook 2021-12-13 118 size_t size,
e5d600e1abbdd2 Kees Cook 2021-12-13 119 const size_t p_size,
e5d600e1abbdd2 Kees Cook 2021-12-13 120 const size_t q_size)
a28a6e860c6cf2 Francis Laniel 2021-02-25 121 {
3009f891bb9f32 Kees Cook 2021-08-02 122 size_t q_len; /* Full count of source string length. */
3009f891bb9f32 Kees Cook 2021-08-02 123 size_t len; /* Count of characters going into destination. */
a28a6e860c6cf2 Francis Laniel 2021-02-25 124
a28a6e860c6cf2 Francis Laniel 2021-02-25 125 if (p_size == (size_t)-1 && q_size == (size_t)-1)
a28a6e860c6cf2 Francis Laniel 2021-02-25 126 return __real_strlcpy(p, q, size);
3009f891bb9f32 Kees Cook 2021-08-02 127 q_len = strlen(q);
3009f891bb9f32 Kees Cook 2021-08-02 128 len = (q_len >= size) ? size - 1 : q_len;
3009f891bb9f32 Kees Cook 2021-08-02 129 if (__builtin_constant_p(size) && __builtin_constant_p(q_len) && size) {
3009f891bb9f32 Kees Cook 2021-08-02 130 /* Write size is always larger than destination. */
3009f891bb9f32 Kees Cook 2021-08-02 131 if (len >= p_size)
a28a6e860c6cf2 Francis Laniel 2021-02-25 132 __write_overflow();
3009f891bb9f32 Kees Cook 2021-08-02 133 }
3009f891bb9f32 Kees Cook 2021-08-02 134 if (size) {
a28a6e860c6cf2 Francis Laniel 2021-02-25 135 if (len >= p_size)
a28a6e860c6cf2 Francis Laniel 2021-02-25 136 fortify_panic(__func__);
a28a6e860c6cf2 Francis Laniel 2021-02-25 @137 __underlying_memcpy(p, q, len);
a28a6e860c6cf2 Francis Laniel 2021-02-25 138 p[len] = '\0';
a28a6e860c6cf2 Francis Laniel 2021-02-25 139 }
3009f891bb9f32 Kees Cook 2021-08-02 140 return q_len;
a28a6e860c6cf2 Francis Laniel 2021-02-25 141 }
a28a6e860c6cf2 Francis Laniel 2021-02-25 142
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2021-12-16 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 15:37 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-15 3:25 [PATCH 17/17] fortify: Work around Clang inlining bugs kernel test robot
2021-12-15 3:25 kernel test robot
2021-12-13 22:33 [PATCH 00/17] Enable strict compile-time memcpy() fortify checks Kees Cook
2021-12-13 22:33 ` [PATCH 17/17] fortify: Work around Clang inlining bugs Kees Cook
2021-12-14 13:22 ` kernel test robot
2021-12-14 13:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112162317.HYiDRObX-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.