From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/vdpa/vdpa_user/iova_domain.c:305 vduse_domain_alloc_iova() warn: should 'iova_pfn << shift' be a 64 bit type?
Date: Fri, 17 Dec 2021 02:11:01 +0800 [thread overview]
Message-ID: <202112170217.0LXGLvEY-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3102 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Xie Yongji <xieyongji@bytedance.com>
CC: "Michael S. Tsirkin" <mst@redhat.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2b14864acbaaf03d9c01982e243a84632524c3ac
commit: c8a6153b6c59d95c0e091f053f6f180952ade91e vduse: Introduce VDUSE - vDPA Device in Userspace
date: 3 months ago
:::::: branch date: 23 hours ago
:::::: commit date: 3 months ago
config: i386-randconfig-m021-20211216 (https://download.01.org/0day-ci/archive/20211217/202112170217.0LXGLvEY-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/vdpa/vdpa_user/iova_domain.c:305 vduse_domain_alloc_iova() warn: should 'iova_pfn << shift' be a 64 bit type?
vim +305 drivers/vdpa/vdpa_user/iova_domain.c
8c773d53fb7b642 Xie Yongji 2021-08-31 286
8c773d53fb7b642 Xie Yongji 2021-08-31 287 static dma_addr_t
8c773d53fb7b642 Xie Yongji 2021-08-31 288 vduse_domain_alloc_iova(struct iova_domain *iovad,
8c773d53fb7b642 Xie Yongji 2021-08-31 289 unsigned long size, unsigned long limit)
8c773d53fb7b642 Xie Yongji 2021-08-31 290 {
8c773d53fb7b642 Xie Yongji 2021-08-31 291 unsigned long shift = iova_shift(iovad);
8c773d53fb7b642 Xie Yongji 2021-08-31 292 unsigned long iova_len = iova_align(iovad, size) >> shift;
8c773d53fb7b642 Xie Yongji 2021-08-31 293 unsigned long iova_pfn;
8c773d53fb7b642 Xie Yongji 2021-08-31 294
8c773d53fb7b642 Xie Yongji 2021-08-31 295 /*
8c773d53fb7b642 Xie Yongji 2021-08-31 296 * Freeing non-power-of-two-sized allocations back into the IOVA caches
8c773d53fb7b642 Xie Yongji 2021-08-31 297 * will come back to bite us badly, so we have to waste a bit of space
8c773d53fb7b642 Xie Yongji 2021-08-31 298 * rounding up anything cacheable to make sure that can't happen. The
8c773d53fb7b642 Xie Yongji 2021-08-31 299 * order of the unadjusted size will still match upon freeing.
8c773d53fb7b642 Xie Yongji 2021-08-31 300 */
8c773d53fb7b642 Xie Yongji 2021-08-31 301 if (iova_len < (1 << (IOVA_RANGE_CACHE_MAX_SIZE - 1)))
8c773d53fb7b642 Xie Yongji 2021-08-31 302 iova_len = roundup_pow_of_two(iova_len);
8c773d53fb7b642 Xie Yongji 2021-08-31 303 iova_pfn = alloc_iova_fast(iovad, iova_len, limit >> shift, true);
8c773d53fb7b642 Xie Yongji 2021-08-31 304
8c773d53fb7b642 Xie Yongji 2021-08-31 @305 return iova_pfn << shift;
8c773d53fb7b642 Xie Yongji 2021-08-31 306 }
8c773d53fb7b642 Xie Yongji 2021-08-31 307
:::::: The code@line 305 was first introduced by commit
:::::: 8c773d53fb7b64267b0f55c1d3517cb8c5e29b3c vduse: Implement an MMU-based software IOTLB
:::::: TO: Xie Yongji <xieyongji@bytedance.com>
:::::: CC: Michael S. Tsirkin <mst@redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2021-12-16 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 18:11 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-17 6:13 drivers/vdpa/vdpa_user/iova_domain.c:305 vduse_domain_alloc_iova() warn: should 'iova_pfn << shift' be a 64 bit type? kernel test robot
2022-01-19 4:44 ` Dan Carpenter
2022-01-19 4:44 ` Dan Carpenter
2022-01-19 5:20 ` Yongji Xie
2022-01-19 5:20 ` Yongji Xie
2021-11-19 5:13 kernel test robot
2021-11-14 7:22 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112170217.0LXGLvEY-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.