From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05B54C433EF for ; Sat, 18 Dec 2021 22:42:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 55F088304A; Sat, 18 Dec 2021 23:41:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id AE062830BE; Sat, 18 Dec 2021 23:41:55 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F421F8306E for ; Sat, 18 Dec 2021 23:41:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id 13A291409F4; Sat, 18 Dec 2021 23:41:52 +0100 (CET) Date: Sat, 18 Dec 2021 23:41:50 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese Cc: u-boot@lists.denx.de, Heiko Schocher , Samuel Holland , Baruch Siach , Pali =?UTF-8?B?Um9ow6Fy?= Subject: Re: [PATCH] i2c: mvtwsi: Swab the register address if its size is > 1 Message-ID: <20211218234150.7d21f2aa@thinkpad> In-Reply-To: <3542e49a-aedf-406c-8927-a47fff172f92@denx.de> References: <20211118081841.861158-1-sr@denx.de> <3542e49a-aedf-406c-8927-a47fff172f92@denx.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, 18 Dec 2021 14:42:51 +0100 Stefan Roese wrote: > Hi Heiko, >=20 > On 11/18/21 09:18, Stefan Roese wrote: > > Testing on Armada XP with an EEPROM using register address with size > > of 2 has shown, that the register address bytes are sent to the I2C > > EEPROM in the incorrect order. This patch swabs the address bytes so > > that the correct address is transferred to the I2C device. > >=20 > > BTW: This worked without any issues before migrating Armada XP to > > DM I2C. > >=20 > > Signed-off-by: Stefan Roese > > Cc: Heiko Schocher > > Cc: Samuel Holland > > Cc: Baruch Siach > > Cc: Pali Roh=C3=A1r > > Cc: Marek Beh=C3=BAn > > --- > > It would be good if other users of this I2C driver could test this chan= ge > > with e.g. I2C EEPROM devices using 2 bytes (or more) for addressing. =20 >=20 > Could you and other please take a look at this? Would be great, if this > could be pulled in the next merge window. Tested-by: Marek Beh=C3=BAn