From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8858937815151670913==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [RFC v5 net-next 01/13] mfd: ocelot: add support for external mfd control over SPI for the VSC7512 Date: Sun, 19 Dec 2021 09:55:13 +0800 Message-ID: <202112190908.GDAHmtPe-lkp@intel.com> In-Reply-To: <20211218214954.109755-2-colin.foster@in-advantage.com> List-Id: --===============8858937815151670913== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Colin, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on next-20211217] [also build test WARNING on v5.16-rc5] [cannot apply to net-next/master lee-mfd/for-mfd-next linusw-pinctrl/devel = net/master horms-ipvs/master linus/master v5.16-rc5 v5.16-rc4 v5.16-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Colin-Foster/add-support-f= or-VSC75XX-control-over-SPI/20211219-055252 base: c122052c3cb861b3e61a01d2c2ab9069e470663e config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20211219= /202112190908.GDAHmtPe-lkp(a)intel.com/config) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ec7f2a8290ac0b1f74a64884f= 16444c56edb274f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Colin-Foster/add-support-for-VSC75= XX-control-over-SPI/20211219-055252 git checkout ec7f2a8290ac0b1f74a64884f16444c56edb274f # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dm68k SHELL=3D/bin/bash drivers/mfd/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/mfd/ocelot-spi.c: In function 'ocelot_spi_reg_read': >> drivers/mfd/ocelot-spi.c:124:28: warning: variable 'ocelot_spi' set but = not used [-Wunused-but-set-variable] 124 | struct ocelot_spi *ocelot_spi; | ^~~~~~~~~~ vim +/ocelot_spi +124 drivers/mfd/ocelot-spi.c 118 = 119 static int ocelot_spi_reg_read(void *context, unsigned int reg, 120 unsigned int *val) 121 { 122 struct ocelot_spi_regmap_context *regmap_context =3D context; 123 struct spi_transfer tx, padding, rx; > 124 struct ocelot_spi *ocelot_spi; 125 struct spi_message msg; 126 struct spi_device *spi; 127 unsigned int addr; 128 u8 *tx_buf; 129 = 130 WARN_ON(!val); 131 = 132 spi =3D regmap_context->spi; 133 = 134 ocelot_spi =3D spi_get_drvdata(spi); 135 = 136 addr =3D ocelot_spi_translate_address(reg + regmap_context->base); 137 tx_buf =3D (u8 *)&addr; 138 = 139 spi_message_init(&msg); 140 = 141 memset(&tx, 0, sizeof(struct spi_transfer)); 142 = 143 /* Ignore the first byte for the 24-bit address */ 144 tx.tx_buf =3D &tx_buf[1]; 145 tx.len =3D 3; 146 = 147 spi_message_add_tail(&tx, &msg); 148 = 149 if (regmap_context->padding_bytes > 0) { 150 u8 dummy_buf[16] =3D {0}; 151 = 152 memset(&padding, 0, sizeof(struct spi_transfer)); 153 = 154 /* Just toggle the clock for padding bytes */ 155 padding.len =3D regmap_context->padding_bytes; 156 padding.tx_buf =3D dummy_buf; 157 padding.dummy_data =3D 1; 158 = 159 spi_message_add_tail(&padding, &msg); 160 } 161 = 162 memset(&rx, 0, sizeof(struct spi_transfer)); 163 rx.rx_buf =3D val; 164 rx.len =3D 4; 165 = 166 spi_message_add_tail(&rx, &msg); 167 = 168 return spi_sync(spi, &msg); 169 } 170 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8858937815151670913==--