From: Marten Lindahl <martenli@axis.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Jaehoon Chung" <jh80.chung@samsung.com>,
"Mårten Lindahl" <Marten.Lindahl@axis.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: clean up a debug message
Date: Mon, 20 Dec 2021 11:40:02 +0100 [thread overview]
Message-ID: <20211220104002.GA8585@axis.com> (raw)
In-Reply-To: <20211217150348.GD16611@kili>
On Fri, Dec 17, 2021 at 04:03:48PM +0100, Dan Carpenter wrote:
> The "0x" prefix is redundant when # flag is used. It prints "0x0x".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index f2a14a434bef..bec4796283fe 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host,
> tmout |= (tmp & 0xFFFFFF) << 8;
>
> mci_writel(host, TMOUT, tmout);
> - dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x",
> + dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x",
> timeout_ns, tmout >> 8);
> }
>
> --
> 2.20.1
>
Reviewed-by: Mårten Lindahl <marten.lindahl@axis.com>
Kind regards
Mårten
next prev parent reply other threads:[~2021-12-20 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:03 [PATCH] mmc: dw_mmc: clean up a debug message Dan Carpenter
2021-12-20 10:40 ` Marten Lindahl [this message]
2021-12-21 13:03 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211220104002.GA8585@axis.com \
--to=martenli@axis.com \
--cc=Marten.Lindahl@axis.com \
--cc=dan.carpenter@oracle.com \
--cc=jh80.chung@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.