From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5097659981574805971==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 16/23] wilc1000: switch tx queue to normal sk_buff entries Date: Mon, 20 Dec 2021 21:20:30 +0800 Message-ID: <202112202132.4ZJla6Ch-lkp@intel.com> In-Reply-To: <20211218235404.3963475-17-davidm@egauge.net> List-Id: --===============5097659981574805971== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvalo-wireless-drivers-next/master] [also build test WARNING on kvalo-wireless-drivers/master v5.16-rc6 next-20= 211217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/David-Mosberger-Tang/wilc1= 000-rework-tx-path-to-use-sk_buffs-throughout/20211219-075737 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-driv= ers-next.git master config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/2021122= 0/202112202132.4ZJla6Ch-lkp(a)intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e545dfdbd5420a8342c3a3bda= 03b6c9e7e108b7c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review David-Mosberger-Tang/wilc1000-rewo= rk-tx-path-to-use-sk_buffs-throughout/20211219-075737 git checkout e545dfdbd5420a8342c3a3bda03b6c9e7e108b7c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dalpha SHELL=3D/bin/bash drivers/net/wireless/microchi= p/wilc1000/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/wireless/microchip/wilc1000/wlan.c: In function 'wilc_wlan_c= fg_apply_wid': >> drivers/net/wireless/microchip/wilc1000/wlan.c:1243:63: warning: passing= argument 1 of 'wilc_wlan_cfg_set_wid' makes pointer from integer without a= cast [-Wint-conversion] 1243 | ret_size =3D wilc_wlan_cfg_set_wid(wilc->cfg_skb= ->tail, 0, | ~~~~~~~~~~~~~^~= ~~~~ | | | sk= _buff_data_t {aka unsigned int} In file included from drivers/net/wireless/microchip/wilc1000/netdev.h:1= 9, from drivers/net/wireless/microchip/wilc1000/cfg80211.h= :9, from drivers/net/wireless/microchip/wilc1000/wlan.c:10: drivers/net/wireless/microchip/wilc1000/wlan_cfg.h:45:31: note: expected= 'u8 *' {aka 'unsigned char *'} but argument is of type 'sk_buff_data_t' {a= ka 'unsigned int'} 45 | int wilc_wlan_cfg_set_wid(u8 *frame, u32 offset, u16 id, u8 *buf= , int size); | ~~~~^~~~~ >> drivers/net/wireless/microchip/wilc1000/wlan.c:1246:63: warning: passing= argument 1 of 'wilc_wlan_cfg_get_wid' makes pointer from integer without a= cast [-Wint-conversion] 1246 | ret_size =3D wilc_wlan_cfg_get_wid(wilc->cfg_skb= ->tail, 0, wid); | ~~~~~~~~~~~~~^~= ~~~~ | | | sk= _buff_data_t {aka unsigned int} In file included from drivers/net/wireless/microchip/wilc1000/netdev.h:1= 9, from drivers/net/wireless/microchip/wilc1000/cfg80211.h= :9, from drivers/net/wireless/microchip/wilc1000/wlan.c:10: drivers/net/wireless/microchip/wilc1000/wlan_cfg.h:46:31: note: expected= 'u8 *' {aka 'unsigned char *'} but argument is of type 'sk_buff_data_t' {a= ka 'unsigned int'} 46 | int wilc_wlan_cfg_get_wid(u8 *frame, u32 offset, u16 id); | ~~~~^~~~~ vim +/wilc_wlan_cfg_set_wid +1243 drivers/net/wireless/microchip/wilc1000/w= lan.c 1217 = 1218 /** 1219 * Add a WID set/query to the current config packet and optionally 1220 * submit the resulting packet to the chip and wait for its reply. 1221 * Returns 0 on failure, positive number on success. 1222 */ 1223 static int wilc_wlan_cfg_apply_wid(struct wilc_vif *vif, int start, = u16 wid, 1224 u8 *buffer, u32 buffer_size, int commit, 1225 u32 drv_handler, bool set) 1226 { 1227 int ret_size; 1228 struct wilc *wilc =3D vif->wilc; 1229 = 1230 mutex_lock(&wilc->cfg_cmd_lock); 1231 = 1232 if (start) { 1233 WARN_ON(wilc->cfg_skb); 1234 wilc->cfg_skb =3D alloc_cfg_skb(vif); 1235 if (!wilc->cfg_skb) { 1236 netdev_dbg(vif->ndev, "Failed to alloc cfg_skb"); 1237 mutex_unlock(&wilc->cfg_cmd_lock); 1238 return 0; 1239 } 1240 } 1241 = 1242 if (set) > 1243 ret_size =3D wilc_wlan_cfg_set_wid(wilc->cfg_skb->tail, 0, 1244 wid, buffer, buffer_size); 1245 else > 1246 ret_size =3D wilc_wlan_cfg_get_wid(wilc->cfg_skb->tail, 0, wid); 1247 if (ret_size =3D=3D 0) 1248 netdev_dbg(vif->ndev, 1249 "Failed to add WID 0x%x to %s cfg packet\n", 1250 wid, set ? "set" : "query"); 1251 = 1252 skb_put(wilc->cfg_skb, ret_size); 1253 = 1254 if (!commit) { 1255 mutex_unlock(&wilc->cfg_cmd_lock); 1256 return ret_size; 1257 } 1258 = 1259 netdev_dbg(vif->ndev, "%s: %s seqno[%d]\n", 1260 __func__, set ? "set" : "get", wilc->cfg_seq_no); 1261 = 1262 if (wilc_wlan_cfg_commit(vif, set ? WILC_CFG_SET : WILC_CFG_QUERY, 1263 drv_handler)) 1264 ret_size =3D 0; 1265 = 1266 if (!wait_for_completion_timeout(&wilc->cfg_event, 1267 WILC_CFG_PKTS_TIMEOUT)) { 1268 netdev_dbg(vif->ndev, "%s: Timed Out\n", __func__); 1269 ret_size =3D 0; 1270 } 1271 = 1272 wilc->cfg_seq_no =3D (wilc->cfg_seq_no + 1) % 256; 1273 mutex_unlock(&wilc->cfg_cmd_lock); 1274 = 1275 return ret_size; 1276 } 1277 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5097659981574805971==--