From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBEE3C433FE for ; Tue, 21 Dec 2021 09:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbhLUJF5 (ORCPT ); Tue, 21 Dec 2021 04:05:57 -0500 Received: from verein.lst.de ([213.95.11.211]:46048 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236041AbhLUJF4 (ORCPT ); Tue, 21 Dec 2021 04:05:56 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D4A5B68B05; Tue, 21 Dec 2021 10:05:52 +0100 (CET) Date: Tue, 21 Dec 2021 10:05:52 +0100 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni Subject: Re: [PATCH v4 17/23] block: add check when merging zone device pages Message-ID: <20211221090552.GD7949@lst.de> References: <20211117215410.3695-1-logang@deltatee.com> <20211117215410.3695-18-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117215410.3695-18-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > +/* > + * Consecutive zone device pages should not be merged into the same sgl > + * or bvec segment with other types of pages or if they belong to different > + * pgmaps. Otherwise getting the pgmap of a given segment is not possible > + * without scanning the entire segment. This helper returns true either if > + * both pages are not zone device pages or both pages are zone device pages > + * with the same pgmap. > + */ > +static inline bool zone_device_pages_are_mergeable(const struct page *a, > + const struct page *b) Merging is only really a use case here. This really checks if they belong to the same pgmap, so I suspect that should be in the name. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53DCBC433F5 for ; Tue, 21 Dec 2021 09:06:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 066BA60E43; Tue, 21 Dec 2021 09:06:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8I2Lav86FI8O; Tue, 21 Dec 2021 09:05:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id ED28F605DB; Tue, 21 Dec 2021 09:05:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B862DC002F; Tue, 21 Dec 2021 09:05:58 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 64127C0012 for ; Tue, 21 Dec 2021 09:05:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4467D4092A for ; Tue, 21 Dec 2021 09:05:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ucFO0J_oJIXl for ; Tue, 21 Dec 2021 09:05:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp4.osuosl.org (Postfix) with ESMTPS id A9B4540928 for ; Tue, 21 Dec 2021 09:05:56 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D4A5B68B05; Tue, 21 Dec 2021 10:05:52 +0100 (CET) Date: Tue, 21 Dec 2021 10:05:52 +0100 From: Christoph Hellwig To: Logan Gunthorpe Subject: Re: [PATCH v4 17/23] block: add check when merging zone device pages Message-ID: <20211221090552.GD7949@lst.de> References: <20211117215410.3695-1-logang@deltatee.com> <20211117215410.3695-18-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211117215410.3695-18-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: linux-pci@vger.kernel.org, Dave Hansen , linux-nvme@lists.infradead.org, Stephen Bates , linux-mm@kvack.org, Jason Ekstrand , Ira Weiny , Christoph Hellwig , Minturn Dave B , Martin Oliveira , Matthew Wilcox , Jason Gunthorpe , Chaitanya Kulkarni , Bjorn Helgaas , Daniel Vetter , John Hubbard , linux-block@vger.kernel.org, Dan Williams , Jakowski Andrzej , Xiong Jianxin , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , Christian =?iso-8859-1?Q?K=F6nig?= X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" > +/* > + * Consecutive zone device pages should not be merged into the same sgl > + * or bvec segment with other types of pages or if they belong to different > + * pgmaps. Otherwise getting the pgmap of a given segment is not possible > + * without scanning the entire segment. This helper returns true either if > + * both pages are not zone device pages or both pages are zone device pages > + * with the same pgmap. > + */ > +static inline bool zone_device_pages_are_mergeable(const struct page *a, > + const struct page *b) Merging is only really a use case here. This really checks if they belong to the same pgmap, so I suspect that should be in the name. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu