From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3134595598485242142==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 04/23] wilc1000: factor common code in wilc_wlan_cfg_set() and wilc_wlan_cfg_get() Date: Tue, 21 Dec 2021 09:42:44 +0800 Message-ID: <202112210957.PA9D5JSi-lkp@intel.com> In-Reply-To: <20211218235404.3963475-5-davidm@egauge.net> List-Id: --===============3134595598485242142== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvalo-wireless-drivers-next/master] [also build test WARNING on kvalo-wireless-drivers/master v5.16-rc6 next-20= 211220] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/David-Mosberger-Tang/wilc1= 000-rework-tx-path-to-use-sk_buffs-throughout/20211219-075737 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-driv= ers-next.git master config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20211221= /202112210957.PA9D5JSi-lkp(a)intel.com/config) compiler: mips-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/ce89fccdb132d59dcaa93ba85= 5c5644a5e3b6df9 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review David-Mosberger-Tang/wilc1000-rewo= rk-tx-path-to-use-sk_buffs-throughout/20211219-075737 git checkout ce89fccdb132d59dcaa93ba855c5644a5e3b6df9 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dmips SHELL=3D/bin/bash drivers/net/wireless/microchip= /wilc1000/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/wireless/microchip/wilc1000/wlan.c:1280: warning: This comme= nt starts with '/**', but isn't a kernel-doc comment. Refer Documentation/d= oc-guide/kernel-doc.rst * Add a WID set/query to the current config packet and optionally vim +1280 drivers/net/wireless/microchip/wilc1000/wlan.c 1278 = 1279 /** > 1280 * Add a WID set/query to the current config packet and optionally 1281 * submit the resulting packet to the chip and wait for its reply. 1282 * Returns 0 on failure, positive number on success. 1283 */ 1284 static int wilc_wlan_cfg_apply_wid(struct wilc_vif *vif, int start, = u16 wid, 1285 u8 *buffer, u32 buffer_size, int commit, 1286 u32 drv_handler, bool set) 1287 { 1288 u32 offset; 1289 int ret_size; 1290 struct wilc *wilc =3D vif->wilc; 1291 = 1292 mutex_lock(&wilc->cfg_cmd_lock); 1293 = 1294 if (start) 1295 wilc->cfg_frame_offset =3D 0; 1296 = 1297 offset =3D wilc->cfg_frame_offset; 1298 if (set) 1299 ret_size =3D wilc_wlan_cfg_set_wid(wilc->cfg_frame.frame, offset, 1300 wid, buffer, buffer_size); 1301 else 1302 ret_size =3D wilc_wlan_cfg_get_wid(wilc->cfg_frame.frame, offset, 1303 wid); 1304 offset +=3D ret_size; 1305 wilc->cfg_frame_offset =3D offset; 1306 = 1307 if (!commit) { 1308 mutex_unlock(&wilc->cfg_cmd_lock); 1309 return ret_size; 1310 } 1311 = 1312 netdev_dbg(vif->ndev, "%s: %s seqno[%d]\n", 1313 __func__, set ? "set" : "get", wilc->cfg_seq_no); 1314 = 1315 if (wilc_wlan_cfg_commit(vif, set ? WILC_CFG_SET : WILC_CFG_QUERY, 1316 drv_handler)) 1317 ret_size =3D 0; 1318 = 1319 if (!wait_for_completion_timeout(&wilc->cfg_event, 1320 WILC_CFG_PKTS_TIMEOUT)) { 1321 netdev_dbg(vif->ndev, "%s: Timed Out\n", __func__); 1322 ret_size =3D 0; 1323 } 1324 = 1325 wilc->cfg_frame_offset =3D 0; 1326 wilc->cfg_seq_no +=3D 1; 1327 mutex_unlock(&wilc->cfg_cmd_lock); 1328 = 1329 return ret_size; 1330 } 1331 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============3134595598485242142==--