From: Jackie Liu <liu.yun@linux.dev>
To: linux@roeck-us.net
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, liu.yun@linux.dev
Subject: [PATCH 3/5] hwmon: (corsair-psu) Use devres function
Date: Wed, 22 Dec 2021 10:01:12 +0800 [thread overview]
Message-ID: <20211222020114.3524736-3-liu.yun@linux.dev> (raw)
In-Reply-To: <20211222020114.3524736-1-liu.yun@linux.dev>
From: Jackie Liu <liuyun01@kylinos.cn>
Use devm_hwmon_device_register_with_info() and remove hwmon_dev
from corsairpsu_data struct as it is not needed anymore.
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
drivers/hwmon/corsair-psu.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
index 14389fd7afb8..1a40cde246aa 100644
--- a/drivers/hwmon/corsair-psu.c
+++ b/drivers/hwmon/corsair-psu.c
@@ -115,7 +115,6 @@ static const char *const label_amps[] = {
struct corsairpsu_data {
struct hid_device *hdev;
- struct device *hwmon_dev;
struct dentry *debugfs;
struct completion wait_completion;
struct mutex lock; /* for locking access to cmd_buffer */
@@ -684,6 +683,7 @@ static void corsairpsu_debugfs_init(struct corsairpsu_data *priv)
static int corsairpsu_probe(struct hid_device *hdev, const struct hid_device_id *id)
{
struct corsairpsu_data *priv;
+ struct device *hwmon_dev;
int ret;
priv = devm_kzalloc(&hdev->dev, sizeof(struct corsairpsu_data), GFP_KERNEL);
@@ -728,13 +728,13 @@ static int corsairpsu_probe(struct hid_device *hdev, const struct hid_device_id
corsairpsu_get_criticals(priv);
corsairpsu_check_cmd_support(priv);
- priv->hwmon_dev = hwmon_device_register_with_info(&hdev->dev, "corsairpsu", priv,
- &corsairpsu_chip_info, NULL);
-
- if (IS_ERR(priv->hwmon_dev)) {
- ret = PTR_ERR(priv->hwmon_dev);
+ hwmon_dev =
+ devm_hwmon_device_register_with_info(&hdev->dev, "corsairpsu",
+ priv, &corsairpsu_chip_info,
+ NULL);
+ ret = PTR_ERR_OR_ZERO(hwmon_dev);
+ if (ret)
goto fail_and_close;
- }
corsairpsu_debugfs_init(priv);
@@ -752,7 +752,6 @@ static void corsairpsu_remove(struct hid_device *hdev)
struct corsairpsu_data *priv = hid_get_drvdata(hdev);
debugfs_remove_recursive(priv->debugfs);
- hwmon_device_unregister(priv->hwmon_dev);
hid_hw_close(hdev);
hid_hw_stop(hdev);
}
--
2.25.1
next prev parent reply other threads:[~2021-12-22 2:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 2:01 [PATCH 1/5] hwmon: (corsair-cpro) Use devres function Jackie Liu
2021-12-22 2:01 ` [PATCH 2/5] hwmon: (nzxt-kraken2) " Jackie Liu
2021-12-22 2:01 ` Jackie Liu [this message]
2021-12-22 2:01 ` [PATCH 4/5] hwmon: (d5next) " Jackie Liu
2021-12-22 2:01 ` [PATCH 5/5] hwmon: (drivetemp) " Jackie Liu
2021-12-22 3:03 ` Guenter Roeck
2021-12-22 5:43 ` Jackie Liu
2021-12-22 2:58 ` [PATCH 1/5] hwmon: (corsair-cpro) " Guenter Roeck
2021-12-22 6:13 ` Jackie Liu
2021-12-22 16:10 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222020114.3524736-3-liu.yun@linux.dev \
--to=liu.yun@linux.dev \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.