From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3634C433EF for ; Wed, 22 Dec 2021 08:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gU7qOBIpHDAdEIIDIlC/1lHylF3zR9JmaMnqmjHR5i8=; b=JBe1BXeuqzl+iq HuZsYbSKz76rhkbAZ4zlCtKVBmgA/zB1pxkmNWVBmnLVXeG6MLm2ZG8/p7c62zmkVmcxWi97y99x3 iqXBWv9oYUMOQ7+GNuTpKNDA66gQJXptG4umv0YBI3iTwFVsrwG0TbSh8YJLGNtfu/l79sxHcEUcn RZDIjjpvDovWq4/vytkX4N1ckhWeDw3jcqEqG+QJb6bZHeoDWn07WrKjp1WCIzGOrnK08luTV6144 +7+sbdYQ4u567lrrU1j1wR38dJhc3CiIyJjNkZKeuT9p2u5Wkuab5N5hjexsO9vE2tr69ggZdQ/00 XWTBn7j61rBsRWok8v2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzx6W-009iYM-QJ; Wed, 22 Dec 2021 08:36:08 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzx6T-009iX1-K0 for linux-mtd@lists.infradead.org; Wed, 22 Dec 2021 08:36:07 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 41A07240003; Wed, 22 Dec 2021 08:35:59 +0000 (UTC) Date: Wed, 22 Dec 2021 09:35:58 +0100 From: Miquel Raynal To: Cc: , , , , , , , , , , Subject: Re: [PATCH v5 2/3] spi: dt-bindings: Describe stacked/parallel memories modes Message-ID: <20211222093523.30f8ae7c@xps13> In-Reply-To: References: <20211221170058.18333-1-miquel.raynal@bootlin.com> <20211221170058.18333-3-miquel.raynal@bootlin.com> <20211222090542.43dfe12e@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_003605_973811_204F6163 X-CRM114-Status: GOOD ( 26.00 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgVHVkb3IsCgpUdWRvci5BbWJhcnVzQG1pY3JvY2hpcC5jb20gd3JvdGUgb24gV2VkLCAyMiBE ZWMgMjAyMSAwODoyMjowNSArMDAwMDoKPiBPbiAxMi8yMi8yMSAxMDowNSBBTSwgTWlxdWVsIFJh eW5hbCB3cm90ZToKPiA+IEVYVEVSTkFMIEVNQUlMOiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3Bl biBhdHRhY2htZW50cyB1bmxlc3MgeW91IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQo+ID4gCj4g PiBIZWxsbyBUdWRvciwgIAo+IAo+IEhpIQo+IAo+ID4gCj4gPiBUdWRvci5BbWJhcnVzQG1pY3Jv Y2hpcC5jb20gd3JvdGUgb24gV2VkLCAyMiBEZWMgMjAyMSAwNzo1Mjo0NCArMDAwMDoKPiA+ICAg Cj4gPj4gT24gMTIvMjEvMjEgNzowMCBQTSwgTWlxdWVsIFJheW5hbCB3cm90ZTogIAo+ID4+PiBF WFRFUk5BTCBFTUFJTDogRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW5s ZXNzIHlvdSBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUKPiA+Pj4KPiA+Pj4gRGVzY3JpYmUgdHdv IG5ldyBtZW1vcmllcyBtb2RlczoKPiA+Pj4gLSBBIHN0YWNrZWQgbW9kZSB3aGVuIHRoZSBidXMg aXMgY29tbW9uIGJ1dCB0aGUgYWRkcmVzcyBzcGFjZSBleHRlbmRlZAo+ID4+PiAgIHdpdGggYW4g YWRkaXRpbmFscyB3aXJlcy4KPiA+Pj4gLSBBIHBhcmFsbGVsIG1vZGUgd2l0aCBwYXJhbGxlbCBi dXNzZXMgYWNjZXNzaW5nIHBhcmFsbGVsIGZsYXNoZXMgd2hlcmUKPiA+Pj4gICB0aGUgZGF0YSBp cyBzcHJlYWQuCj4gPj4+Cj4gPj4+IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVl bC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gPj4+IC0tLQo+ID4+Pgo+ID4+PiBIZWxsbyBSb2IsCj4g Pj4+Cj4gPj4+IEkga25vdyB0aGUgYmVsb3cgZG9lcyBub3QgcGFzcyB0aGUgdGVzdHMgKGF0IGxl YXN0IHRoZSBleGFtcGxlIHBhdGNoIDMKPiA+Pj4gZG9lcyBub3QgcGFzcykgYnV0IEkgYmVsaWV2 ZSB0aGUgaXNzdWUgaXMgcHJvYmFibHkgb24gdGhlIHRvb2xpbmcgc2lkZQo+ID4+PiBiZWNhdXNl IHRoZSBleGFjdCBzYW1lIHRoaW5nIHdpdGggdWluZzMyLWFycmF5IGluc3RlYWQgaXMgYWNjZXB0 ZWQuIFRoZQo+ID4+PiBwcm9ibGVtIGNvbWVzIGZyb20gdGhlIG1pbkl0ZW1zL21heEl0ZW1zIGxp bmVzLiBXaXRob3V0IHRoZW0sIHRoaXMgaXMKPiA+Pj4gb2theS4gVGhlIG1heEl0ZW1zIGJ0dyBt YXRjaGVzIHRoZSAiZ29vZCBlbm91Z2ggdmFsdWUgZm9yIG5vdyIgaWRlYS4KPiA+Pj4KPiA+Pj4g VGhlIGVycm9ycyBJIGdldCBhcmU6Cj4gPj4+Cj4gPj4+ICQgbWFrZSBkdF9iaW5kaW5nX2NoZWNr IERUX1NDSEVNQV9GSUxFUz1Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc3BpL3Nw aS1jb250cm9sbGVyLnlhbWwKPiA+Pj4gICBMSU5UICAgIERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncwo+ID4+PiAgIENIS0RUICAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3Byb2Nlc3NlZC1zY2hlbWEtZXhhbXBsZXMuanNvbgo+ID4+PiAgIFNDSEVNQSAgRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Byb2Nlc3NlZC1zY2hlbWEtZXhhbXBsZXMuanNv bgo+ID4+PiAgIERURVggICAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9z cGktY29udHJvbGxlci5leGFtcGxlLmR0cwo+ID4+PiAgIERUQyAgICAgRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9zcGktY29udHJvbGxlci5leGFtcGxlLmR0LnlhbWwKPiA+ Pj4gICBDSEVDSyAgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zcGkvc3BpLWNv bnRyb2xsZXIuZXhhbXBsZS5kdC55YW1sCj4gPj4+IC9zcmMvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3NwaS9zcGktY29udHJvbGxlci5leGFtcGxlLmR0LnlhbWw6IHNwaUA4MDAx MDAwMDogZmxhc2hAMjpzdGFja2VkLW1lbW9yaWVzOiBbWzI2ODQzNTQ1NiwgMjY4NDM1NDU2XV0g aXMgdG9vIHNob3J0Cj4gPj4+ICAgICAgICAgRnJvbSBzY2hlbWE6IC9zcmMvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9zcGktY29udHJvbGxlci55YW1sCj4gPj4+IC9zcmMv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9zcGktY29udHJvbGxlci5leGFt cGxlLmR0LnlhbWw6IHNwaUA4MDAxMDAwMDogZmxhc2hAMjpzdGFja2VkLW1lbW9yaWVzOiBbWzI2 ODQzNTQ1NiwgMjY4NDM1NDU2XV0gaXMgdG9vIHNob3J0Cj4gPj4+ICAgICAgICAgRnJvbSBzY2hl bWE6IC9zcmMvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9teHMtc3BpLnlh bWwKPiA+Pj4gL3NyYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc3BpL3NwaS1j b250cm9sbGVyLmV4YW1wbGUuZHQueWFtbDogc3BpQDgwMDEwMDAwOiBVbmV2YWx1YXRlZCBwcm9w ZXJ0aWVzIGFyZSBub3QgYWxsb3dlZCAoJyNhZGRyZXNzLWNlbGxzJywgJyNzaXplLWNlbGxzJywg J2Rpc3BsYXlAMCcsICdzZW5zb3JAMScsICdmbGFzaEAyJyB3ZXJlIHVuZXhwZWN0ZWQpCj4gPj4+ ICAgICAgICAgRnJvbSBzY2hlbWE6IC9zcmMvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3NwaS9teHMtc3BpLnlhbWwKPiA+Pj4gL3NyYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3Mvc3BpL3NwaS1jb250cm9sbGVyLmV4YW1wbGUuZHQueWFtbDogZmxhc2hAMjogc3Rh Y2tlZC1tZW1vcmllczogW1syNjg0MzU0NTYsIDI2ODQzNTQ1Nl1dIGlzIHRvbyBzaG9ydAo+ID4+ PiAgICAgICAgIEZyb20gc2NoZW1hOiAvc3JjL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9tdGQvamVkZWMsc3BpLW5vci55YW1sCj4gPj4+Cj4gPj4+Cj4gPj4+ICAuLi4vYmluZGlu Z3Mvc3BpL3NwaS1wZXJpcGhlcmFsLXByb3BzLnlhbWwgICAgfCAyNSArKysrKysrKysrKysrKysr KysrCj4gPj4+ICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQo+ID4+Pgo+ID4+PiBk aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9zcGktcGVy aXBoZXJhbC1wcm9wcy55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Nw aS9zcGktcGVyaXBoZXJhbC1wcm9wcy55YW1sCj4gPj4+IGluZGV4IDVkZDIwOTIwNmU4OC4uZmVk YjdhZTk4ZmY2IDEwMDY0NAo+ID4+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3Mvc3BpL3NwaS1wZXJpcGhlcmFsLXByb3BzLnlhbWwKPiA+Pj4gKysrIGIvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NwaS9zcGktcGVyaXBoZXJhbC1wcm9wcy55YW1sCj4g Pj4+IEBAIC04Miw2ICs4MiwzMSBAQCBwcm9wZXJ0aWVzOgo+ID4+PiAgICAgIGRlc2NyaXB0aW9u Ogo+ID4+PiAgICAgICAgRGVsYXksIGluIG1pY3Jvc2Vjb25kcywgYWZ0ZXIgYSB3cml0ZSB0cmFu c2Zlci4KPiA+Pj4KPiA+Pj4gKyAgc3RhY2tlZC1tZW1vcmllczoKPiA+Pj4gKyAgICBkZXNjcmlw dGlvbjogU2V2ZXJhbCBTUEkgbWVtb3JpZXMgY2FuIGJlIHdpcmVkIGluIHN0YWNrZWQgbW9kZS4K PiA+Pj4gKyAgICAgIFRoaXMgYmFzaWNhbGx5IG1lYW5zIHRoYXQgZWl0aGVyIGEgZGV2aWNlIGZl YXR1cmVzIHNldmVyYWwgY2hpcAo+ID4+PiArICAgICAgc2VsZWN0cywgb3IgdGhhdCBkaWZmZXJl bnQgZGV2aWNlcyBtdXN0IGJlIHNlZW4gYXMgYSBzaW5nbGUKPiA+Pj4gKyAgICAgIGJpZ2dlciBj aGlwLiBUaGlzIGJhc2ljYWxseSBkb3VibGVzIChvciBtb3JlKSB0aGUgdG90YWwgYWRkcmVzcwo+ ID4+PiArICAgICAgc3BhY2Ugd2l0aCBvbmx5IGEgc2luZ2xlIGFkZGl0aW9uYWwgd2lyZSwgd2hp bGUgc3RpbGwgbmVlZGluZwo+ID4+PiArICAgICAgdG8gcmVwZWF0IHRoZSBjb21tYW5kcyB3aGVu IGNyb3NzaW5nIGEgY2hpcCBib3VuZGFyeS4gVGhlIHNpemUgb2YKPiA+Pj4gKyAgICAgIGVhY2gg Y2hpcCBzaG91bGQgYmUgcHJvdmlkZWQgYXMgbWVtYmVycyBvZiB0aGUgYXJyYXkuCj4gPj4+ICsg ICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvdWludDY0LWFycmF5Cj4g Pj4+ICsgICAgbWluSXRlbXM6IDIKPiA+Pj4gKyAgICBtYXhJdGVtczogNCAgCj4gPj4KPiA+PiBX aHkgZG8gd2UgZGVmaW5lIG1heEl0ZW1zPyBDYW4ndCB3ZSByZW1vdmUgdGhpcyByZXN0cmljdGlv bj8gIAo+ID4gCj4gPiBSb2IgdXN1YWxseSBwcmVmZXJzIHRvIGJvdW5kIHByb3BlcnRpZXMsIHRo YXQncyB3aHkgd2Ugb2Z0ZW4gc2VlICJnb29kCj4gPiBlbm91Z2ggdmFsdWVzIGZvciBub3ciIGlu IHRoZSBiaW5kaW5ncy4gSWYgaXQncyBubyBsb25nZXIgdGhlIGNhc2UgaXQncyAgCj4gCj4gcmln aHQsIEkgc2F3IGl0Lgo+IAo+ID4gZmluZSB0byBkcm9wIHRoZSBtYXhJdGVtcyBwcm9wZXJ0eS4g IAo+IAo+IFRoZXJlJ3Mgbm8gc3VjaCBoYXJkd2FyZSBsaW1pdGF0aW9uIGFzIGZhciBhcyBJIGtu b3csIHRoYXQncyB3aHkgSSd2ZQo+IGFza2VkLiBNYXliZSBSb2IgY2FuIGFkdmlzZS4KClllcywg SSdsbCBmb2xsb3cgd2hhdCBSb2IgdGhpbmtzIGl0cyBiZXN0OgotIGtlZXBpbmcgbWF4SXRlbXM6 IDQgKGFzIGl0IGlzKSwgd2hpY2ggaXMgYSBnb29kIGVub3VnaCB2YWx1ZQotIGRyb3BwaW5nIHRo ZSBtYXhJdGVtcyBoZXJlIGJlY2F1c2UgaW4gdGhlIGVuZCBubyBib3VuZGluZyBpcyBuZWNlc3Nh cnkKLSB1c2luZyBtYXhJdGVtczogMiB0byBtYXRjaCB0aGUgU1BJIENTIGV2ZW4gdGhvdWdoIGlu IHRoZW9yeSB0aGVzZSB0d28KICBudW1iZXJzIGFyZSBub3QgY29ycmVsYXRlZCAoc3RhY2tlZC1t ZW1vcmllcyBtaWdodCB2ZXJ5IHdlbGwgYmUKICB1c2VkIGJ5IG90aGVyIG5vbiBTUEkgbWVtb3Jp ZXMgYXMgd2VsbCkuCgpCVFcgaWYgeW91J3JlIGZpbmUgd2l0aCB0aGUgcHJvcG9zYWwgeW91ciBB Y2sgaXMgd2VsY29tZSA7KQoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFp bGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE8CC433F5 for ; Wed, 22 Dec 2021 08:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239698AbhLVIgF convert rfc822-to-8bit (ORCPT ); Wed, 22 Dec 2021 03:36:05 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:49695 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239581AbhLVIgE (ORCPT ); Wed, 22 Dec 2021 03:36:04 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 41A07240003; Wed, 22 Dec 2021 08:35:59 +0000 (UTC) Date: Wed, 22 Dec 2021 09:35:58 +0100 From: Miquel Raynal To: Cc: , , , , , , , , , , Subject: Re: [PATCH v5 2/3] spi: dt-bindings: Describe stacked/parallel memories modes Message-ID: <20211222093523.30f8ae7c@xps13> In-Reply-To: References: <20211221170058.18333-1-miquel.raynal@bootlin.com> <20211221170058.18333-3-miquel.raynal@bootlin.com> <20211222090542.43dfe12e@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Tudor, Tudor.Ambarus@microchip.com wrote on Wed, 22 Dec 2021 08:22:05 +0000: > On 12/22/21 10:05 AM, Miquel Raynal wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Hello Tudor, > > Hi! > > > > > Tudor.Ambarus@microchip.com wrote on Wed, 22 Dec 2021 07:52:44 +0000: > > > >> On 12/21/21 7:00 PM, Miquel Raynal wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> > >>> Describe two new memories modes: > >>> - A stacked mode when the bus is common but the address space extended > >>> with an additinals wires. > >>> - A parallel mode with parallel busses accessing parallel flashes where > >>> the data is spread. > >>> > >>> Signed-off-by: Miquel Raynal > >>> --- > >>> > >>> Hello Rob, > >>> > >>> I know the below does not pass the tests (at least the example patch 3 > >>> does not pass) but I believe the issue is probably on the tooling side > >>> because the exact same thing with uing32-array instead is accepted. The > >>> problem comes from the minItems/maxItems lines. Without them, this is > >>> okay. The maxItems btw matches the "good enough value for now" idea. > >>> > >>> The errors I get are: > >>> > >>> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/spi-controller.yaml > >>> LINT Documentation/devicetree/bindings > >>> CHKDT Documentation/devicetree/bindings/processed-schema-examples.json > >>> SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json > >>> DTEX Documentation/devicetree/bindings/spi/spi-controller.example.dts > >>> DTC Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml > >>> CHECK Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml > >>> /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: spi@80010000: flash@2:stacked-memories: [[268435456, 268435456]] is too short > >>> From schema: /src/Documentation/devicetree/bindings/spi/spi-controller.yaml > >>> /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: spi@80010000: flash@2:stacked-memories: [[268435456, 268435456]] is too short > >>> From schema: /src/Documentation/devicetree/bindings/spi/mxs-spi.yaml > >>> /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: spi@80010000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'display@0', 'sensor@1', 'flash@2' were unexpected) > >>> From schema: /src/Documentation/devicetree/bindings/spi/mxs-spi.yaml > >>> /src/Documentation/devicetree/bindings/spi/spi-controller.example.dt.yaml: flash@2: stacked-memories: [[268435456, 268435456]] is too short > >>> From schema: /src/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > >>> > >>> > >>> .../bindings/spi/spi-peripheral-props.yaml | 25 +++++++++++++++++++ > >>> 1 file changed, 25 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > >>> index 5dd209206e88..fedb7ae98ff6 100644 > >>> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > >>> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > >>> @@ -82,6 +82,31 @@ properties: > >>> description: > >>> Delay, in microseconds, after a write transfer. > >>> > >>> + stacked-memories: > >>> + description: Several SPI memories can be wired in stacked mode. > >>> + This basically means that either a device features several chip > >>> + selects, or that different devices must be seen as a single > >>> + bigger chip. This basically doubles (or more) the total address > >>> + space with only a single additional wire, while still needing > >>> + to repeat the commands when crossing a chip boundary. The size of > >>> + each chip should be provided as members of the array. > >>> + $ref: /schemas/types.yaml#/definitions/uint64-array > >>> + minItems: 2 > >>> + maxItems: 4 > >> > >> Why do we define maxItems? Can't we remove this restriction? > > > > Rob usually prefers to bound properties, that's why we often see "good > > enough values for now" in the bindings. If it's no longer the case it's > > right, I saw it. > > > fine to drop the maxItems property. > > There's no such hardware limitation as far as I know, that's why I've > asked. Maybe Rob can advise. Yes, I'll follow what Rob thinks its best: - keeping maxItems: 4 (as it is), which is a good enough value - dropping the maxItems here because in the end no bounding is necessary - using maxItems: 2 to match the SPI CS even though in theory these two numbers are not correlated (stacked-memories might very well be used by other non SPI memories as well). BTW if you're fine with the proposal your Ack is welcome ;) Thanks, Miquèl