From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 836E4C433F5 for ; Wed, 22 Dec 2021 08:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VOq9UJPefUyVd5lo31f1VNwD/PMzsKK7jV2vo0y2ytA=; b=lPoNW1AHZc7AfD 7UTVmA50NUdnThBgCpD4srhWZxOqGN2XWdGThjsoGYWpY7QNd6/gS4K3b1FClPKg4b37g2Ob8l8Yc Djqo1p8q9CLvHudfaEHDuYqpTM0gF+yp5AgqnyiRgjyeergIZOfsAijtfqjjF+A4syGUuKb/mKMwp zlM1ZlOcVEgmKdMYoHZInHKuYYWnT4Zu9X4mWx7zP72bAY8x3/F7LEz2Ni8CWwxC/94X2xPJzaRv2 0hFYe4WfvrBPjTH58dNlzpweQni8XbquEHZWBjiiAnMokf/s3icdb4AjdkVOezWF1jvCAyhT+AUfh M+Ye2gtWt/kLxqJOedng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzxCG-009jnw-Cu; Wed, 22 Dec 2021 08:42:04 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzxCD-009jn4-9A for linux-mtd@lists.infradead.org; Wed, 22 Dec 2021 08:42:03 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D5D68E0007; Wed, 22 Dec 2021 08:41:57 +0000 (UTC) Date: Wed, 22 Dec 2021 09:41:56 +0100 From: Miquel Raynal To: Pratyush Yadav Cc: Rob Herring , , Michal Simek , Thomas Petazzoni , Mark Brown , , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Michael Walle , , Rob Herring Subject: Re: [PATCH v5 1/3] dt-bindings: mtd: spi-nor: Allow two CS per device Message-ID: <20211222094156.7bfce4e4@xps13> In-Reply-To: <20211222092324.7ec6ec6a@xps13> References: <20211221170058.18333-1-miquel.raynal@bootlin.com> <20211221170058.18333-2-miquel.raynal@bootlin.com> <20211221184725.46lelrdfoxeom6uc@ti.com> <20211222092324.7ec6ec6a@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_004201_619979_292CF9C3 X-CRM114-Status: GOOD ( 35.15 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Cm1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20gd3JvdGUgb24gV2VkLCAyMiBEZWMgMjAyMSAwOToy MzoyNCArMDEwMDoKCj4gSGkgUHJhdHl1c2gsCj4gCj4gcC55YWRhdkB0aS5jb20gd3JvdGUgb24g V2VkLCAyMiBEZWMgMjAyMSAwMDoxNzoyNyArMDUzMDoKPiAKPiA+IE9uIDIxLzEyLzIxIDA2OjAw UE0sIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAKPiA+ID4gVGhlIFhpbGlueCBRU1BJIGNvbnRyb2xs ZXIgaGFzIHR3byBhZHZhbmNlZCBtb2RlcyB3aGljaCBhbGxvdyB0aGUKPiA+ID4gY29udHJvbGxl ciB0byBiZWhhdmUgZGlmZmVyZW50bHkgYW5kIGNvbnNpZGVyIHR3byBmbGFzaGVzIGFzIG9uZSBz aW5nbGUKPiA+ID4gc3RvcmFnZS4KPiA+ID4gCj4gPiA+IE9uZSBvZiB0aGVzZSB0d28gbW9kZXMg aXMgcXVpdGUgY29tcGxleCB0byBzdXBwb3J0IGZyb20gYSBiaW5kaW5nIHBvaW50Cj4gPiA+IG9m IHZpZXcgYW5kIGlzIHRoZSBkdWFsIHBhcmFsbGVsIG1lbW9yaWVzLiBJbiB0aGlzIG1vZGUsIGVh Y2ggYnl0ZSBvZgo+ID4gPiBkYXRhIGlzIHN0b3JlZCBpbiBib3RoIGRldmljZXM6IHRoZSBldmVu IGJpdHMgaW4gb25lLCB0aGUgb2RkIGJpdHMgaW4KPiA+ID4gdGhlIG90aGVyLiBUaGUgc3BsaXQg aXMgYXV0b21hdGljYWxseSBoYW5kbGVkIGJ5IHRoZSBRU1BJIGNvbnRyb2xsZXIgYW5kCj4gPiA+ IGlzIHRyYW5zcGFyZW50IGZvciB0aGUgdXNlci4KPiA+ID4gCj4gPiA+IFRoZSBvdGhlciBtb2Rl IGlzIHNpbXBsZXIgdG8gc3VwcG9ydCwgaXQgaXMgY2FsbGVkIGR1YWwgc3RhY2tlZAo+ID4gPiBt ZW1vcmllcy4gVGhlIGNvbnRyb2xsZXIgc2hhcmVzIHRoZSBzYW1lIFNQSSBidXMgYnV0IGVhY2gg b2YgdGhlIGRldmljZXMKPiA+ID4gY29udGFpbiBoYWxmIG9mIHRoZSBkYXRhLiBPbmNlIGluIHRo aXMgbW9kZSwgdGhlIGNvbnRyb2xsZXIgZG9lcyBub3QKPiA+ID4gZm9sbG93IENTIHJlcXVlc3Rz IGJ1dCBpbnN0ZWFkIGludGVybmFsbHkgd2lyZXMgdGhlIHR3byBDUyBsZXZlbHMgd2l0aAo+ID4g PiB0aGUgdmFsdWUgb2YgdGhlIG1vc3Qgc2lnbmlmaWNhbnQgYWRkcmVzcyBiaXQuCj4gPiA+IAo+ ID4gPiBTdXBwb3J0aW5nIHRoZXNlIHR3byBtb2RlcyB3aWxsIGludm9sdmUgY29yZSBjaGFuZ2Vz IHdoaWNoIGluY2x1ZGUgdGhlCj4gPiA+IHBvc3NpYmlsaXR5IG9mIHByb3ZpZGluZyB0d28gQ1Mg Zm9yIGEgc2luZ2xlIFNQSSBkZXZpY2UKPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1pcXVl bCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gPiA+IEFja2VkLWJ5OiBSb2Ig SGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+ID4gPiAtLS0KPiA+ID4gIERvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9tdGQvamVkZWMsc3BpLW5vci55YW1sIHwgMyArKy0KPiA+ID4g IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gCj4g PiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL2pl ZGVjLHNwaS1ub3IueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tdGQv amVkZWMsc3BpLW5vci55YW1sCj4gPiA+IGluZGV4IDM5NDIxZjcyMzNlNC4uNGFiZmI0Y2ZjMTU3 IDEwMDY0NAo+ID4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRk L2plZGVjLHNwaS1ub3IueWFtbAo+ID4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvbXRkL2plZGVjLHNwaS1ub3IueWFtbAo+ID4gPiBAQCAtNDcsNyArNDcsOCBAQCBw cm9wZXJ0aWVzOgo+ID4gPiAgICAgICAgaWRlbnRpZmllZCBieSB0aGUgSkVERUMgUkVBRCBJRCBv cGNvZGUgKDB4OUYpLgo+ID4gPiAgCj4gPiA+ICAgIHJlZzoKPiA+ID4gLSAgICBtYXhJdGVtczog MQo+ID4gPiArICAgIG1pbkl0ZW1zOiAxCj4gPiA+ICsgICAgbWF4SXRlbXM6IDIgICAgCj4gPiAK PiA+IFlvdSBhbGxvdyB1cCB0byA0IGl0ZW1zIGluIHN0YWNrZWQtbWVtb3JpZXMgYnV0IG9ubHkg YWxsb3cgdXAgdG8gMiBDUywgCj4gPiB3aGljaCB3b3VsZCBtYWtlIHRoZSBvdGhlciAyIG1lbW9y aWVzIHVudXNhYmxlLiBTaG91bGQgYWxzbyBjaGFuZ2UgdGhpcyAKPiA+IHRvIDQuICAKPiAKPiBZ ZXMsIEkgYWxsb3dlZCAibW9yZSIgdGhlb3JldGljYWwgZGV2aWNlcyBpbiB0aGUKPiBzdGFja2Vk L3BhcmFsbGVsLW1lbW9yaWVzIHByb3BlcnRpZXMgYmVjYXVzZSB0aGVyZSBpcyBubyByZWFsCj4g bGltaXRhdGlvbiBvbiB0aGlzIHNpZGUgc28gSSBkaWRuJ3Qgd2FudCB0byBjb25zdHJhaW4gaXQg dG9vIG11Y2gsCj4gd2hpbGUgc3RpbGwga2VlcGluZyBhIG1heGltdW0gdmFsdWUsIGhlbmNlIDQg c2VlbWVkIGEgbmljZSBndWVzcyBmb3IgYQo+ICJtYXhpbXVtIGJ1dCBjYW4gYmUgYmlnZ2VyIHZh bHVlIHdlIGRvbid0IHJlYWxseSBjYXJlIGl0J3MganVzdCBmb3IKPiBib3VuZGluZyIuIEhvd2V2 ZXIgb24gdGhlIFNQSSBzaWRlIHRoaXMgaXMgYSBiaWcgY2hhbmdlIHdpdGggZGVlcAo+IGNvbnNl cXVlbmNlcyBhbmQgSSBkb24ndCB3YW50IHRvIHJ1c2ggdGhpbmdzIHNvIGl0IGlzIG9uIHB1cnBv c2UgdGhhdCBJCj4ga2VwdCB0aGUgbGltaXRhdGlvbiB0byAyLiBCdXQgd2UgY2FuIGNoYW5nZSB0 aGUgbWF4SXRlbXMgdG8gMgo+IGV2ZXJ5d2hlcmUgaWYgdGhpcyBhcHBlYXJzIHRvIGJlIHRoZSB0 aGluZyB0byBkby4KCkkgZm9yZ290IHRvIG1lbnRpb24gdGhhdCB0aGUgc3RhY2tlZC9wYXJhbGxl bC1tZW1vcmllcyBjb3VsZAphbHNvIGNlcnRhaW5seSBiZSBjb25zaWRlcmVkICJtZW1vcnkiIHBy b3BlcnRpZXMgKHRoaW5rIGFib3V0IHRoZQpnZW5lcmljIHRlcm0pLCBub3QgbmVjZXNzYXJpbHkg Ym91bmQgdG8gU1BJLiBXZSBjb3VsZCBkZWZpbml0ZWx5IGhhdmUKdGhlIHNhbWUgcGF0dGVybiB3 aXRoIG90aGVyIG1lbW9yeSB0eXBlcyBhcyB3ZWxsIGFuZCBub3QgYmUgdGlnaHQgdG8KdGhlIG51 bWJlciBvZiBTUEkgQ1MuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWls aW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A938C433EF for ; Wed, 22 Dec 2021 08:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243421AbhLVImA convert rfc822-to-8bit (ORCPT ); Wed, 22 Dec 2021 03:42:00 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:59731 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243406AbhLVImA (ORCPT ); Wed, 22 Dec 2021 03:42:00 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D5D68E0007; Wed, 22 Dec 2021 08:41:57 +0000 (UTC) Date: Wed, 22 Dec 2021 09:41:56 +0100 From: Miquel Raynal To: Pratyush Yadav Cc: Rob Herring , , Michal Simek , Thomas Petazzoni , Mark Brown , , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Michael Walle , , Rob Herring Subject: Re: [PATCH v5 1/3] dt-bindings: mtd: spi-nor: Allow two CS per device Message-ID: <20211222094156.7bfce4e4@xps13> In-Reply-To: <20211222092324.7ec6ec6a@xps13> References: <20211221170058.18333-1-miquel.raynal@bootlin.com> <20211221170058.18333-2-miquel.raynal@bootlin.com> <20211221184725.46lelrdfoxeom6uc@ti.com> <20211222092324.7ec6ec6a@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org miquel.raynal@bootlin.com wrote on Wed, 22 Dec 2021 09:23:24 +0100: > Hi Pratyush, > > p.yadav@ti.com wrote on Wed, 22 Dec 2021 00:17:27 +0530: > > > On 21/12/21 06:00PM, Miquel Raynal wrote: > > > The Xilinx QSPI controller has two advanced modes which allow the > > > controller to behave differently and consider two flashes as one single > > > storage. > > > > > > One of these two modes is quite complex to support from a binding point > > > of view and is the dual parallel memories. In this mode, each byte of > > > data is stored in both devices: the even bits in one, the odd bits in > > > the other. The split is automatically handled by the QSPI controller and > > > is transparent for the user. > > > > > > The other mode is simpler to support, it is called dual stacked > > > memories. The controller shares the same SPI bus but each of the devices > > > contain half of the data. Once in this mode, the controller does not > > > follow CS requests but instead internally wires the two CS levels with > > > the value of the most significant address bit. > > > > > > Supporting these two modes will involve core changes which include the > > > possibility of providing two CS for a single SPI device > > > > > > Signed-off-by: Miquel Raynal > > > Acked-by: Rob Herring > > > --- > > > Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > > index 39421f7233e4..4abfb4cfc157 100644 > > > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > > @@ -47,7 +47,8 @@ properties: > > > identified by the JEDEC READ ID opcode (0x9F). > > > > > > reg: > > > - maxItems: 1 > > > + minItems: 1 > > > + maxItems: 2 > > > > You allow up to 4 items in stacked-memories but only allow up to 2 CS, > > which would make the other 2 memories unusable. Should also change this > > to 4. > > Yes, I allowed "more" theoretical devices in the > stacked/parallel-memories properties because there is no real > limitation on this side so I didn't want to constrain it too much, > while still keeping a maximum value, hence 4 seemed a nice guess for a > "maximum but can be bigger value we don't really care it's just for > bounding". However on the SPI side this is a big change with deep > consequences and I don't want to rush things so it is on purpose that I > kept the limitation to 2. But we can change the maxItems to 2 > everywhere if this appears to be the thing to do. I forgot to mention that the stacked/parallel-memories could also certainly be considered "memory" properties (think about the generic term), not necessarily bound to SPI. We could definitely have the same pattern with other memory types as well and not be tight to the number of SPI CS. Thanks, Miquèl