From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7098376893721931912==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 6/8] mfd: lpc_ich: Switch to generic p2sb_bar() Date: Wed, 22 Dec 2021 12:12:03 +0800 Message-ID: <202112221025.kf8hnQ87-lkp@intel.com> In-Reply-To: <20211221181526.53798-7-andriy.shevchenko@linux.intel.com> List-Id: --===============7098376893721931912== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on linus/master v5.16-rc6 next-20211221] [cannot apply to lee-mfd/for-mfd-next helgaas-pci/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/platform-x= 86-introduce-p2sb_bar-helper/20211222-022450 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/f= or-next config: i386-randconfig-a001-20211220 (https://download.01.org/0day-ci/arch= ive/20211222/202112221025.kf8hnQ87-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/5154514cc02b0e14f5af0fe18= a591ca0a86eba51 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/platform-x86-intro= duce-p2sb_bar-helper/20211222-022450 git checkout 5154514cc02b0e14f5af0fe18a591ca0a86eba51 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ld: drivers/mfd/lpc_ich.o: in function `lpc_ich_init_spi': >> drivers/mfd/lpc_ich.c:1137: undefined reference to `p2sb_bar' Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for P2SB Depends on X86 && X86_PLATFORM_DEVICES && X86_PLATFORM_DRIVERS_INTEL && = PCI Selected by - LPC_ICH && HAS_IOMEM && PCI && X86 vim +1137 drivers/mfd/lpc_ich.c 1094 = 1095 static int lpc_ich_init_spi(struct pci_dev *dev) 1096 { 1097 struct lpc_ich_priv *priv =3D pci_get_drvdata(dev); 1098 struct resource *res =3D &intel_spi_res[0]; 1099 struct intel_spi_boardinfo *info; 1100 u32 spi_base, rcba; 1101 = 1102 info =3D devm_kzalloc(&dev->dev, sizeof(*info), GFP_KERNEL); 1103 if (!info) 1104 return -ENOMEM; 1105 = 1106 info->type =3D lpc_chipset_info[priv->chipset].spi_type; 1107 = 1108 switch (info->type) { 1109 case INTEL_SPI_BYT: 1110 pci_read_config_dword(dev, SPIBASE_BYT, &spi_base); 1111 if (spi_base & SPIBASE_BYT_EN) { 1112 res->start =3D spi_base & ~(SPIBASE_BYT_SZ - 1); 1113 res->end =3D res->start + SPIBASE_BYT_SZ - 1; 1114 } 1115 break; 1116 = 1117 case INTEL_SPI_LPT: 1118 pci_read_config_dword(dev, RCBABASE, &rcba); 1119 if (rcba & 1) { 1120 spi_base =3D round_down(rcba, SPIBASE_LPT_SZ); 1121 res->start =3D spi_base + SPIBASE_LPT; 1122 res->end =3D res->start + SPIBASE_LPT_SZ - 1; 1123 = 1124 lpc_ich_test_spi_write(dev, dev->devfn, info); 1125 } 1126 break; 1127 = 1128 case INTEL_SPI_BXT: { 1129 unsigned int spi =3D PCI_DEVFN(13, 2); 1130 int ret; 1131 = 1132 /* 1133 * The P2SB is hidden by BIOS and we need to unhide it in 1134 * order to read BAR of the SPI flash device. Once that is 1135 * done we hide it again. 1136 */ > 1137 ret =3D p2sb_bar(dev->bus, spi, res); 1138 if (ret) 1139 return ret; 1140 = 1141 lpc_ich_test_spi_write(dev, spi, info); 1142 break; 1143 } 1144 = 1145 default: 1146 return -EINVAL; 1147 } 1148 = 1149 if (!res->start) 1150 return -ENODEV; 1151 = 1152 lpc_ich_spi_cell.platform_data =3D info; 1153 lpc_ich_spi_cell.pdata_size =3D sizeof(*info); 1154 = 1155 return mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE, 1156 &lpc_ich_spi_cell, 1, NULL, 0, NULL); 1157 } 1158 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============7098376893721931912==--