From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7537183230221341648==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [RFC 2/2] i2c: designware: Add AMD PSP I2C bus support Date: Thu, 23 Dec 2021 08:26:32 +0800 Message-ID: <202112230819.LF6yKZIf-lkp@intel.com> In-Reply-To: <20211222094558.2098791-3-jsd@semihalf.com> List-Id: --===============7537183230221341648== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jan, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on linux/master rafael-pm/linux-next linus/master v5= .16-rc6 next-20211222] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jan-Dabros/i2c-designware-= Add-support-for-AMD-PSP-semaphore/20211222-174729 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/f= or-next config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20211223= /202112230819.LF6yKZIf-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/d0789fea89a6cfb42f237fd64= 068a7fbc9c7c283 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jan-Dabros/i2c-designware-Add-supp= ort-for-AMD-PSP-semaphore/20211222-174729 git checkout d0789fea89a6cfb42f237fd64068a7fbc9c7c283 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/i2c/busses/i2c-designware-amdpsp.c: In function 'psp_wait_cmd': drivers/i2c/busses/i2c-designware-amdpsp.c:98:25: warning: variable 'and= _mask' set but not used [-Wunused-but-set-variable] 98 | union psp_mbox_cmd_reg and_mask =3D { .val =3D ~0 }; | ^~~~~~~~ drivers/i2c/busses/i2c-designware-amdpsp.c: In function 'psp_send_cmd': >> drivers/i2c/busses/i2c-designware-amdpsp.c:132:2: error: implicit declar= ation of function 'writeq'; did you mean 'writel'? [-Werror=3Dimplicit-func= tion-declaration] 132 | writeq((uintptr_t)__psp_pa((void *)req), &mbox->i2c_req_addr); | ^~~~~~ | writel In file included from include/linux/printk.h:559, from include/linux/kernel.h:20, from include/linux/kernfs.h:9, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from include/linux/i2c.h:13, from drivers/i2c/busses/i2c-designware-amdpsp.c:3: drivers/i2c/busses/i2c-designware-amdpsp.c: In function 'psp_send_i2c_re= q': drivers/i2c/busses/i2c-designware-amdpsp.c:188:25: warning: too many arg= uments for format [-Wformat-extra-args] 188 | dev_dbg(psp_i2c_dev, "Request accepted by PSP after %ums\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:134:15: note: in definition of macro '__dy= namic_func_call' 134 | func(&id, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:166:2: note: in expansion of macro '_dynam= ic_func_call' 166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \ | ^~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:155:2: note: in expansion of macro 'dynamic_d= ev_dbg' 155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~~~~~ include/linux/dev_printk.h:155:23: note: in expansion of macro 'dev_fmt' 155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~ drivers/i2c/busses/i2c-designware-amdpsp.c:188:4: note: in expansion of = macro 'dev_dbg' 188 | dev_dbg(psp_i2c_dev, "Request accepted by PSP after %ums\n", | ^~~~~~~ cc1: some warnings being treated as errors vim +132 drivers/i2c/busses/i2c-designware-amdpsp.c 119 = 120 static int psp_send_cmd(struct psp_i2c_req *req) 121 { 122 struct psp_mbox *mbox =3D (struct psp_mbox *)mbox_iomem; 123 union psp_mbox_cmd_reg cmd_reg =3D {0}; 124 = 125 if (psp_check_mbox_recovery(mbox)) 126 return -EIO; 127 = 128 if (psp_wait_cmd(mbox)) 129 return -EBUSY; 130 = 131 /* Fill address of command-response buffer */ > 132 writeq((uintptr_t)__psp_pa((void *)req), &mbox->i2c_req_addr); 133 = 134 /* Write command register to trigger processing */ 135 cmd_reg.fields.mbox_cmd =3D PSP_I2C_REQ_BUS_CMD; 136 writel(cmd_reg.val, &mbox->fields.val); 137 = 138 if (psp_wait_cmd(mbox)) 139 return -ETIMEDOUT; 140 = 141 if (psp_check_mbox_sts(mbox)) 142 return -EIO; 143 = 144 return 0; 145 } 146 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============7537183230221341648==--