From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E24BDC433F5 for ; Thu, 23 Dec 2021 08:42:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C825982F8E; Thu, 23 Dec 2021 09:42:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1640248937; bh=AbifQomFb39wLxlwYzjndsRuwIhd9ULkowHf2aPtphQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Scey0dYoq2ri6hlTA6d76/ZpbwKBUWx8BrgCHJpoFGhAScNtKLCsU4EL47S/gpQ0W NtrK+Ufl8Hf2OIVRjGBCBKgovSzto68FO+lN1sEox8yAkY6vmlj2MvTtolcOXWjJTV zygYFMIu0lI61PGPwS5AcW2hSBww97wYeGlKU57UmEsZBanxNl/veiKRjWoHgRGLl5 NryARURP5/lSwqZoF7behZ8iq1GT34XfbKv8TR+p91TS6QJmesbjHlczFmonD3sAwd RC2hTlZZl2vMzT4rkcEc5pTpuF1VL5aXZY/dvHS1epSBHQ7yb3mcnRqh7mOqi1PT37 7heoHAkOzhVAQ== Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C8E848142D; Thu, 23 Dec 2021 09:42:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1640248935; bh=AbifQomFb39wLxlwYzjndsRuwIhd9ULkowHf2aPtphQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UyQ8Lvfgi5JYQ1XnTvNvNkRCiNkymAvw9TawHT2locV7NaKAsitLFwNnFcNnWudod MEdenMLsaN9cyKLWQ9rndtbC+b6u+9XpyhCZjQ+n7sA1DSJ8a/d5YWthpLr7llbgwq r81kBz4sqfYJk0stnzvFKDiUmWJ3xwl6WQT/gPWbwAReUhEIecbjNJQ1SmMrDY8e+7 /XukXL3b9v7qPBj0tNnKH7WbfRWg56bwVEb/2wxrFQwVrqjv6zBFS0CK2CgnCxzgyA td/BlWKB2d162XdiaVepQEKVw5rv7ffxFkR7nv6bEwBzFTGF7Vym5LCCMHlV8RX1A+ +saJnSOkvp8eQ== Date: Thu, 23 Dec 2021 09:42:13 +0100 From: Lukasz Majewski To: Tom Rini Cc: u-boot@lists.denx.de, Stefano Babic Subject: Re: [PATCH v1 1/3] arm: xea: Modify board code to generate single binary u-boot Message-ID: <20211223094213.6fdc4f02@ktm> In-Reply-To: <20211222164649.GO2773246@bill-the-cat> References: <20211222124904.2475-1-lukma@denx.de> <20211222164649.GO2773246@bill-the-cat> Organization: denx.de X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/YVI03LdUpgYU8p=BW.1MiKU"; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_/YVI03LdUpgYU8p=BW.1MiKU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Tom, > On Wed, Dec 22, 2021 at 01:49:02PM +0100, Lukasz Majewski wrote: >=20 > > This change provides the possibility to build XEA (imx287 based) > > board U-Boot as a single binary (without support for > > CONFIG_SPL_FRAMEWORK). > >=20 > > The generated u-boot.sb can be used in the factory environment to > > for example perform initial setup or HW testing. > >=20 > > It can be used with 'uuu' utility > > (SDPS: boot -f /srv/tftp/xea/u-boot.sb) > >=20 > > The board_init_ll() is used in arch/arm/cpu/arm926ejs/mxs/start.S, > > which is utilized when CONFIG_SPL_FRAMEWORK is disabled. > >=20 > > However, when it is enabled the arch/arm/cpu/arm926ejs/start.S is > > used, which requires the lowlevel_init() function. > >=20 > > Signed-off-by: Lukasz Majewski > > --- > >=20 > > board/liebherr/xea/spl_xea.c | 8 ++++++++ > > board/liebherr/xea/xea.c | 3 ++- > > 2 files changed, 10 insertions(+), 1 deletion(-) > >=20 > > diff --git a/board/liebherr/xea/spl_xea.c > > b/board/liebherr/xea/spl_xea.c index 192f68fca5f..5ee561b8b78 100644 > > --- a/board/liebherr/xea/spl_xea.c > > +++ b/board/liebherr/xea/spl_xea.c > > @@ -290,6 +290,13 @@ u32 mxs_dram_vals[] =3D { > > 0x00000000, 0xffffffff > > }; > > =20 > > +/* #ifndef CONFIG_SPL_FRAMEWORK */ > > +#if !CONFIG_IS_ENABLED(FRAMEWORK) > > +void board_init_ll(const u32 arg, const uint32_t *resptr) > > +{ > > + mxs_common_spl_init(arg, resptr, iomux_setup, > > ARRAY_SIZE(iomux_setup)); +} > > +#else > > void lowlevel_init(void) > > { > > struct mxs_pinctrl_regs *pinctrl_regs =3D > > @@ -301,3 +308,4 @@ void lowlevel_init(void) > > =20 > > mxs_common_spl_init(0, NULL, iomux_setup, > > ARRAY_SIZE(iomux_setup)); } > > +#endif > > diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c > > index cd11b0ada77..685e2e26a18 100644 > > --- a/board/liebherr/xea/xea.c > > +++ b/board/liebherr/xea/xea.c > > @@ -58,7 +58,8 @@ static void init_clocks(void) > > mxs_set_sspclk(MXC_SSPCLK3, 96000, 0); > > } > > =20 > > -#ifdef CONFIG_SPL_BUILD > > +/* #if CONFIG_SPL_BUILD && CONFIG_SPL_FRAMEWORK */ > > +#if CONFIG_IS_ENABLED(BUILD) && CONFIG_IS_ENABLED(FRAMEWORK) > > void board_init_f(ulong arg) > > { > > init_clocks(); =20 >=20 > I know checkpatch.pl has a warning, but maybe the text needs to be > tweaked there slightly? =20 Yes, exactly - this was done to silence the checkpatch.pl error. > Using CONFIG_IS_ENABLED here is less > readable / clear than CONFIG_SPL_BUILD (which is special) and > CONFIG_SPL_FRAMEWORK (there's no CONFIG_FRAMEWORK and this board > isn't going to use TPL). >=20 If you prefer I can just add the preprocessor code from the above comment. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/YVI03LdUpgYU8p=BW.1MiKU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmHENmUACgkQAR8vZIA0 zr3SUQf9EvwFcoWZhqcSsfqLazqi7Gly9KkAI02uZXMm7uWwj4RmrNOReUda2xT0 XJh3NxDMVVHjhOkeOXnNv15Qyd/3XPf/r3YwTvX+n66D1ossclPPF4qJdc/mS/jC +7+uhaTpvEEImCuzxzsutgulUPSCBQbnQJOqFGaj+jg8s63yDU76iL7WGxUBkFsu d+O1Sy+XVWsHYF4d/H4W2gqRrUwOpBr4VDpIdCluxuNgMbpi3Wcp5Ks7G6D+8ZK9 4Ismm5XTAFWWiq3CCTbZGAaEDtZ+gJVnZ1/4j3cDRtyT5FiuYvM1etU8c+gCC9Uc hvpJ2JMHZREGZK0lbZd6eBXnVn1ORw== =XCAd -----END PGP SIGNATURE----- --Sig_/YVI03LdUpgYU8p=BW.1MiKU--