From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C64AC433FE for ; Fri, 24 Dec 2021 04:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245635AbhLXEXT (ORCPT ); Thu, 23 Dec 2021 23:23:19 -0500 Received: from mga14.intel.com ([192.55.52.115]:27867 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229752AbhLXEXS (ORCPT ); Thu, 23 Dec 2021 23:23:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640319798; x=1671855798; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=GdIKH/iBPvDupvqz2hjBtyd1i8tjlmODP8lZ1Dq9nAY=; b=DvrIOphqApNgHUBCH/Bg5aJHBDp1pBQLoSZPuBFEodhG/l0EGF1Zi8lp 2jJ/czbL/BGL/SFLtRO4/SSz0/FtwkxqMg2a/M/YP0JWfhqXbP0M/GOng A10xvuK3uW0Cd3SN/nP79kuLb51AC6hV6y/qLq4cWAu1doEdKtYGAR/nC FXGwM1mqlDFEFMCWPoVvGkb5vEpH2U8OtFfz7pqlntXzwsdG9/xJQ8Olm tNAMXw3Rnulk1pazuLfKr4q2ka3buL/rgsI3Dx69Z6MEiHVB4iy08/xNf +jTL9X2MlflVLtXupSJTs3NvzxXchpu/LNU3w300BiTLi+02QjQJZzJYw Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="241149080" X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="241149080" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2021 20:23:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="664766834" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.192.101]) by fmsmga001.fm.intel.com with ESMTP; 23 Dec 2021 20:23:11 -0800 Date: Fri, 24 Dec 2021 12:22:34 +0800 From: Chao Peng To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, john.ji@intel.com, susie.li@intel.com, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com Subject: Re: [PATCH v3 kvm/queue 06/16] KVM: Implement fd-based memory using MEMFD_OPS interfaces Message-ID: <20211224042234.GC44042@chaop.bj.intel.com> Reply-To: Chao Peng References: <20211223123011.41044-1-chao.p.peng@linux.intel.com> <20211223123011.41044-7-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Dec 23, 2021 at 06:34:22PM +0000, Sean Christopherson wrote: > On Thu, Dec 23, 2021, Chao Peng wrote: > > > > -kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o $(KVM)/memfd.o > > This should be > > kvm-$(CONFIG_MEMFD_OPS) += $(KVM)/memfd.o > > with stubs provided in a header file as needed. I also really dislike naming KVM's > file memfd.c, though I don't have a good alternative off the top of my head. Is memory-backend.c better? if we end up introducing the callback definition in KVM we can call it CONFIG_KVM_MEMORY_BACKEDN_OPS. Chao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41C1C433EF for ; Fri, 24 Dec 2021 04:25:08 +0000 (UTC) Received: from localhost ([::1]:60686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0c8h-0002ZL-Az for qemu-devel@archiver.kernel.org; Thu, 23 Dec 2021 23:25:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0c71-0001t3-Ur for qemu-devel@nongnu.org; Thu, 23 Dec 2021 23:23:27 -0500 Received: from mga06.intel.com ([134.134.136.31]:9586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0c6y-0001sb-ET for qemu-devel@nongnu.org; Thu, 23 Dec 2021 23:23:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640319800; x=1671855800; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=GdIKH/iBPvDupvqz2hjBtyd1i8tjlmODP8lZ1Dq9nAY=; b=ePV18YlRHtkD2USFgWPqED6GjYbAkg1hZCyF62ocIgt+ptdIWsPVY7Ij LLuccCxCkqQMYRG+v0bONvCdnBCJLtEy8PgdKLAfpQN5p+73n68TAKiQ+ /+Zue//p5VHtGjZrfcBg0R2k3gneZ60z7bOX46mAcxq5uP2Hr7jPldwkZ Cmb6semxrVSpK5ErtMpEd+ahcqEJrBsEHvxt8EAGF7z6s+umwzDDXLIEI P3PQ41m+eUyEdrPv2fqDv/o1BnD8/g/BLkSJajgNhhQt87xPeFrvvhZKq 3o0q3upisw1pG22pV0zvCXQBi49R8rv0w3Ob+0xo61Y6BnSO4q3zM1J5k Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="301688051" X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="301688051" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2021 20:23:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="664766834" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.192.101]) by fmsmga001.fm.intel.com with ESMTP; 23 Dec 2021 20:23:11 -0800 Date: Fri, 24 Dec 2021 12:22:34 +0800 From: Chao Peng To: Sean Christopherson Subject: Re: [PATCH v3 kvm/queue 06/16] KVM: Implement fd-based memory using MEMFD_OPS interfaces Message-ID: <20211224042234.GC44042@chaop.bj.intel.com> References: <20211223123011.41044-1-chao.p.peng@linux.intel.com> <20211223123011.41044-7-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Received-SPF: none client-ip=134.134.136.31; envelope-from=chao.p.peng@linux.intel.com; helo=mga06.intel.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.203, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Chao Peng Cc: Wanpeng Li , jun.nakajima@intel.com, kvm@vger.kernel.org, david@redhat.com, qemu-devel@nongnu.org, "J . Bruce Fields" , linux-mm@kvack.org, "H . Peter Anvin" , ak@linux.intel.com, Jonathan Corbet , Joerg Roedel , x86@kernel.org, Hugh Dickins , Ingo Molnar , Borislav Petkov , luto@kernel.org, Thomas Gleixner , Vitaly Kuznetsov , Jim Mattson , dave.hansen@intel.com, susie.li@intel.com, Jeff Layton , linux-kernel@vger.kernel.org, john.ji@intel.com, Yu Zhang , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , "Kirill A . Shutemov" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Dec 23, 2021 at 06:34:22PM +0000, Sean Christopherson wrote: > On Thu, Dec 23, 2021, Chao Peng wrote: > > > > -kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o $(KVM)/memfd.o > > This should be > > kvm-$(CONFIG_MEMFD_OPS) += $(KVM)/memfd.o > > with stubs provided in a header file as needed. I also really dislike naming KVM's > file memfd.c, though I don't have a good alternative off the top of my head. Is memory-backend.c better? if we end up introducing the callback definition in KVM we can call it CONFIG_KVM_MEMORY_BACKEDN_OPS. Chao