From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B05A5C433F5 for ; Sat, 25 Dec 2021 19:02:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B1B95830CA; Sat, 25 Dec 2021 20:02:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ELJI+/PG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 59BA483041; Sat, 25 Dec 2021 20:02:35 +0100 (CET) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E843983041 for ; Sat, 25 Dec 2021 20:02:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x52e.google.com with SMTP id y22so45341630edq.2 for ; Sat, 25 Dec 2021 11:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mfARSTUPL5CVHtDFt0iH36hqVwzdTPZLgedMW/PVT5I=; b=ELJI+/PGGKqMsal86aDbK0bkSadR6w9/WoNX9F3dzMtbV7QpqUyfwqMv/wvQJuDDcq FoLJv9jhlUKaTsOVxpR4gwbS8FO4XlVcfNV4n2ARhGQ5WxadZmRwGc3CsBjsHRD4m8JO Jg7DoveLWfxz4NP7OtEhgeGey3F8F7dILE4hku0PlYpILsN9J78LXC3trT18mKT7GLUG 33xiDRRqcBUkkAX4VoKyRNanJCXCCXvqQvojnWBj3uS1aD7dbSlG6ZSJduSFu7HdXutM Ay4aKhade3w9YVpdxc0NiiwMrnpuNrJ8dlnSDLDqaqbJd+8+GSKKpEgba5gGKGEjVNmg mphQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mfARSTUPL5CVHtDFt0iH36hqVwzdTPZLgedMW/PVT5I=; b=U8kbqvaM4bHflUJA6H0RdsK4XRYAbi3RdfJCBa/d9ef+9QyP57AzNHr9F0LpfSydhv CkUMXF+eJjwuxT1MH27qRwhwgjj4i0JLplnvWW4X1w/POIhS1mB4PP7kfQe/skfCXgX8 9efc0vSWNAczfjUiPD1RxOb1FEmdqjIkmqX7s9ZLAxljiw04D2F51rZKyQcbcHPGFSap 8FLgcpmJhQPUHr0r3sbCgt8YC7E10ybKAs2l1j8zbpNmPzOd3dc9l513umnfvFtelVTx Gufe+SckHm+hvk8U4KQ7gE8xCi55orYKBwBn7lqlirLQdDUADmLkbK+WLYvLnFgjRqF/ spVg== X-Gm-Message-State: AOAM531Naf/7l/paIFVhYg/Z2vd/nIoPZDF1dhKGMHP0XQz6vgKTZxwf HLimw6QnYm4/98anr2PhySw= X-Google-Smtp-Source: ABdhPJyEi8mR+6Eze63Y+OpsweXiDLHCO8VO0A4ozoUgkFviPTtmNixyuNC2XAeVma1C00HnzKaRmw== X-Received: by 2002:a17:907:7211:: with SMTP id dr17mr8784192ejc.227.1640458951520; Sat, 25 Dec 2021 11:02:31 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id dd5sm3696128ejc.59.2021.12.25.11.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Dec 2021 11:02:30 -0800 (PST) Date: Sat, 25 Dec 2021 20:02:28 +0100 From: Tommaso Merciai To: "Peng Fan (OSS)" Cc: "michael@amarulasolutions.com" , Stefano Babic , Fabio Estevam , dl-uboot-imx , Peng Fan , Ye Li , Simon Glass , Marek Vasut , Frieder Schrempf , Marek =?iso-8859-1?Q?Beh=FAn?= , "Ying-Chun Liu (PaulLiu)" , "u-boot@lists.denx.de" Subject: Re: [RFC PATCH v2 0/3] imx8m: move env_get_location for imx8mn and imx8mp at board level Message-ID: <20211225190228.GA20295@tom-desktop> References: <20211130201729.32728-1-tomm.merciai@gmail.com> <5000444e-19f1-c0ce-3a4a-afdc027e4e7d@oss.nxp.com> <20211223214938.GA7322@tom-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211223214938.GA7322@tom-desktop> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Dec 23, 2021 at 10:49:38PM +0100, Tommaso Merciai wrote: > On Sun, Dec 19, 2021 at 10:11:44AM +0800, Peng Fan (OSS) wrote: > > > > > > On 2021/12/1 4:17, Tommaso Merciai wrote: > > > This series move env_get_location from soc to board level. As suggested > > > by Michael make no sense to define an > > > unique way for multiple board. One board can boot from emmc and having > > > env on spi flash etc.. Anyways, this function is kept in both imx8mn > > > and imx8mp evk boards instead of being completely dropped. > > > (as suggested by Andrey ) > > > > If there are other i.MX8MN/P boards already uses the function, move > > it to i.mx8mn/p_evk would break other boards. If i.MX8MN/P evk are > > the other users, it should be ok to move the board code. > > Hi Peng, > Maybe declare it as __weak in soc.c and ovverride it a board level can > be a valid solution? > Let me know. Hi Peng, Reviewing env_get_location is already declared as __weak, my bad. Then we have to add it in other boards that use imx8mp/imx8mn: - board/phytec/phycore_imx8mp/phycore-imx8mp.c - board/beacon/imx8mn/imx8mn_beacon.c I will try to involve the respective maintainers and resend it in v3. Thanks, Tommaso > > > thanks. > tommaso > > > > > Regards, > > Peng. > > > > > > > > Tommaso Merciai (3): > > > imx8m: drop env_get_location for imx8mn and imx8mp > > > imx: imx8mn_evk: override env_get_location > > > imx: imx8mp_evk: override env_get_location > > > > > > arch/arm/mach-imx/imx8m/soc.c | 39 ------------------------- > > > board/freescale/imx8mn_evk/imx8mn_evk.c | 35 ++++++++++++++++++++++ > > > board/freescale/imx8mp_evk/imx8mp_evk.c | 34 +++++++++++++++++++++ > > > 3 files changed, 69 insertions(+), 39 deletions(-) > > >