From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC076C433EF for ; Sun, 26 Dec 2021 11:46:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 26A1E83041; Sun, 26 Dec 2021 12:46:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oCPvq1JS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CE6298304E; Sun, 26 Dec 2021 12:46:09 +0100 (CET) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8925F83033 for ; Sun, 26 Dec 2021 12:46:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x531.google.com with SMTP id z29so50829362edl.7 for ; Sun, 26 Dec 2021 03:46:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=93I468vC+kSHNmMg3f/a6IUGcOrH/j/7qW5MXGDyD9c=; b=oCPvq1JSgaVYpop7pJbA3XsQIPcsncWmcw7bTnf3ydIihwUMYYtsSRSsspguHJiG/z UoM9h8mgs2K3k5P8VPsMARpcHnlc9ksgLZLlP6jhbrWzVr6/VJo/Rnd3qgQcS7QjZkwl Kn9KSXrSkESxZ3QE6T6P5QFVZDS4T0Ej8lbhCWfwEAQNfZ9ZvVxSadfdZfHpInHRqcpJ 03lKMi86+jw/7kYEbASXzX8gEWloAxA5HnrvgXFdmlXhkuroOpLWSpjr7QLzOlslQsjE Jn5/ePAZ9ISAdxftVAobVEf56Mi+C3nOlE5o6Juk3vLRCTgYBttp1VgO9LgZ6Q5shMI3 C+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=93I468vC+kSHNmMg3f/a6IUGcOrH/j/7qW5MXGDyD9c=; b=jvuTc7zq28rOeCOc68lZE98hqOAFZGHSj7Xr9Ojyd0krdf5uxuH2xYrT/jslhJGvVH SFu41GJqvAhT7lZ20WArupHarbQdgKv2avr/ifdnfRoOxiMMEaQon34ff+sKOaw/QhsP VrINE5UoD/4eezFqSA1x4F5XuJu+/p8l41vO5yVQ9nKqEk/j87Bto1PKxv7krYlNnvVx doq6nhjd1Wiq6yzmQoPskL8oka1N85pBibny5xmA74ke+P0+ZnLdticg1pBZNEBNPnfT Wl6089zlFnk5Nv6T43moww0VUG2jYxZz7AHdqiFCcSmSJJyE3xKQUaoShUQWlbz6mmHi Ph7A== X-Gm-Message-State: AOAM530cGY2U0SsrUezuI9NTCYwA0Nvq7Q0YZZG0VJt9/SLfFNXG9+Go 9PWWSzOzN5HsG8y2ToF8cEZLwb0030w= X-Google-Smtp-Source: ABdhPJxFYRMWiBFCo+53IOmbO/AfmQepCqBjDWULmFZbp3y8EChhsBa1P/CI0NAVVo65Wep8QAeu3Q== X-Received: by 2002:a17:906:3e04:: with SMTP id k4mr732424eji.767.1640519166176; Sun, 26 Dec 2021 03:46:06 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id nb27sm4218755ejc.136.2021.12.26.03.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 03:46:05 -0800 (PST) Date: Sun, 26 Dec 2021 12:46:03 +0100 From: Tommaso Merciai To: Adam Ford Cc: Michael Trimarchi , Teresa Remmet , U-Boot Mailing List Subject: Re: [RFC PATCH v3 4/5] beacon: imx8mn: override env_get_location in imx8mn_beacon.c Message-ID: <20211226114603.GA90947@tom-desktop> References: <20211225202554.47853-1-tomm.merciai@gmail.com> <20211225202554.47853-5-tomm.merciai@gmail.com> <20211226111713.GB27275@tom-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Dec 26, 2021 at 11:23:41AM +0000, Adam Ford wrote: > On Sun, Dec 26, 2021 at 11:17 AM Tommaso Merciai > wrote: > > > On Sun, Dec 26, 2021 at 09:20:30AM +0000, Adam Ford wrote: > > > On Sat, Dec 25, 2021 at 8:26 PM Tommaso Merciai > > > wrote: > > > > > > > Override env_get_location function at board level, previously dropped > > > > down from arch/arm/mach-imx/imx8m/soc.c > > > > > > > > References: > > > > - commit 37d3e3bb95d7532e2503f115dd6c6762fd3b0262 > > > > > > > > > > > I am traveling, so I can't test this. However, I question why not make > > the > > > function __weak and leave it where it was, so we don't have to copy this > > > code from board to board. For those who need something that differs from > > > this, they can write their own function which will replace the standard > > > version. > > > > > > adam > > > > Hi Adam, > > Thanks for your reply. env_get_location function is already declared > > (__weak) in: > > > > - env/env.c > > > > Override 2 times the same function, is that correct? > > > > I didn't know it was already _weak. I am not sure it can be done in two > places. i'm traveling, so i dont have the source code to review it. No problem. Take your time. Thanks, Tommaso > > > > > > I think can be a good solution too, declare it as __weak in soc.c and > > override > > it at board level. > > > > Some References: > > - > > https://developer.arm.com/documentation/dui0491/i/Compiler-specific-Features/--weak > > > > Let me know. > > > > Thanks, > > Tommaso > > > > > > > > > Signed-off-by: Tommaso Merciai > > > > --- > > > > board/beacon/imx8mn/imx8mn_beacon.c | 35 ++++++++++++++++++++++++++++- > > > > 1 file changed, 34 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/board/beacon/imx8mn/imx8mn_beacon.c > > > > b/board/beacon/imx8mn/imx8mn_beacon.c > > > > index 7fe252b262..05ab5613ee 100644 > > > > --- a/board/beacon/imx8mn/imx8mn_beacon.c > > > > +++ b/board/beacon/imx8mn/imx8mn_beacon.c > > > > @@ -6,14 +6,47 @@ > > > > #include > > > > #include > > > > #include > > > > - > > > > +#include > > > > #include > > > > #include > > > > +#include > > > > #include > > > > #include > > > > > > > > DECLARE_GLOBAL_DATA_PTR; > > > > > > > > +enum env_location env_get_location(enum env_operation op, int prio) > > > > +{ > > > > + enum boot_device dev = get_boot_device(); > > > > + enum env_location env_loc = ENVL_UNKNOWN; > > > > + > > > > + if (prio) > > > > + return env_loc; > > > > + > > > > + if (IS_ENABLED(CONFIG_ENV_IS_IN_SPI_FLASH) && dev == > > QSPI_BOOT) { > > > > + env_loc = ENVL_SPI_FLASH; > > > > + } else if (IS_ENABLED(CONFIG_ENV_IS_IN_NAND) && dev == > > NAND_BOOT) { > > > > + env_loc = ENVL_NAND; > > > > + } else if (IS_ENABLED(CONFIG_ENV_IS_IN_MMC)) { > > > > + switch (dev) { > > > > + case SD1_BOOT: > > > > + case SD2_BOOT: > > > > + case SD3_BOOT: > > > > + case MMC1_BOOT: > > > > + case MMC2_BOOT: > > > > + case MMC3_BOOT: > > > > + env_loc = ENVL_MMC; > > > > + break; > > > > + default: > > > > + break; > > > > + } > > > > + } else if (IS_ENABLED(CONFIG_ENV_IS_NOWHERE)) { > > > > + env_loc = ENVL_MMC; > > > > + } > > > > + > > > > + return env_loc; > > > > +} > > > > + > > > > #if IS_ENABLED(CONFIG_FEC_MXC) > > > > static int setup_fec(void) > > > > { > > > > -- > > > > 2.25.1 > > > > > > > > > >