All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Florent AUMAITRE <florent.aumaitre@medianesysteme.com>
Cc: "Manuel Vögele" <develop@manuel-voegele.de>,
	"Asaf Kahlon" <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-pyqt5: Fix parallel build
Date: Mon, 27 Dec 2021 00:00:38 +0100	[thread overview]
Message-ID: <20211227000038.10a692ca@windsurf> (raw)
In-Reply-To: <20211214111330.8720-1-florent.aumaitre@medianesysteme.com>

Hello Florent,

On Tue, 14 Dec 2021 12:13:30 +0100
Florent AUMAITRE <florent.aumaitre@medianesysteme.com> wrote:

> This patch fix build of python-pyqt5 package when parallel build is used
> 
> Signed-off-by: Florent AUMAITRE <florent.aumaitre@medianesysteme.com>

So in fact, if I understand correctly, python-pyqt5 needs the same
fixup as qt5base. Obviously, what we will be looking for is a solution
that does not involve duplicating the logic that we have in qt5.mk
into python-pyqt5.mk.

> +ifeq ($(BR2_PER_PACKAGE_DIRECTORIES),y)
> +define PYTHON_PYQT5_QT_CONF_FIXUP
> +	$(PYTHON_PYQT5_INSTALL_QT_CONF)
> +endef
> +endif
> +
> +PYTHON_PYQT5_PRE_CONFIGURE_HOOKS += PYTHON_PYQT5_QT_CONF_FIXUP

Could you try simply doing:

PYTHON_PYQT5_PRE_CONFIGURE_HOOKS += QT5_QT_CONF_FIXUP

this should automatically re-use the existing QT5_INSTALL_QT_CONF macro
from package/qt5/qt5.mk, which will re-generate the qt.conf file in
your package HOST_DIR.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-12-26 23:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 11:13 [Buildroot] [PATCH 1/1] package/python-pyqt5: Fix parallel build Florent AUMAITRE
2021-12-26 23:00 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211227000038.10a692ca@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=develop@manuel-voegele.de \
    --cc=florent.aumaitre@medianesysteme.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.