All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1] package/assimp: disable -Werror compile flag
Date: Mon, 27 Dec 2021 11:26:20 +0100	[thread overview]
Message-ID: <20211227112620.2159279a@windsurf> (raw)
In-Reply-To: <20211210142531.14746-1-ps.report@gmx.net>

On Fri, 10 Dec 2021 15:25:31 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> Add patch to disable -Werror compile flag.
> 
> Fixes:
> 
>   - http://autobuild.buildroot.net/results/49beb264b8454b9af092278074c4087013692052/
> 
>   .../build/assimp-5.1.3/code/PostProcessing/TriangulateProcess.cpp:285:50: error: argument 1 value ‘4294967294’ exceeds maximum object size 2147483647 [-Werror=alloc-size-larger-than=]
>     285 |     std::unique_ptr<bool[]> done(new bool[max_out]);
>         |                                                  ^
>   [...]
>   .../host/opt/ext-toolchain/powerpc-buildroot-linux-uclibc/include/c++/9.3.0/new:127:26: note: in a call to allocation function ‘void* operator new [](std::size_t)’ declared here
>     127 | _GLIBCXX_NODISCARD void* operator new[](std::size_t) _GLIBCXX_THROW (std::bad_alloc)
>         |                          ^~~~~~~~
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/assimp/0001-code-disable-Werror.patch | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 package/assimp/0001-code-disable-Werror.patch

Even though Arnout had objections, this patch is reasonable, it's
obviously just dropping -Werror, and we indeed try to not build packages
with -Werror in general. So I've applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2021-12-27 10:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 14:25 [Buildroot] [PATCH v1] package/assimp: disable -Werror compile flag Peter Seiderer
2021-12-12 14:41 ` Arnout Vandecappelle
2021-12-12 16:02   ` Peter Seiderer
2021-12-27 10:26 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211227112620.2159279a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=ps.report@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.