From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 05/19] tcp: authopt: Compute packet signatures
Date: Tue, 28 Dec 2021 15:33:01 +0800 [thread overview]
Message-ID: <202112281504.urPHITqZ-lkp@intel.com> (raw)
In-Reply-To: <a0f8121e7efb452971800ee4a556314c4a8ad446.1640273966.git.cdleonard@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 9358 bytes --]
Hi Leonard,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on f4f2970dfd87e5132c436e6125148914596a9863]
url: https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20211223-234349
base: f4f2970dfd87e5132c436e6125148914596a9863
config: sh-randconfig-m031-20211228 (https://download.01.org/0day-ci/archive/20211228/202112281504.urPHITqZ-lkp(a)intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2e5c7ea0fadcbbea7804802dc89d10bb7924dd74
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20211223-234349
git checkout 2e5c7ea0fadcbbea7804802dc89d10bb7924dd74
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash net/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
cc1: warning: arch/sh/include/mach-rsk: No such file or directory [-Wmissing-include-dirs]
cc1: warning: arch/sh/include/mach-rsk: No such file or directory [-Wmissing-include-dirs]
net/ipv4/tcp_authopt.c:217:6: warning: no previous prototype for 'tcp_authopt_free' [-Wmissing-prototypes]
217 | void tcp_authopt_free(struct sock *sk, struct tcp_authopt_info *info)
| ^~~~~~~~~~~~~~~~
In file included from include/linux/tcp.h:19,
from include/net/tcp_authopt.h:7,
from net/ipv4/tcp_authopt.c:3:
net/ipv4/tcp_authopt.c: In function 'tcp_authopt_ahash_traffic_key':
>> include/net/sock.h:389:37: error: 'struct sock_common' has no member named 'skc_v6_rcv_saddr'; did you mean 'skc_rcv_saddr'?
389 | #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
| ^~~~~~~~~~~~~~~~
net/ipv4/tcp_authopt.c:574:70: note: in expansion of macro 'sk_v6_rcv_saddr'
574 | err = crypto_ahash_buf(pool->req, (u8 *)&sk->sk_v6_rcv_saddr, 16);
| ^~~~~~~~~~~~~~~
>> include/net/sock.h:388:45: error: 'struct sock_common' has no member named 'skc_v6_daddr'; did you mean 'skc_daddr'?
388 | #define sk_v6_daddr __sk_common.skc_v6_daddr
| ^~~~~~~~~~~~
net/ipv4/tcp_authopt.c:577:70: note: in expansion of macro 'sk_v6_daddr'
577 | err = crypto_ahash_buf(pool->req, (u8 *)&sk->sk_v6_daddr, 16);
| ^~~~~~~~~~~
net/ipv4/tcp_authopt.c: In function 'tcp_authopt_hash_packet':
>> include/net/sock.h:389:37: error: 'struct sock_common' has no member named 'skc_v6_rcv_saddr'; did you mean 'skc_rcv_saddr'?
389 | #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
| ^~~~~~~~~~~~~~~~
net/ipv4/tcp_authopt.c:811:38: note: in expansion of macro 'sk_v6_rcv_saddr'
811 | saddr = &sk->sk_v6_rcv_saddr;
| ^~~~~~~~~~~~~~~
>> include/net/sock.h:388:45: error: 'struct sock_common' has no member named 'skc_v6_daddr'; did you mean 'skc_daddr'?
388 | #define sk_v6_daddr __sk_common.skc_v6_daddr
| ^~~~~~~~~~~~
net/ipv4/tcp_authopt.c:812:38: note: in expansion of macro 'sk_v6_daddr'
812 | daddr = &sk->sk_v6_daddr;
| ^~~~~~~~~~~
At top level:
net/ipv4/tcp_authopt.c:863:12: warning: '__tcp_authopt_calc_mac' defined but not used [-Wunused-function]
863 | static int __tcp_authopt_calc_mac(struct sock *sk,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +389 include/net/sock.h
4dc6dc7162c08b Eric Dumazet 2009-07-15 368
68835aba4d9b74 Eric Dumazet 2010-11-30 369 #define sk_dontcopy_begin __sk_common.skc_dontcopy_begin
68835aba4d9b74 Eric Dumazet 2010-11-30 370 #define sk_dontcopy_end __sk_common.skc_dontcopy_end
4dc6dc7162c08b Eric Dumazet 2009-07-15 371 #define sk_hash __sk_common.skc_hash
5080546682bae3 Eric Dumazet 2013-10-02 372 #define sk_portpair __sk_common.skc_portpair
05dbc7b59481ca Eric Dumazet 2013-10-03 373 #define sk_num __sk_common.skc_num
05dbc7b59481ca Eric Dumazet 2013-10-03 374 #define sk_dport __sk_common.skc_dport
5080546682bae3 Eric Dumazet 2013-10-02 375 #define sk_addrpair __sk_common.skc_addrpair
5080546682bae3 Eric Dumazet 2013-10-02 376 #define sk_daddr __sk_common.skc_daddr
5080546682bae3 Eric Dumazet 2013-10-02 377 #define sk_rcv_saddr __sk_common.skc_rcv_saddr
^1da177e4c3f41 Linus Torvalds 2005-04-16 378 #define sk_family __sk_common.skc_family
^1da177e4c3f41 Linus Torvalds 2005-04-16 379 #define sk_state __sk_common.skc_state
^1da177e4c3f41 Linus Torvalds 2005-04-16 380 #define sk_reuse __sk_common.skc_reuse
055dc21a1d1d21 Tom Herbert 2013-01-22 381 #define sk_reuseport __sk_common.skc_reuseport
9fe516ba3fb29b Eric Dumazet 2014-06-27 382 #define sk_ipv6only __sk_common.skc_ipv6only
26abe14379f8e2 Eric W. Biederman 2015-05-08 383 #define sk_net_refcnt __sk_common.skc_net_refcnt
^1da177e4c3f41 Linus Torvalds 2005-04-16 384 #define sk_bound_dev_if __sk_common.skc_bound_dev_if
^1da177e4c3f41 Linus Torvalds 2005-04-16 385 #define sk_bind_node __sk_common.skc_bind_node
8feaf0c0a5488b Arnaldo Carvalho de Melo 2005-08-09 386 #define sk_prot __sk_common.skc_prot
07feaebfcc10cd Eric W. Biederman 2007-09-12 387 #define sk_net __sk_common.skc_net
efe4208f47f907 Eric Dumazet 2013-10-03 @388 #define sk_v6_daddr __sk_common.skc_v6_daddr
efe4208f47f907 Eric Dumazet 2013-10-03 @389 #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
33cf7c90fe2f97 Eric Dumazet 2015-03-11 390 #define sk_cookie __sk_common.skc_cookie
70da268b569d32 Eric Dumazet 2015-10-08 391 #define sk_incoming_cpu __sk_common.skc_incoming_cpu
8e5eb54d303b7c Eric Dumazet 2015-10-08 392 #define sk_flags __sk_common.skc_flags
ed53d0ab761f5c Eric Dumazet 2015-10-08 393 #define sk_rxhash __sk_common.skc_rxhash
efe4208f47f907 Eric Dumazet 2013-10-03 394
43f51df4172955 Eric Dumazet 2021-11-15 395 /* early demux fields */
43f51df4172955 Eric Dumazet 2021-11-15 396 struct dst_entry *sk_rx_dst;
43f51df4172955 Eric Dumazet 2021-11-15 397 int sk_rx_dst_ifindex;
43f51df4172955 Eric Dumazet 2021-11-15 398 u32 sk_rx_dst_cookie;
43f51df4172955 Eric Dumazet 2021-11-15 399
^1da177e4c3f41 Linus Torvalds 2005-04-16 400 socket_lock_t sk_lock;
9115e8cd2a0c6e Eric Dumazet 2016-12-03 401 atomic_t sk_drops;
9115e8cd2a0c6e Eric Dumazet 2016-12-03 402 int sk_rcvlowat;
9115e8cd2a0c6e Eric Dumazet 2016-12-03 403 struct sk_buff_head sk_error_queue;
b178bb3dfc30d9 Eric Dumazet 2010-11-16 404 struct sk_buff_head sk_receive_queue;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 405 /*
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 406 * The backlog queue is special, it is always used with
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 407 * the per-socket spinlock held and requires low latency
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 408 * access. Therefore we special case it's implementation.
b178bb3dfc30d9 Eric Dumazet 2010-11-16 409 * Note : rmem_alloc is in this structure to fill a hole
b178bb3dfc30d9 Eric Dumazet 2010-11-16 410 * on 64bit arches, not because its logically part of
b178bb3dfc30d9 Eric Dumazet 2010-11-16 411 * backlog.
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 412 */
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 413 struct {
b178bb3dfc30d9 Eric Dumazet 2010-11-16 414 atomic_t rmem_alloc;
b178bb3dfc30d9 Eric Dumazet 2010-11-16 415 int len;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 416 struct sk_buff *head;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 417 struct sk_buff *tail;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 418 } sk_backlog;
f35f821935d8df Eric Dumazet 2021-11-15 419 struct llist_head defer_list;
f35f821935d8df Eric Dumazet 2021-11-15 420
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-28 7:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 15:39 [PATCH v4 00/19] tcp: Initial support for RFC5925 auth option Leonard Crestez
2021-12-23 15:39 ` [PATCH v4 01/19] tcp: authopt: Initial support and key management Leonard Crestez
2021-12-23 15:39 ` [PATCH v4 02/19] docs: Add user documentation for tcp_authopt Leonard Crestez
2021-12-23 15:39 ` [PATCH v4 03/19] tcp: authopt: Add crypto initialization Leonard Crestez
2021-12-23 15:39 ` [PATCH v4 04/19] tcp: md5: Refactor tcp_sig_hash_skb_data for AO Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 05/19] tcp: authopt: Compute packet signatures Leonard Crestez
2021-12-28 7:33 ` kernel test robot [this message]
2021-12-23 15:40 ` [PATCH v4 06/19] tcp: authopt: Hook into tcp core Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 07/19] tcp: authopt: Disable via sysctl by default Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 08/19] tcp: authopt: Implement Sequence Number Extension Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 09/19] tcp: ipv6: Add AO signing for tcp_v6_send_response Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 10/19] tcp: authopt: Add support for signing skb-less replies Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 11/19] tcp: ipv4: Add AO signing for " Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 12/19] tcp: authopt: Add key selection controls Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 13/19] tcp: authopt: Add initial l3index support Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 14/19] tcp: authopt: Add NOSEND/NORECV flags Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 15/19] tcp: authopt: Add prefixlen support Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 16/19] tcp: authopt: Add /proc/net/tcp_authopt listing all keys Leonard Crestez
2021-12-25 21:04 ` kernel test robot
2021-12-25 21:04 ` kernel test robot
2021-12-23 15:40 ` [PATCH v4 17/19] selftests: nettest: Rename md5_prefix to key_addr_prefix Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 18/19] selftests: nettest: Initial tcp_authopt support Leonard Crestez
2021-12-23 15:40 ` [PATCH v4 19/19] selftests: net/fcnal: " Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112281504.urPHITqZ-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.