Re: [Buildroot] [PATCH v2 1/1] package/nodejs: expose capability to compile host library

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Martin Bark <martin@barkynet.com>,
	Linus Kaschulla <linus@cosmos-ink.net>,
	Daniel Price <daniel.price@gmail.com>,
	Adam Duskett <aduskett@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/nodejs: expose capability to compile host library
Date: Tue, 28 Dec 2021 22:58:05 +0100	[thread overview]
Message-ID: <20211228225805.47df3c46@windsurf> (raw)
In-Reply-To: <20211023050119.3293369-1-james.hilliard1@gmail.com>

On Fri, 22 Oct 2021 23:01:19 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> From: Linus Kaschulla <linus@cosmos-ink.net>
> 
> To use nodejs on the host (independant of the actual system)
> to create some static files to place onto the target rootfs
> nodejs can be very helpful.
> 
> The provided nodejs package didn't show the possibility to
> create a host package. But upon further examination I noticed
> that the package does it in fact (in the .mk). It specifies
> dependencies for the package with the host prefix and also
> invokes $(host-generic-package) as well as $(generic-package)
> which is the only one assumed from the config.
> 
> With this change other packages can require BR2_PACKAGE_HOST_NODEJS
> without any problems or the buildsystem not fully knowing about this.
> Seems that someone added the capability (as a step for the cross-
> compiled nodejs) and didn't notice that this is a handy package by itself.
> 
> When installing global npm packages (with -g), the parameter
> `--prefix $(HOST_DIR)` can be used to ensure that nodejs doesn't try
> to install it onto the real host filesystem.
> 
> I already used this change to create static web files from Angular
> and place onto a target that doesn't need nodejs itself.
> 
> This patch contains fixes based on feedback from:
> - Peter Seiderer <ps.report@gmx.net>
> - Yann E. MORIN <yann.morin.1998@free.fr>
> 
> Signed-off-by: Linus Kaschulla <linus@cosmos-ink.net>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2:
>   - move nodejs 14 dependency selection to host package
> ---
>  package/Config.in.host        |  1 +
>  package/nodejs/Config.in      |  6 +-----
>  package/nodejs/Config.in.host | 13 +++++++++++++
>  3 files changed, 15 insertions(+), 5 deletions(-)
>  create mode 100644 package/nodejs/Config.in.host

I've applied to master, after significantly simplifying the commit log,
which was a bit verbose for no good reason.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot