From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: James Knight <james.knight@collins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/glibmm: needs BR2_TOOLCHAIN_HAS_SYNC_4
Date: Wed, 29 Dec 2021 11:20:37 +0100 [thread overview]
Message-ID: <20211229112037.2e9002dc@windsurf> (raw)
In-Reply-To: <20211229095600.212449-1-giulio.benetti@benettiengineering.com>
Hello Giulio,
On Wed, 29 Dec 2021 10:56:00 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Add BR2_TOOLCHAIN_HAS_SYNC_4 and restyle the with "|| \" form.
>
> Fixes:
> http://autobuild.buildroot.net/results/6a2/6a2709956fbb16ac3cbf676acb242c88f83fcdae/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/glibmm/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
> index 2dfc861817..1b27f8cbb1 100644
> --- a/package/glibmm/Config.in
> +++ b/package/glibmm/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_GLIBMM
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_USE_WCHAR # libglib2
> depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4
Not the correct fix: you're confusing the sync built-ins with the atomic
built-ins. Fabrice sent the correct fix a few minutes before yours :-)
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-12-29 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 9:56 [Buildroot] [PATCH] package/glibmm: needs BR2_TOOLCHAIN_HAS_SYNC_4 Giulio Benetti
2021-12-29 10:20 ` Thomas Petazzoni [this message]
2021-12-29 12:45 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211229112037.2e9002dc@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=james.knight@collins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.