Re: [RFC PATCH 09/12] module: Move kallsyms support into a separate file

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3878 bytes --]

Hi Aaron,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on jeyu/modules-next]
[also build test WARNING on v5.16-rc7 next-20211224]
[cannot apply to linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aaron-Tomlin/module-Move-all-into-module/20211229-063051
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git modules-next
config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20211230/202112301104.CFQGCV4b-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/dca0a654ac33ddd67bc916d2b906e610d94d9dfc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aaron-Tomlin/module-Move-all-into-module/20211229-063051
        git checkout dca0a654ac33ddd67bc916d2b906e610d94d9dfc
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   kernel/module/kallsyms.c: note: in included file:
   include/linux/module.h:380:3: sparse: sparse: symbol 'mod_tree' was not declared. Should it be static?
   kernel/module/kallsyms.c:178:23: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct mod_kallsyms [noderef] __rcu *kallsyms @@     got void * @@
   kernel/module/kallsyms.c:178:23: sparse:     expected struct mod_kallsyms [noderef] __rcu *kallsyms
   kernel/module/kallsyms.c:178:23: sparse:     got void *
>> kernel/module/kallsyms.c:486:52: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct mod_kallsyms *kallsyms @@     got struct mod_kallsyms [noderef] __rcu *kallsyms @@
   kernel/module/kallsyms.c:486:52: sparse:     expected struct mod_kallsyms *kallsyms
   kernel/module/kallsyms.c:486:52: sparse:     got struct mod_kallsyms [noderef] __rcu *kallsyms
   kernel/module/kallsyms.c:180:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:181:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:183:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:184:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:193:18: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:194:35: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:195:20: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:200:32: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:203:45: sparse: sparse: dereference of noderef expression

vim +486 kernel/module/kallsyms.c

   473	
   474	#ifdef CONFIG_LIVEPATCH
   475	int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
   476						     struct module *, unsigned long),
   477					   void *data)
   478	{
   479		struct module *mod;
   480		unsigned int i;
   481		int ret = 0;
   482	
   483		mutex_lock(&module_mutex);
   484		list_for_each_entry(mod, &modules, list) {
   485			/* We hold module_mutex: no need for rcu_dereference_sched */
 > 486			struct mod_kallsyms *kallsyms = mod->kallsyms;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org