From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5256BC433F5 for ; Thu, 30 Dec 2021 15:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SESH92s/m0EctE1tprqy4ZHu++pNjz6pn6O31lIF3EM=; b=uCcE+UcCTbVkgo tI5qF/uww/R4FBJyAAk7vtMpMWeIySSaoL8A50DC5MNTRqIuDWLyZ/4n+rAINfUHjKc3KZihpwl82 uhQZsEjqB4x4KT4LfFQjJCmUxRHZTy6jb8lx6yF1ZA7N+MybgBJSUd5n6/KrF3mIYtGGKeYzPe65/ W4rNwR6aexcIQ2f4oc5pwSjjRi+UwUGMylTMHnoGF5Ix9ds8MU3e2hWJTLYHF4TmWfnRT3fcP0LOr VpZvR2EzDpM42p5crwdUYl612OfUg6zpvbOwhaZrKA7suzn7g+kRkM7NEtiMHUy1xEqXFgI6hKh44 kWaQ1k6AOv0mxKcS82vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2xlq-004hQy-Fj; Thu, 30 Dec 2021 15:55:14 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2xlm-004hQK-GY for linux-mtd@lists.infradead.org; Thu, 30 Dec 2021 15:55:13 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 8792C20000E; Thu, 30 Dec 2021 15:54:56 +0000 (UTC) Date: Thu, 30 Dec 2021 16:54:55 +0100 From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , Cc: Mark Brown , , Julien Su , Jaime Liao , Boris Brezillon , Thomas Petazzoni , Xiangsheng Hou Subject: Re: [PATCH v8 00/14] External ECC engines & Macronix support Message-ID: <20211230165455.7b76fe23@xps13> In-Reply-To: <20211221174844.56385-1-miquel.raynal@bootlin.com> References: <20211221174844.56385-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_075510_881142_BE65EA18 X-CRM114-Status: GOOD ( 37.43 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFyaywKCm1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20gd3JvdGUgb24gVHVlLCAyMSBEZWMg MjAyMSAxODo0ODozMCArMDEwMDoKCj4gSGVsbG8gYWxsLAo+IAo+IEkndmUgYXBwbGllZCB0aGUg YmVnaW5uaW5nIG9mIHRoZSBzZXJpZXMgKGJpbmRpbmdzICsgRUNDIHBhcnQpIGluIGEKPiBicmFu Y2ggbmFtZWQgc3BpLW1lbS1lY2Mgb24gdGhlIE1URCBrb3JnIHJlcG9zaXRvcnksIGhlbmNlIG5v dyBJIGFtCj4gcmUtc2VuZGluZyBvbmx5IHRoZSBzZWNvbmQgaGFsdmUsIGluY2x1ZGluZyBzcGkt bWVtIGFuZCBzcGkgY2hhbmdlcywKPiBtb3N0bHkuIFdoZW4gdGhhdCBzZWNvbmQgcGFydCB3aWxs IGJlIHZhbGlkYXRlZCwgSSB3aWxsIGFwcGx5IGl0IG9uIHRvcAo+IG9mIHRoZSBzcGktbWVtLWVj YyBicmFuY2ggYW5kIHNldCBhbiBpbW11dGFibGUgdGFnLCBzaGFyZWQgd2l0aCB0aGUgc3BpCj4g dHJlZS4KCkkgd2FzIGhvcGluZyBmb3IgbW9yZSBmZWVkYmFjayAoZnJvbSBUdWRvciBhbmQgcGVy aGFwcyBCb3JpcyBhcyB3ZWxsPykKc28gYXMgd2UgYXJlIGluIHRoZSBtaWRkbGUgb2YgdGhlIENo cmlzdG1hcy9uZXcgeWVhciBicmVhayBJIGRlY2lkZWQKbm90IHRvIGFwcGx5IHRoaXMgc2VyaWVz IGZvciBteSBuZXh0IHB1bGwtcmVxdWVzdCB0byBMaW51cy4KCkkgd2lsbCB3YWl0IGEgYml0IG1v cmUgdW50aWwgLXJjMSBpcyBvdXQgYW5kIHRoZW4gSSB3aWxsIHJlYmFzZSB0aGUKZmlyc3QgaGFs ZiBvZiB0aGUgc2VyaWVzIChhbHJlYWR5IGFwcGxpZWQgb24gdGhlIHNwaS1tZW0tZWNjIGJyYW5j aCBvbgp0aGUgbXRkIHJlcG9zaXRvcnkpIGFuZCBhZGQgdGhlc2UgMTQgcGF0Y2hlcyBvbiB0b3Ag b2YgaXQgYmVmb3JlIHNoYXJpbmcKaXQgd2l0aCB5b3UgJ29mZmljaWFsbHknLgoKSGFwcHkgbmV3 IHllYXIsCk1pcXXDqGwKCj4gCj4gQ2hlZXJzLAo+IE1pcXXDqGwKPiAKPiBDaGFuZ2VzIGluIHY4 Ogo+ICogQXBwbGllZCB0aGlzIHBhdGNoIGZyb20gUHJhdHl1c2ggYXQgdGhlIGJlZ2lubmluZyBv ZiBteSBzZXJpZXM6Cj4gICBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMTA1MzExODE3 NTcuMTk0NTgtNS1wLnlhZGF2QHRpLmNvbS8KPiAgIE1hZGUgdGhlIG5lY2Vzc2FyeSBjaGFuZ2Vz IGluIHRoZSBmb2xsb3dpbmcgY29tbWl0cy4KPiAqIENoYW5nZWQgdGhlIHNwaS1tZW0tb3AgZWNj X2VuIHBhcmFtZXRlciB0byBiZWNvbWUgZWNjIGFuZCBtYXRjaCB0aGUKPiAgIGR0ciBwYXJhbWV0 ZXIuIENoYW5nZWQgaXRzIHR5cGUgdG8gInU4IDogMSIgYXMgd2VsbCBmb3IgdGhlIHNhbWUKPiAg IHJlYXNvbi4gTW92ZWQgaXQgdG8gdGhlIGRhdGEgc3ViLXN0cnVjdHVyZSBhcyBhZHZpc2VkIGJ5 IFByYXR5dXNoLgo+ICogQWRkZWQgdGhlIHJlY2VpdmVkIEFja3MvUi1ieS4KPiAKPiBDaGFuZ2Vz IGluIHY3Ogo+ICogQWRkZWQgYSBtYWNybyB0byBjaGVjayBpZiB0aGUgY2FwcyBhcmUgcHJlc2Vu dCBvciBub3QgYmVmb3JlIGFjY2Vzc2luZwo+ICAgdGhlbS4gVGhpcyBhbGxvd3MgZm9yIG9wdGlv bmFsIGNhcHMuCj4gKiBEcm9wcGVkIHRoZSAnbm8tY2FwcycgaW5zdGFuY2UgY3JlYXRlZCBpbiB2 Ni4KPiAqIFJld29ya2VkIGEgYml0IGFsbCB0aGUgcGF0Y2hlcyB1c2luZyB0aGVzZSBjYXBzIHRv IGhhdmUgYSBuaWNlIGFuZAo+ICAgYmlzZWN0YWJsZSBzZXJpZXMsIGxpa2UgYWRkaW5nIG1pc3Np bmcgc3RhdGljIGtleXdvcmRzLgo+IAo+IENoYW5nZXMgaW4gdjY6Cj4gKiBSZS1pbmNsdWRlIHRo ZSBmaXJzdCBwYXRjaGVzIGJlY2F1c2UgYSBmZXcgdGhpbmdzIGhhdmUgY2hhbmdlZCBpbiB0aGUK PiAgIGJpbmRpbmdzLiBUaGVzZSBhcmUgb25seSBzdHlsZSBjaGFuZ2VzIGFzIFJvYiBhc2tlZCB0 byBncm91cCBldmVyeQo+ICAgcHJvcGVydHkgYWJvdmUgb3IgYmVsb3cgdGhlIGRlc2NyaXB0aW9u IGZpZWxkLCB3aGljaCBJIGFwcGxpZWQgdG8gYWxsCj4gICB0aGUgYmluZGluZyBjb21taXRzLCBi dXQgd2l0aG91dCBhbnkgZnVydGhlciB1cGRhdGUuCj4gKiBDcmVhdGVkIGEgc3BpLW1lbSBjYXBh YmlsaXRpZXMgc3RydWN0dXJlLiBQdXQgdGhhdCBvbmUgaW4gdGhlIHNwaS1tZW0KPiAgIG9wcyBz dHJ1Y3VyZSBhbmQgZW5zdXJlZCB0aGF0IGFsbCB0aGUgY29udHJvbGxlcnMgcHJvdmlkZWQgb25l Lgo+ICogQ3JlYXRlZCBhIGRlZmF1bHQgIm5vLWNhcHMiIGVtcHR5IGluc3RhbmNlIHRoYXQgY29u dHJvbGxlciBkcml2ZXJzIGNhbgo+ICAgcG9pbnQgdG8gYnkgZGVmYXVsdC4KPiAqIERyb3BwZWQg dGhlIHNwaV9tZW1fZ2VuZXJpY19kZWZhdWx0c19vcCgpIGludGVybWVkaWF0ZSBoZWxwZXIgZW50 aXJlbHkKPiAgIChub3QgbmVlZGVkIGFueW1vcmUpLgo+IAo+IENoYW5nZXMgaW4gdjU6Cj4gKiBN b3ZlZCBhIGhlbHBlciBpbiB0aGUgY29yZSBhcyBpdCBzZWVtcyB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsIGZvcgo+ICAgb3RoZXIgRUNDIGVuZ2luZXMgYXMgd2VsbCAoWGlhbmdzaGVuZyBIb3UgZm9y IE1lZGlhdGVrIHdpbGwgbmVlZCBpdCkuCj4gKiBDaGFuZ2VkIHRoZSBwYXJhbWV0ZXJzIG9mIHRo ZSBzcGlfbWVtX2dlbmVyaWNfc3VwcG9ydHNfb3AoKSBmdW5jdGlvbgo+ICAgaW4gb3JkZXIgdG8g dGFrZSBhIHN0cnVjdHVyZSBhcyBpbnB1dCBpbnN0ZWFkIG9mIGEgbGlzdCBvZiBhcmd1bWVudHMs Cj4gICB3aGljaCB3aWxsIGJlIG11Y2ggZWFzaWVyIHRvIGNvbXBsZW1lbnQgaW4gdGhlIGZ1dHVy ZSBpZiBldmVyIG5lZWRlZC4KPiAKPiBDaGFuZ2VzIGluIHY0Ogo+ICogVGhlIGZpcnN0IGhhbGYg b2YgdGhlIHNlcmllcyBoYXMgYmVlbiBsZWZ0IGFzaWRlIChhbGwgdGhlIGJpbmRpbmcKPiAgIGNo YW5nZXMgKyB0aGUgZXh0ZXJuYWwgbW9kZSBpbiB0aGUgTWFjcm9uaXggZHJpdmVyKSwgbm93IGxl dCdzIGZvY3VzCj4gICBvbiB0aGUgcGlwZWxpbmVkIG1vZGUuCj4gKiBBZGRlZCB0aGUgZWNjX2Vu IHNwaV9tZW1fb3Agc3RydWN0dXJlIHBhcmFtZXRlciBpbiBhIGRlZGljYXRlZCBjb21taXQuCj4g KiBJbnRyb2R1Y2VkIGEgbmV3IGhlbHBlciBmb3Igc3VwcG9ydGluZyBnZW5lcmljYWxseSB0aGUg c3VwcG9ydGVkIG9wcy4KPiAqIFVzZWQgdGhpcyBuZXcgaGVscGVyIGluIHRoZSBtYWNyb25peCBk cml2ZXIuCj4gKiBCeSBkZWZhdWx0IGFsbCB0aGUgb3RoZXIgZHJpdmVycyB3b3VsZCByZWZ1c2Ug YSBzcGlfbWVtX29wIHdpdGggZWNjX2VuCj4gICBlbmFibGVkLgo+IAo+IENoYW5nZXMgaW4gdjM6 Cj4gKiBBZGRlZCBNYXJrJ3MgUi1ieS4KPiAqIEFkZGVkIGEgY29tbWl0IGNoYW5naW5nIHRoZSBp bml0aWFsaXphdGlvbiBvcmRlciBiZXR3ZWVuIHRoZSBkaXJtYXBzCj4gICBhbmQgdGhlIEVDQyBl bmdpbmUgc28gdGhhdCB0aGUgY29yZSBtaWdodCBub3cgaWYgd2UgYXJlIHVzaW5nIGEKPiAgIHBp cGVsaW5lZCBlbmdpbmUgb3Igbm90Lgo+ICogU3RvcHBlZCBjcmVhdGluZyBhZGRpdGlvbmFsIGRp cm1hcHMgd2l0aCBFQ0MgaWYgdGhlIGVuZ2luZSBpcyBub3QgYQo+ICAgcGlwZWxpbmVkIGVuZ2lu ZS4KPiAqIFNvbHZlZCB0aGUga2VybmVsIHRlc3Qgcm9ib3QgcmVwb3J0cy4gSW4gcGFydGljdWxh ciwgSSBhZGRlZCBhCj4gICBkZXBlbmRlbmN5IG9uIE1URF9OQU5EX0VDQyB0byBNYWNyb25peCBT UEkgY29udHJvbGxlciBkcml2ZXIuCj4gKiBBZGRlZCBhIHBhdGNoIHRvIGNsZWFuIHRoZSBOQU5E IGNvbnRyb2xsZXIgeWFtbCBmaWxlIGJlZm9yZSBtb3ZpbmcKPiAgIHNvbWUgYml0cyB0byBuYW5k LWNoaXAueWFtbC4gVGhpcyBhZGRyZXNzZXMgdGhlIGNvbW1lbnRzIG1hZGUgYnkgUm9iCj4gICBh Ym91dCB0aGUgdXNlbGVzcyBhbGxPZidzLgo+ICogVXNlZCBwbGF0Zm9ybV9nZXRfaXJxX2J5bmFt ZV9vcHRpb25hbCgpIGluIG9yZGVyIHRvIGF2b2lkIHVzZWxlc3MKPiAgIHdhcm5pbmdzIHdoZW4g dGhlcmUgaXMgbm8gSVJRLgo+IAo+IENoYW5nZXMgaW4gdjI6Cj4gKiBGaXhlZCB0aGUgYmluZGlu Z3MgYW5kIGFkZGVkIFJvYidzIGFja3Mgd2hlbiByZWxldmFudC4KPiAqIEFkZGVkIGxvY2tpbmcg aW4gdGhlIEVDQyBlbmdpbmUgZHJpdmVyLgo+ICogQnJvdWdodCBtb3JlIGNoYW5nZXMgaW4gdGhl IGNvcmUgaW4gb3JkZXIgdG8gYnJpbmcgdGhlIEVDQyBpbmZvcm1hdGlvbgo+ICAgaW50byB0aGUg c3BpX21lbV9vcCBzdHJ1Y3R1cmUgd2l0aCB0aGUgaWRlYSBvZiBhdm9pZGluZyBhbnkgcmFjZXMK PiAgIGJldHdlZW4gcGFyYWxsZWwgY2FsbHMgb24gdGhlIHNhbWUgZW5naW5lLgo+ICogUmVvcmdh bml6ZWQgdGhlIEVDQyBkcml2ZXIgZW50aXJlbHkgaW4gb3JkZXIgdG8gaGF2ZSBhIHBlci1lbmdp bmUgbXhpYwo+ICAgc3RydWN0dXJlIHBsdXMgYSBwZXItTkFORCBjb250ZXh0LiBUaGlzIGxlYWQg dG8gYSBudW1iZXIgb2YgY2hhbmdlcwo+ICAgaW50ZXJuYWxseSB3aGljaCBjYW5ub3QgYWxsIGJl IGxpc3RlZC4KPiAKPiBDaGFuZ2VzIHNpbmNlIHRoZSBSRkM6Cj4gKiBSZWJhc2VkIG9uIHRvcCBv ZiB2NS4xNS1yYzEuCj4gKiBGaXhlZCB0aGUgZGlybWFwIGNvbmZpZ3VyYXRpb24uCj4gKiBBZGRl ZCB0aGUgdmFyaW91cyB0YWdzIHJlY2VpdmVkLgo+ICogRml4ZWQgdGhlIGJpbmRpbmdzIGFzIHJl cG9ydGVkIGJ5IHRoZSByb2JvdHMuCj4gKiBGaXhlZCB0aGUgcmV0dXJuIHZhbHVlIG9mIHRoZSBo ZWxwZXIgY291bnRpbmcgYml0ZmxpcHMuCj4gKiBJbmNsdWRlZCBhIGZpeCBmcm9tIEphaW1lIExp YW8gaW4gdGhlIGV4dGVybmFsIHBhdHRlcm4gbG9naWMuCj4gKiBBZGRlZCB0aGUgeWFtbCBjb252 ZXJzaW9uIG9mIE1hY3Jvbml4IFNQSSBjb250cm9sbGVyIGRlc2NyaXB0aW9uLgo+ICogQWRkZWQg dGhlIHlhbWwgY29udmVyc2lvbiBvZiB0aGUgU1BJLU5BTkQgZGVzY3JpcHRpb24uCj4gKiBDcmVh dGVkIGEgbmFuZC1jaGlwLnlhbWwgZmlsZSB0byBzaGFyZSBwcm9wZXJ0aWVzIGJldHdlZW4gU1BJ LU5BTkQgYW5kCj4gICByYXcgTkFORC4KPiAKPiBNaXF1ZWwgUmF5bmFsICgxMyk6Cj4gICBzcGk6 IHNwaS1tZW06IEludHJvZHVjZSBhIGNhcGFiaWxpdHkgc3RydWN0dXJlCj4gICBzcGk6IHNwaS1t ZW06IENoZWNrIHRoZSBjb250cm9sbGVyIGV4dHJhIGNhcGFiaWxpdGllcwo+ICAgc3BpOiBjYWRl bmNlLXF1YWRzcGk6IFByb3ZpZGUgYSBjYXBhYmlsaXR5IHN0cnVjdHVyZQo+ICAgc3BpOiBteGlj OiBQcm92aWRlIGEgY2FwYWJpbGl0eSBzdHJ1Y3R1cmUKPiAgIHNwaTogc3BpLW1lbTogS2lsbCB0 aGUgc3BpX21lbV9kdHJfc3VwcG9ydHNfb3AoKSBoZWxwZXIKPiAgIHNwaTogc3BpLW1lbTogQWRk IGFuIGVjYyBwYXJhbWV0ZXIgdG8gdGhlIHNwaV9tZW1fb3Agc3RydWN0dXJlCj4gICBtdGQ6IHNw aW5hbmQ6IERlbGF5IGEgbGl0dGxlIGJpdCB0aGUgZGlybWFwIGNyZWF0aW9uCj4gICBtdGQ6IHNw aW5hbmQ6IENyZWF0ZSBkaXJlY3QgbWFwcGluZyBkZXNjcmlwdG9ycyBmb3IgRUNDIG9wZXJhdGlv bnMKPiAgIHNwaTogbXhpYzogRml4IHRoZSB0cmFuc21pdCBwYXRoCj4gICBzcGk6IG14aWM6IENy ZWF0ZSBhIGhlbHBlciB0byBjb25maWd1cmUgdGhlIGNvbnRyb2xsZXIgYmVmb3JlIGFuCj4gICAg IG9wZXJhdGlvbgo+ICAgc3BpOiBteGljOiBDcmVhdGUgYSBoZWxwZXIgdG8gZWFzZSB0aGUgc3Rh cnQgb2YgYW4gb3BlcmF0aW9uCj4gICBzcGk6IG14aWM6IEFkZCBzdXBwb3J0IGZvciBkaXJlY3Qg bWFwcGluZwo+ICAgc3BpOiBteGljOiBBZGQgc3VwcG9ydCBmb3IgcGlwZWxpbmVkIEVDQyBvcGVy YXRpb25zCj4gCj4gUHJhdHl1c2ggWWFkYXYgKDEpOgo+ICAgc3BpOiBzcGktbWVtOiByZWplY3Qg cGFydGlhbCBjeWNsZSB0cmFuc2ZlcnMgaW4KPiAKPiAgZHJpdmVycy9tdGQvbmFuZC9zcGkvY29y ZS5jICAgICAgIHwgIDUxICsrKystCj4gIGRyaXZlcnMvc3BpL0tjb25maWcgICAgICAgICAgICAg ICB8ICAgMiArLQo+ICBkcml2ZXJzL3NwaS9zcGktY2FkZW5jZS1xdWFkc3BpLmMgfCAgMTAgKy0K PiAgZHJpdmVycy9zcGkvc3BpLW1lbS5jICAgICAgICAgICAgIHwgIDQ0ICsrLS0KPiAgZHJpdmVy cy9zcGkvc3BpLW14aWMuYyAgICAgICAgICAgIHwgMzQwICsrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLQo+ICBpbmNsdWRlL2xpbnV4L210ZC9zcGluYW5kLmggICAgICAgfCAgIDIgKwo+ICBp bmNsdWRlL2xpbnV4L3NwaS9zcGktbWVtLmggICAgICAgfCAgMjkgKystCj4gIDcgZmlsZXMgY2hh bmdlZCwgMzc4IGluc2VydGlvbnMoKyksIDEwMCBkZWxldGlvbnMoLSkKPiAKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlz Y3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47AEBC433EF for ; Thu, 30 Dec 2021 15:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240100AbhL3PzE convert rfc822-to-8bit (ORCPT ); Thu, 30 Dec 2021 10:55:04 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:47873 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232051AbhL3PzE (ORCPT ); Thu, 30 Dec 2021 10:55:04 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 8792C20000E; Thu, 30 Dec 2021 15:54:56 +0000 (UTC) Date: Thu, 30 Dec 2021 16:54:55 +0100 From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , Cc: Mark Brown , , Julien Su , Jaime Liao , Boris Brezillon , Thomas Petazzoni , Xiangsheng Hou Subject: Re: [PATCH v8 00/14] External ECC engines & Macronix support Message-ID: <20211230165455.7b76fe23@xps13> In-Reply-To: <20211221174844.56385-1-miquel.raynal@bootlin.com> References: <20211221174844.56385-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Mark, miquel.raynal@bootlin.com wrote on Tue, 21 Dec 2021 18:48:30 +0100: > Hello all, > > I've applied the beginning of the series (bindings + ECC part) in a > branch named spi-mem-ecc on the MTD korg repository, hence now I am > re-sending only the second halve, including spi-mem and spi changes, > mostly. When that second part will be validated, I will apply it on top > of the spi-mem-ecc branch and set an immutable tag, shared with the spi > tree. I was hoping for more feedback (from Tudor and perhaps Boris as well?) so as we are in the middle of the Christmas/new year break I decided not to apply this series for my next pull-request to Linus. I will wait a bit more until -rc1 is out and then I will rebase the first half of the series (already applied on the spi-mem-ecc branch on the mtd repository) and add these 14 patches on top of it before sharing it with you 'officially'. Happy new year, Miquèl > > Cheers, > Miquèl > > Changes in v8: > * Applied this patch from Pratyush at the beginning of my series: > https://lore.kernel.org/all/20210531181757.19458-5-p.yadav@ti.com/ > Made the necessary changes in the following commits. > * Changed the spi-mem-op ecc_en parameter to become ecc and match the > dtr parameter. Changed its type to "u8 : 1" as well for the same > reason. Moved it to the data sub-structure as advised by Pratyush. > * Added the received Acks/R-by. > > Changes in v7: > * Added a macro to check if the caps are present or not before accessing > them. This allows for optional caps. > * Dropped the 'no-caps' instance created in v6. > * Reworked a bit all the patches using these caps to have a nice and > bisectable series, like adding missing static keywords. > > Changes in v6: > * Re-include the first patches because a few things have changed in the > bindings. These are only style changes as Rob asked to group every > property above or below the description field, which I applied to all > the binding commits, but without any further update. > * Created a spi-mem capabilities structure. Put that one in the spi-mem > ops strucure and ensured that all the controllers provided one. > * Created a default "no-caps" empty instance that controller drivers can > point to by default. > * Dropped the spi_mem_generic_defaults_op() intermediate helper entirely > (not needed anymore). > > Changes in v5: > * Moved a helper in the core as it seems that it will be useful for > other ECC engines as well (Xiangsheng Hou for Mediatek will need it). > * Changed the parameters of the spi_mem_generic_supports_op() function > in order to take a structure as input instead of a list of arguments, > which will be much easier to complement in the future if ever needed. > > Changes in v4: > * The first half of the series has been left aside (all the binding > changes + the external mode in the Macronix driver), now let's focus > on the pipelined mode. > * Added the ecc_en spi_mem_op structure parameter in a dedicated commit. > * Introduced a new helper for supporting generically the supported ops. > * Used this new helper in the macronix driver. > * By default all the other drivers would refuse a spi_mem_op with ecc_en > enabled. > > Changes in v3: > * Added Mark's R-by. > * Added a commit changing the initialization order between the dirmaps > and the ECC engine so that the core might now if we are using a > pipelined engine or not. > * Stopped creating additional dirmaps with ECC if the engine is not a > pipelined engine. > * Solved the kernel test robot reports. In particular, I added a > dependency on MTD_NAND_ECC to Macronix SPI controller driver. > * Added a patch to clean the NAND controller yaml file before moving > some bits to nand-chip.yaml. This addresses the comments made by Rob > about the useless allOf's. > * Used platform_get_irq_byname_optional() in order to avoid useless > warnings when there is no IRQ. > > Changes in v2: > * Fixed the bindings and added Rob's acks when relevant. > * Added locking in the ECC engine driver. > * Brought more changes in the core in order to bring the ECC information > into the spi_mem_op structure with the idea of avoiding any races > between parallel calls on the same engine. > * Reorganized the ECC driver entirely in order to have a per-engine mxic > structure plus a per-NAND context. This lead to a number of changes > internally which cannot all be listed. > > Changes since the RFC: > * Rebased on top of v5.15-rc1. > * Fixed the dirmap configuration. > * Added the various tags received. > * Fixed the bindings as reported by the robots. > * Fixed the return value of the helper counting bitflips. > * Included a fix from Jaime Liao in the external pattern logic. > * Added the yaml conversion of Macronix SPI controller description. > * Added the yaml conversion of the SPI-NAND description. > * Created a nand-chip.yaml file to share properties between SPI-NAND and > raw NAND. > > Miquel Raynal (13): > spi: spi-mem: Introduce a capability structure > spi: spi-mem: Check the controller extra capabilities > spi: cadence-quadspi: Provide a capability structure > spi: mxic: Provide a capability structure > spi: spi-mem: Kill the spi_mem_dtr_supports_op() helper > spi: spi-mem: Add an ecc parameter to the spi_mem_op structure > mtd: spinand: Delay a little bit the dirmap creation > mtd: spinand: Create direct mapping descriptors for ECC operations > spi: mxic: Fix the transmit path > spi: mxic: Create a helper to configure the controller before an > operation > spi: mxic: Create a helper to ease the start of an operation > spi: mxic: Add support for direct mapping > spi: mxic: Add support for pipelined ECC operations > > Pratyush Yadav (1): > spi: spi-mem: reject partial cycle transfers in > > drivers/mtd/nand/spi/core.c | 51 ++++- > drivers/spi/Kconfig | 2 +- > drivers/spi/spi-cadence-quadspi.c | 10 +- > drivers/spi/spi-mem.c | 44 ++-- > drivers/spi/spi-mxic.c | 340 ++++++++++++++++++++++++------ > include/linux/mtd/spinand.h | 2 + > include/linux/spi/spi-mem.h | 29 ++- > 7 files changed, 378 insertions(+), 100 deletions(-) >